monetdb-java: src/main/java/org/monetdb/jdbc/MonetConnection.java comparison

comparison src/main/java/org/monetdb/jdbc/MonetConnection.java @ 764:052c23fbfab2

Corrected implementation of Connection methods getClientInfo() and setClientInfo(). They used to get/set Connection properties instead of Client Info properties which was a incorrect. MonetDB does not support Client Info properties.

author	Martin van Dinther <martin.van.dinther@monetdbsolutions.com>
date	Wed, 05 Jul 2023 21:34:11 +0200 (22 months ago)
parents	1566dbfaa13b
children	c85c2d90d31f

comparison

equal deleted inserted replaced

-:e8afd7de2538
+:052c23fbfab2
 */
 public class MonetConnection
 	extends MonetWrapper
 	implements Connection, AutoCloseable
 {
-	/** the successful processed input properties */
-	private final Properties conn_props = new Properties();
 	/** The hostname to connect to */
 	private final String hostname;
 	/** The port to connect on the host to */
 	private int port;
 	/** The database to use (currently not used) */
 		HandshakeOption.SizeHeader sizeHeaderSetting = new HandshakeOption.SizeHeader(true);
 		HandshakeOption.TimeZone timeZoneSetting = new HandshakeOption.TimeZone(0);
 		// for debug: System.out.println("New connection object. Received properties are: " + props.toString());
 		// get supported property values from the props argument.
-		// When a value is found add it to the internal conn_props list for use by getClientInfo().
 		this.hostname = props.getProperty("host");
-		if (this.hostname != null)
-			conn_props.setProperty("host", this.hostname);
 		final String port_prop = props.getProperty("port");
 		if (port_prop != null) {
 			try {
 				this.port = Integer.parseInt(port_prop);
 			} catch (NumberFormatException e) {
 				addWarning("Unable to parse port number from: " + port_prop, "M1M05");
 			}
-			conn_props.setProperty("port", Integer.toString(this.port));
 		}
 		this.database = props.getProperty("database");
-		if (this.database != null)
-			conn_props.setProperty("database", this.database);
 		this.username = props.getProperty("user");
-		if (this.username != null)
-			conn_props.setProperty("user", this.username);
 		this.password = props.getProperty("password");
-		if (this.password != null)
-			conn_props.setProperty("password", this.password);
 		String language = props.getProperty("language");
-		if (language != null)
-			conn_props.setProperty("language", language);
 		boolean debug = false;
 		String debug_prop = props.getProperty("debug");
 		if (debug_prop != null) {
 			debug = Boolean.parseBoolean(debug_prop);
-			conn_props.setProperty("debug", Boolean.toString(debug));
 		}
 		final String hash = props.getProperty("hash");
-		if (hash != null)
-			conn_props.setProperty("hash", hash);
 		String autocommit_prop = props.getProperty("autocommit");
 		if (autocommit_prop != null) {
 			boolean ac = Boolean.parseBoolean(autocommit_prop);
 			autoCommitSetting.set(ac);
-			conn_props.setProperty("autocommit", Boolean.toString(ac));
 		}
 		final String fetchsize_prop = props.getProperty("fetchsize");
 		if (fetchsize_prop != null) {
 			try {
 				int fetchsize = Integer.parseInt(fetchsize_prop);
 				if (fetchsize > 0 || fetchsize == -1) {
 					replySizeSetting.set(fetchsize);
-					conn_props.setProperty("fetchsize", fetchsize_prop);
 				} else {
 					addWarning("Fetch size must either be positive or -1. Value " + fetchsize + " ignored", "M1M05");
 				}
 			} catch (NumberFormatException e) {
 				addWarning("Unable to parse fetch size number from: " + fetchsize_prop, "M1M05");
 		}
 		final String treatBlobAsVarBinary_prop = props.getProperty("treat_blob_as_binary");
 		if (treatBlobAsVarBinary_prop != null) {
 			treatBlobAsVarBinary = Boolean.parseBoolean(treatBlobAsVarBinary_prop);
-			conn_props.setProperty("treat_blob_as_binary", Boolean.toString(treatBlobAsVarBinary));
 			if (treatBlobAsVarBinary)
 				typeMap.put("blob", Byte[].class);
 		}
 		final String treatClobAsVarChar_prop = props.getProperty("treat_clob_as_varchar");
 		if (treatClobAsVarChar_prop != null) {
 			treatClobAsVarChar = Boolean.parseBoolean(treatClobAsVarChar_prop);
-			conn_props.setProperty("treat_clob_as_varchar", Boolean.toString(treatClobAsVarChar));
 			if (treatClobAsVarChar)
 				typeMap.put("clob", String.class);
 		}
 		int sockTimeout = 0;
 					sockTimeout = 0;
 				}
 			} catch (NumberFormatException e) {
 				addWarning("Unable to parse socket timeout number from: " + so_timeout_prop, "M1M05");
 			}
-			conn_props.setProperty("so_timeout", Integer.toString(sockTimeout));
 		}
 		// check mandatory input arguments
 		if (hostname == null || hostname.isEmpty())
 			throw new IllegalArgumentException("Missing or empty host name");
 			// fallback to default language: sql
 			language = "sql";
 			addWarning("No language specified, defaulting to 'sql'", "M1M05");
 		}
-		// warn about unrecognized settings
+		// warn about unrecognized property names
 		for (Entry<Object,Object> e: props.entrySet()) {
 			checkValidProperty(e.getKey().toString(), "MonetConnection");
 		}
 		server = new MapiSocket();
 	 *	or this method is called on a closed connection
 	 * @since 1.6
 	 */
 	@Override
 	public String getClientInfo(final String name) throws SQLException {
-		if (name == null || name.isEmpty())
+		// MonetDB doesn't support any Client Info Properties yet
-			return null;
+		return null;
-		checkNotClosed();
-		return conn_props.getProperty(name);
 	}
 	/**
 	 * Returns a list containing the name and current value of each client info
 	 * property supported by the driver. The value of a client info property may
 	 *	or this method is called on a closed connection
 	 * @since 1.6
 	 */
 	@Override
 	public Properties getClientInfo() throws SQLException {
-		checkNotClosed();
+		// MonetDB doesn't support any Client Info Properties yet
-		// return a clone of the connection properties object
+		return new Properties();
-		return new Properties(conn_props);
 	}
 	/**
 	 * Sets the value of the client info property specified by name to the value specified by value.
 	 * Applications may use the DatabaseMetaData.getClientInfoProperties method to determine
 	 *         or this method is called on a closed connection
 	 * @since 1.6
 	 */
 	@Override
 	public void setClientInfo(final String name, final String value) throws SQLClientInfoException {
-		if (name == null || name.isEmpty()) {
+		// MonetDB doesn't support any Client Info Properties yet
-			addWarning("setClientInfo: missing property name", "01M07");
+		addWarning("setClientInfo: client info property name not recognized", "01M07");
-			return;
-		}
-		// If the value is null, the current value of the specified property is cleared.
-		if (value == null) {
-			if (conn_props.containsKey(name))
-				conn_props.remove(name);
-			return;
-		}
-		// only set value for supported property names, warn about the others
-		if (checkValidProperty(name, "setClientInfo")) {
-			conn_props.setProperty(name, value);
-		}
 	}
 	/**
 	 * Sets the value of the connection's client info properties.
 	 * The Properties object contains the names and values of the client info
 	 * @param context the method name from where this is called
 	 * @return valid true or false
 	 */
 	private boolean checkValidProperty(String name, String context) {
 		// supported MonetDB connection properties.
-		// See also MonetDatabaseMetaData.getClientInfoProperties()
+		// See also MonetDriver.connect()
 		if (name.equals("host")
 		 || name.equals("port")
 		 || name.equals("user")
 		 || name.equals("password")
 		 || name.equals("language")
 		 || name.equals("autocommit")
 		 || name.equals("so_timeout")
 		 || name.equals("fetchsize"))	// only supported by servers from version 11.41.1 onwards
 			return true;
-		addWarning(context + ": '" + name + "' is not a recognised property", "01M07");
+		addWarning(context + " property name '" + name + "' is not recognized", "01M07");
 		return false;
 	}
 	// Internal caches for 4 static mserver5 environment values
 	private String env_current_user;

Mercurial > hg > monetdb-java

comparison src/main/java/org/monetdb/jdbc/MonetConnection.java @ 764:052c23fbfab2