monetdb-java: src/main/java/nl/cwi/monetdb/jdbc/MonetConnection.java comparison

comparison src/main/java/nl/cwi/monetdb/jdbc/MonetConnection.java @ 144:d6abd1ffffbb

Use SQLNonTransientConnectionException instead of SQLException where applicable (SQLState starts with 08) Use SQLDataException instead of SQLException where applicable (SQLState starts with 22) Also updated documentation file: SQLSTATEs which documents the MonetDB JDBC driver specific SQLSTATEs

author	Martin van Dinther <martin.van.dinther@monetdbsolutions.com>
date	Thu, 03 Aug 2017 18:53:04 +0200 (2017-08-03)
parents	4320e6891536
children	7c9e386fe49a

comparison

equal deleted inserted replaced

-:dcf7879d4862
+:d6abd1ffffbb
 import java.sql.DatabaseMetaData;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.SQLFeatureNotSupportedException;
+import java.sql.SQLNonTransientConnectionException;
 import java.sql.SQLWarning;
 import java.sql.Savepoint;
 import java.sql.Statement;
 import java.util.ArrayList;
 import java.util.Calendar;
 					f = new File(pre + "-" + i + suf);
 				}
 				server.debug(f.getAbsolutePath());
 			} catch (IOException ex) {
-				throw new SQLException("Opening logfile failed: " + ex.getMessage(), "08M01");
+				throw new SQLNonTransientConnectionException("Opening logfile failed: " + ex.getMessage(), "08M01");
 			}
 		}
 		try {
 			List<String> warnings = server.connect(hostname, port, username, password);
 			in = server.getReader();
 			out = server.getWriter();
 			String error = in.waitForPrompt();
 			if (error != null)
-				throw new SQLException((error.length() > 6) ? error.substring(6) : error, "08001");
+				throw new SQLNonTransientConnectionException((error.length() > 6) ? error.substring(6) : error, "08001");
 		} catch (IOException e) {
-			throw new SQLException("Unable to connect (" + hostname + ":" + port + "): " + e.getMessage(), "08006");
+			throw new SQLNonTransientConnectionException("Unable to connect (" + hostname + ":" + port + "): " + e.getMessage(), "08006");
 		} catch (MCLParseException e) {
-			throw new SQLException(e.getMessage(), "08001");
+			throw new SQLNonTransientConnectionException(e.getMessage(), "08001");
 		} catch (MCLException e) {
 			String[] connex = e.getMessage().split("\n");
-			SQLException sqle = new SQLException(connex[0], "08001", e);
+			SQLException sqle = new SQLNonTransientConnectionException(connex[0], "08001", e);
 			for (int i = 1; i < connex.length; i++) {
-				sqle.setNextException(new SQLException(connex[1], "08001"));
+				sqle.setNextException(new SQLNonTransientConnectionException(connex[1], "08001"));
 			}
 			throw sqle;
 		}
 		// we seem to have managed to log in, let's store the
 	 * objects with the given type and concurrency.  This method is the
 	 * same as the prepareStatement method above, but it allows the
 	 * default result set type and concurrency to be overridden.
 	 *
 	 * @param sql a String object that is the SQL statement to be sent to the
-	 *            database; may contain one or more ? IN parameters
+	 *        database; may contain one or more ? IN parameters
 	 * @param resultSetType a result set type; one of
 	 *        ResultSet.TYPE_FORWARD_ONLY, ResultSet.TYPE_SCROLL_INSENSITIVE,
 	 *        or ResultSet.TYPE_SCROLL_SENSITIVE
 	 * @param resultSetConcurrency a concurrency type; one of
 	 *        ResultSet.CONCUR_READ_ONLY or ResultSet.CONCUR_UPDATABLE
 	 * @return a new PreparedStatement object containing the pre-compiled SQL
 	 *         statement that will produce ResultSet objects with the given
 	 *         type and concurrency
 	 * @throws SQLException if a database access error occurs or the given
-	 *                      parameters are not ResultSet constants indicating
+	 *         parameters are not ResultSet constants indicating
-	 *                      type and concurrency
+	 *         type and concurrency
 	 */
 	@Override
 	public PreparedStatement prepareStatement(String sql, int resultSetType, int resultSetConcurrency) throws SQLException {
 		return prepareStatement(sql, resultSetType, resultSetConcurrency, ResultSet.HOLD_CURSORS_OVER_COMMIT);
 	}
 			throw new SQLException("milliseconds is less than zero", "M1M05");
 		try {
 			server.setSoTimeout(millis);
 		} catch (SocketException e) {
-			throw new SQLException(e.getMessage(), "08000");
+			throw new SQLNonTransientConnectionException(e.getMessage(), "08000");
 		}
 	}
 	/**
 	 * Retrieves the number of milliseconds the driver will wait for a
 			throw new SQLException("Cannot call on closed Connection", "M1M20");
 		try {
 			return server.getSoTimeout();
 		} catch (SocketException e) {
-			throw new SQLException(e.getMessage(), "08000");
+			throw new SQLNonTransientConnectionException(e.getMessage(), "08000");
 		}
 	}
 	//== end methods of interface java.sql.Connection
 	 */
 	public String getJDBCURL() {
 		String language = "";
 		if (lang == LANG_MAL)
 			language = "?language=mal";
-		return "jdbc:monetdb://" + hostname + ":" + port + "/" +
+		return "jdbc:monetdb://" + hostname + ":" + port + "/" + database + language;
-			database + language;
 	}
 	/**
 	 * Returns whether the BLOB type should be mapped to BINARY type.
 	 */
 						(queryTempl[0] == null ? "" : queryTempl[0]) +
 						command +
 						(queryTempl[1] == null ? "" : queryTempl[1]));
 				String error = in.waitForPrompt();
 				if (error != null)
-					throw new SQLException(error.substring(6),
+					throw new SQLException(error.substring(6), error.substring(0, 5));
-							error.substring(0, 5));
 			} catch (SocketTimeoutException e) {
 				close(); // JDBC 4.1 semantics: abort()
-				throw new SQLException("connection timed out", "08M33");
+				throw new SQLNonTransientConnectionException("connection timed out", "08M33");
 			} catch (IOException e) {
-				throw new SQLException(e.getMessage(), "08000");
+				throw new SQLNonTransientConnectionException(e.getMessage(), "08000");
 			}
 		}
 	}
 	/**
 						(commandTempl[0] == null ? "" : commandTempl[0]) +
 						command +
 						(commandTempl[1] == null ? "" : commandTempl[1]));
 				String error = in.waitForPrompt();
 				if (error != null)
-					throw new SQLException(error.substring(6),
+					throw new SQLException(error.substring(6), error.substring(0, 5));
-							error.substring(0, 5));
 			} catch (SocketTimeoutException e) {
 				close(); // JDBC 4.1 semantics, abort()
-				throw new SQLException("connection timed out", "08M33");
+				throw new SQLNonTransientConnectionException("connection timed out", "08M33");
 			} catch (IOException e) {
-				throw new SQLException(e.getMessage(), "08000");
+				throw new SQLNonTransientConnectionException(e.getMessage(), "08000");
 			}
 		}
 	}
 	/**
 		 * @param id the ID of the result set
 		 * @param tuplecount the total number of tuples in the result set
 		 * @param columncount the number of columns in the result set
 		 * @param rowcount the number of rows in the current block
 		 * @param parent the parent that created this Response and will
-		 *               supply new result blocks when necessary
+		 *        supply new result blocks when necessary
 		 * @param seq the query sequence number
 		 */
 		ResultSetResponse(
 				int id,
 				int tuplecount,
 		/**
 		 * Marks this Response as being completed.  A complete Response
 		 * needs to be consistent with regard to its internal data.
 		 *
 		 * @throws SQLException if the data currently in this Response is not
-		 *                      sufficient to be consistant
+		 *         sufficient to be consistant
 		 */
 		@Override
 		public void complete() throws SQLException {
 			String error = "";
 			if (!isSet[NAMES])  error = "name header missing\n";
 				}
 				if (error != null) {
 					SQLException ret = null;
 					String[] errors = error.split("\n");
 					for (int i = 0; i < errors.length; i++) {
+						SQLException newErr;
+						if (errors[i].length() >= 6) {
+							newErr = new SQLException(errors[i].substring(6), errors[i].substring(0, 5));
+						} else {
+							newErr = new SQLNonTransientConnectionException(errors[i], "08000");
+						}
 						if (ret == null) {
-							ret = new SQLException(errors[i].substring(6),
+							ret = newErr;
-									errors[i].substring(0, 5));
 						} else {
-							ret.setNextException(new SQLException(
+							ret.setNextException(newErr);
-										errors[i].substring(6),
-										errors[i].substring(0, 5)));
 						}
 					}
 					throw ret;
 				}
 			} catch (SocketTimeoutException e) {
 				close(); // JDBC 4.1 semantics, abort()
-				throw new SQLException("connection timed out", "08M33");
+				throw new SQLNonTransientConnectionException("connection timed out", "08M33");
 			} catch (IOException e) {
 				closed = true;
-				throw new SQLException(e.getMessage() + " (mserver still alive?)", "08000");
+				throw new SQLNonTransientConnectionException(e.getMessage() + " (mserver5 still alive?)", "08006");
 			}
 		}
 	}
 	// }}}

Mercurial > hg > monetdb-java

comparison src/main/java/nl/cwi/monetdb/jdbc/MonetConnection.java @ 144:d6abd1ffffbb