Mercurial > hg > monetdb-java

changeset 490:a6c98b35a054

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Optimize setNull(3 args) method by doing the same thing as setNull(2 args) Updated some comments
author Martin van Dinther <martin.van.dinther@monetdbsolutions.com>
date Wed, 04 Aug 2021 23:04:58 +0200 (2021-08-04)
parents 9fcf77d703b1
children 5590589fe7c7
files src/main/java/org/monetdb/jdbc/MonetPreparedStatement.java
diffstat 1 files changed, 9 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/src/main/java/org/monetdb/jdbc/MonetPreparedStatement.java
+++ b/src/main/java/org/monetdb/jdbc/MonetPreparedStatement.java
@@ -314,10 +314,10 @@ public class MonetPreparedStatement
 	 * be an SQL INSERT, UPDATE or DELETE statement; or an SQL statement that
 	 * returns nothing, such as a DDL statement.
 	 *
-	 * @return either (1) the row count for INSERT, UPDATE, or DELETE
-	 *         statements or (2) 0 for SQL statements that return nothing
+	 * @return either (1) the row count for INSERT, UPDATE, or DELETE statements
+	 *             or (2) 0 for SQL statements that return nothing
 	 * @throws SQLException if a database access error occurs or the SQL
-	 *                     statement returns a ResultSet object
+	 *                      statement returns a ResultSet object
 	 */
 	@Override
 	public int executeUpdate() throws SQLException {
@@ -417,8 +417,8 @@ public class MonetPreparedStatement
 			 */
 			@Override
 			public boolean isAutoIncrement(final int column) throws SQLException {
-				/* TODO: in MonetDB only numeric (int, decimal) columns could be autoincrement/serial
-				 * This however requires an expensive dbmd.getColumns(null, schema, table, column)
+				/* In MonetDB only integer (int, bigint, smallint, tinyint) columns can be autoincrement/serial
+				 * TODO: This however requires an expensive dbmd.getColumns(null, schema, table, column)
 				 * query call to pull the IS_AUTOINCREMENT value for this column.
 				 * See also ResultSetMetaData.isAutoIncrement()
 				 */
@@ -1673,16 +1673,16 @@ public class MonetPreparedStatement
 	 * @param parameterIndex the first parameter is 1, the second is 2, ...
 	 * @param sqlType a value from java.sql.Types
 	 * @param typeName the fully-qualified name of an SQL user-defined type;
-	 *                 ignored if the parameter is not a user-defined type or
-	 *                 REF
+	 *                 ignored if the parameter is not a user-defined type or REF
 	 * @throws SQLException if a database access error occurs
 	 */
 	@Override
 	public void setNull(final int parameterIndex, final int sqlType, final String typeName)
 		throws SQLException
 	{
-		// MonetDB/SQL's NULL needs no type
-		setNull(parameterIndex, sqlType);
+		// we discard the given type and name here, the backend converts the
+		// value NULL to whatever it needs for the column
+		setValue(parameterIndex, "NULL");
 	}
 
 	/**