August 2020 - developers-list

New Oct2020 stable branch created
by Sjoerd Mullender 21 Aug '20

21 Aug '20

I have created a new stable branch for the next feature release. This branch was created in order to stabilize the code before the feature release. >From now on *only* bug fixes may go to this new stable branch. I reserve the right to undo any changes that do not comply with this rule. I also reserve the right to admit changes that are not strictly bug fixes. The name for the branch is Oct2020. So in each of your stable checkout directories you can do hg pull hg update -rOct2020 to update to this new branch. -- Sjoerd Mullender

1 0

Possible leaks (MonetDB-11.37.7\common\stream\stream.c)
by Ranier Vilela 04 Aug '20

04 Aug '20

Possible leaks: MonetDB-11.37.7\common\stream\stream. 1. At line 1306 if (stream_bzread(s, buf, 1, UTF8BOMLENGTH) == UTF8BOMLENGTH && strncmp(buf, UTF8BOM, UTF8BOMLENGTH) == 0) { s->isutf8 = true; } else if (s->stream_data.p) { bzp = s->stream_data.p; BZ2_bzReadClose(&err, bzp->b); rewind(bzp->f); bzp->b = BZ2_bzReadOpen(&err, bzp->f, 0, 0, NULL, 0); } If stream_bzread at line 1302 is successful, and (s->stream_data.p) is not null at line 1305, bzp (original pointer malloc) is not lost at line 1306? bzp = s->stream_data.p; 2. At line 1322: if (err != BZ_OK) { stream_bzclose(s); destroy(s); return NULL; } miss free(bzp);? destroy(s) do not free bzp, according, with line 1283. 3. At line 2350 miss free(c); regards, Ranier Vilela

2 4

Possible type with bitwise operator (&)
by Ranier Vilela 03 Aug '20

03 Aug '20

Hi, At gdk\gdk_bat.c (line 1384) variable b->type is bool Would be a typo? if (((b->ttype != TYPE_void) & b->tkey) && b->batCount > 1) { Should be: if (((b->ttype != TYPE_void) && b->tkey) && b->batCount > 1) { regards, Ranier Vilela

4 16

Possible typo with bitwise operator (&)
by Ranier Vilela 01 Aug '20

01 Aug '20

Hi, At gdk\gdk_bat.c (line 1384) variable b->type is bool Would be a typo? if (((b->ttype != TYPE_void) & b->tkey) && b->batCount > 1) { Should be: if (((b->ttype != TYPE_void) && b->tkey) && b->batCount > 1) { regards, Ranier Vilela

1 0