- developers-list - monetdb.org

Re: [Monetdb-developers] MonetDB: default - Remainder of group optimizer additions.
by Sjoerd Mullender 12 Mar '12

12 Mar '12

The new opt_group optimizer defines a group.new function that is not compatible with the existing group.new functions. In group.mx we have the definitions command new(b:bat[:any_1,:any_2], start:int, incr:int, grpsize:int) :bat[:any_1,:int] command new(attr:bat[:any_1,:any_2] ) (histo:bat[:any_1,:wrd], grp:bat[:any_1,:void]) command new(attr:bat[:any_1,:any_2] ) (histo:bat[:any_1,:wrd], grp:bat[:any_1,:oid]) command new(attr:bat[:any_1,:any_2], N:int, rng:int) (histo:bat[:any_1,:wrd],grp:bat[:any_1,:oid]) If called with a single :bat[:oid,:oid] bat as argument (as sql.zero_or_one does), it returns two bats with types :bat[:oid,:wrd] and :bat[:oid,:oid] The group.new in the new opt_group optimizer is defined as pattern group.new(l:bat[:oid,:any]...)(grp:bat[:oid,:any],ext:bat[:oid,:any]) so if this one is called with a single :bat[:oid,:oid] bat as argument, it returns two bats with types :bat[:oid,:oid] and :bat[:oid,:oid]. Of course, we now get the one sql.zero_or_one does *not* expect (since it is defined later). This causes a bunch of tests to fail. On 2012-03-12 12:52, Martin Kersten wrote: > Changeset: 89489d21d9bb for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=89489d21d9bb > Added Files: > monetdb5/optimizer/opt_groups.mx > Removed Files: > monetdb5/optimizer/Tests/derivePath00.mal > monetdb5/optimizer/Tests/groupderive.mal > monetdb5/optimizer/Tests/groupderive.stable.err > monetdb5/optimizer/Tests/groupderive.stable.out > monetdb5/optimizer/opt_derivepath.mx > Modified Files: > monetdb5/optimizer/Tests/All > sql/test/Tests/setoptimizer.stable.err > sql/test/Tests/setoptimizer.stable.out > Branch: default > Log Message: > > Remainder of group optimizer additions. > > > diffs (truncated from 654 to 300 lines): > > diff --git a/monetdb5/optimizer/Tests/All b/monetdb5/optimizer/Tests/All > --- a/monetdb5/optimizer/Tests/All > +++ b/monetdb5/optimizer/Tests/All > @@ -74,7 +74,7 @@ mitosis00 > > joinpath > leftjoinpath > -groupderive > +groups00 > > ifthencst > CXerror1 > diff --git a/monetdb5/optimizer/Tests/derivePath00.mal b/monetdb5/optimizer/Tests/derivePath00.mal > deleted file mode 100644 > --- a/monetdb5/optimizer/Tests/derivePath00.mal > +++ /dev/null > @@ -1,19 +0,0 @@ > --- select distinct(A) from T > --- only needs the group extend table, which means we can use a kunique. > -function tst(); > -b:= bat.new(:oid,:str); > - > -bat.append(b,"hello"); > -bat.append(b,"hello"); > -bat.append(b,"world"); > -br:= bat.reverse(b); > -k:= algebra.kunique(br); > -kr:= bat.reverse(k); > -io.print(kr); > -(e,g):= group.new(b); > -io.print(e); > -end tst; > - > -user.tst(); > -optimizer.derivePath("user","tst"); > -mdb.List("user","tst"); > diff --git a/monetdb5/optimizer/Tests/groupderive.mal b/monetdb5/optimizer/Tests/groupderive.mal > deleted file mode 100644 > --- a/monetdb5/optimizer/Tests/groupderive.mal > +++ /dev/null > @@ -1,10 +0,0 @@ > -function tst(); > - b:= bat.new(:oid,:int); > - c:= bat.new(:oid,:str); > - d:= bat.new(:oid,:flt); > - (ext1,grp1) := group.new(b); > - (ext2,grp2) := group.derive(ext1,grp1, c); > - (ext3,grp3) := group.derive(ext2,grp2, d); > -end tst; > -optimizer.derivePath("user","tst"); > -mdb.list("user","tst"); > diff --git a/monetdb5/optimizer/Tests/groupderive.stable.err b/monetdb5/optimizer/Tests/groupderive.stable.err > deleted file mode 100644 > --- a/monetdb5/optimizer/Tests/groupderive.stable.err > +++ /dev/null > @@ -1,80 +0,0 @@ > -stderr of test 'groupderive` in directory 'optimizer` itself: > - > - > -# 09:23:28 > > -# 09:23:28 > mserver5 "--config=/ufs/mk/monet5//Linux/etc/monetdb5.conf" --debug=10 --set gdk_nr_threads=0 --set "monet_mod_path=/ufs/mk/monet5//Linux/lib/MonetDB5:/ufs/mk/monet5//Linux/lib/MonetDB5/lib:/ufs/mk/monet5//Linux/lib/MonetDB5/bin" --set "gdk_dbfarm=/ufs/mk/monet5//Linux/var/MonetDB5/dbfarm" --set "sql_logdir=/ufs/mk/monet5//Linux/var/MonetDB5/sql_logs" --set mapi_open=true --set xrpc_open=true --set mapi_port=30087 --set xrpc_port=43368 --set xrpc_docroot=/ufs/mk/monet5/package/MonetDB5 --set monet_prompt= --trace --dbname=mTests_src_optimizer groupderive.mal > -# 09:23:28 > > - > -# builtin opt gdk_arch = 64bitx86_64-unknown-linux-gnu > -# builtin opt gdk_version = 1.28.1 > -# builtin opt monet_pid = 10370 > -# builtin opt prefix = /ufs/mk/monet5//Linux > -# builtin opt exec_prefix = ${prefix} > -# builtin opt gdk_dbname = tst > -# builtin opt gdk_dbfarm = ${prefix}/var/MonetDB > -# builtin opt gdk_debug = 8 > -# builtin opt gdk_mem_bigsize = 262144 > -# builtin opt gdk_alloc_map = yes > -# builtin opt gdk_mem_pagebits = 14 > -# builtin opt gdk_vmtrim = yes > -# builtin opt monet_admin = adm > -# builtin opt monet_prompt = > > -# builtin opt monet_welcome = yes > -# builtin opt monet_mod_path = ${exec_prefix}/lib/MonetDB:${exec_prefix}/lib/bin > -# builtin opt monet_daemon = yes > -# builtin opt host = localhost > -# builtin opt mapi_port = 50000 > -# builtin opt mapi_noheaders = no > -# builtin opt mapi_debug = 0 > -# builtin opt mapi_clients = 2 > -# builtin opt sql_debug = 0 > -# builtin opt sql_logdir = ${prefix}/var/MonetDB > -# builtin opt xquery_logdir = ${prefix}/var/MonetDB > -# builtin opt standoff_ns = http://monetdb.cwi.nl/standoff > -# builtin opt standoff_start = start > -# builtin opt standoff_end = end > -# config opt prefix = /ufs/mk/monet5//Linux > -# config opt config = ${prefix}/etc/monetdb5.conf > -# config opt prefix = /ufs/mk/monet5//Linux > -# config opt exec_prefix = ${prefix} > -# config opt gdk_dbfarm = ${prefix}/var/MonetDB5/dbfarm > -# config opt gdk_dbname = demo > -# config opt gdk_alloc_map = no > -# config opt gdk_embedded = no > -# config opt gdk_debug = 0 > -# config opt monet_mod_path = ${exec_prefix}/lib/MonetDB5:${exec_prefix}/lib/MonetDB5/lib:${exec_prefix}/lib/MonetDB5/bin > -# config opt monet_daemon = no > -# config opt monet_welcome = yes > -# config opt mero_msglog = ${prefix}/var/log/merovingian.log > -# config opt mero_errlog = ${prefix}/var/log/merovingian.log > -# config opt mero_timeinterval = 600 > -# config opt mero_pidfile = ${prefix}/var/run/merovingian.pid > -# config opt mero_exittimeout = 7 > -# config opt mero_doproxy = yes > -# config opt mero_discoveryttl = 600 > -# config opt mal_init = ${exec_prefix}/lib/MonetDB5/mal_init.mal > -# config opt mal_listing = 2 > -# config opt checkpoint_dir = ${prefix}/var/MonetDB5/chkpnt > -# config opt mapi_port = 50000 > -# config opt mapi_open = false > -# config opt sql_logdir = ${prefix}/var/MonetDB5/sql_logs > -# config opt sql_init = ${exec_prefix}/lib/MonetDB5/sql_init.sql > -# cmdline opt config = /ufs/mk/monet5//Linux/etc/monetdb5.conf > -# cmdline opt gdk_nr_threads = 0 > -# cmdline opt monet_mod_path = /ufs/mk/monet5//Linux/lib/MonetDB5:/ufs/mk/monet5//Linux/lib/MonetDB5/lib:/ufs/mk/monet5//Linux/lib/MonetDB5/bin > -# cmdline opt gdk_dbfarm = /ufs/mk/monet5//Linux/var/MonetDB5/dbfarm > -# cmdline opt sql_logdir = /ufs/mk/monet5//Linux/var/MonetDB5/sql_logs > -# cmdline opt mapi_open = true > -# cmdline opt xrpc_open = true > -# cmdline opt mapi_port = 30087 > -# cmdline opt xrpc_port = 43368 > -# cmdline opt xrpc_docroot = /ufs/mk/monet5/package/MonetDB5 > -# cmdline opt monet_prompt = > -# cmdline opt gdk_dbname = mTests_src_optimizer > -#warning: please don't forget to set your vault key! > -#(see /ufs/mk/monet5//Linux/etc/monetdb5.conf) > - > -# 09:23:28 > > -# 09:23:28 > Done. > -# 09:23:28 > > - > diff --git a/monetdb5/optimizer/Tests/groupderive.stable.out b/monetdb5/optimizer/Tests/groupderive.stable.out > deleted file mode 100644 > --- a/monetdb5/optimizer/Tests/groupderive.stable.out > +++ /dev/null > @@ -1,38 +0,0 @@ > -stdout of test 'groupderive` in directory 'optimizer` itself: > - > - > -# 09:23:28 > > -# 09:23:28 > mserver5 "--config=/ufs/mk/monet5//Linux/etc/monetdb5.conf" --debug=10 --set gdk_nr_threads=0 --set "monet_mod_path=/ufs/mk/monet5//Linux/lib/MonetDB5:/ufs/mk/monet5//Linux/lib/MonetDB5/lib:/ufs/mk/monet5//Linux/lib/MonetDB5/bin" --set "gdk_dbfarm=/ufs/mk/monet5//Linux/var/MonetDB5/dbfarm" --set "sql_logdir=/ufs/mk/monet5//Linux/var/MonetDB5/sql_logs" --set mapi_open=true --set xrpc_open=true --set mapi_port=30087 --set xrpc_port=43368 --set xrpc_docroot=/ufs/mk/monet5/package/MonetDB5 --set monet_prompt= --trace --dbname=mTests_src_optimizer groupderive.mal > -# 09:23:28 > > - > -# MonetDB server v5.10.1, based on kernel v1.28.1 > -# Serving database 'mTests_src_optimizer', using 4 threads > -# Compiled for x86_64-unknown-linux-gnu/64bit with 64bit OIDs dynamically linked > -# Copyright (c) 1993-July 2008 CWI. > -# Copyright (c) August 2008- MonetDB B.V., all rights reserved > -# Visit http://monetdb.cwi.nl/ for further information > -# Listening for connection requests on mapi:monetdb://eir.ins.cwi.nl:30087/ > -function user.tst():void; > - b := bat.new(:oid,:int); > - c := bat.new(:oid,:str); > - d := bat.new(:oid,:flt); > - (ext1,grp1) := group.new(b); > - (ext2,grp2) := group.derive(ext1,grp1,c); > - (ext3,grp3) := group.derive(ext2,grp2,d); > -end tst; > -function user.main():void; > - mdb.list("user","tst"); > -end main; > -function user.tst():void; > - b := bat.new(:oid,:int); > - c := bat.new(:oid,:str); > - d := bat.new(:oid,:flt); > - (ext1,grp1) := group.derivePath(b); > - (ext2,grp2) := group.derivePath(b,c); > - (ext3,grp3) := group.derivePath(b,c,d); > -end tst; > - > -# 09:23:28 > > -# 09:23:28 > Done. > -# 09:23:28 > > - > diff --git a/monetdb5/optimizer/opt_derivepath.mx b/monetdb5/optimizer/opt_derivepath.mx > deleted file mode 100644 > --- a/monetdb5/optimizer/opt_derivepath.mx > +++ /dev/null > @@ -1,239 +0,0 @@ > -@/ > -The contents of this file are subject to the MonetDB Public License > -Version 1.1 (the "License"); you may not use this file except in > -compliance with the License. You may obtain a copy of the License at > -http://www.monetdb.org/Legal/MonetDBLicense > - > -Software distributed under the License is distributed on an "AS IS" > -basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the > -License for the specific language governing rights and limitations > -under the License. > - > -The Original Code is the MonetDB Database System. > - > -The Initial Developer of the Original Code is CWI. > -Portions created by CWI are Copyright (C) 1997-July 2008 CWI. > -Copyright August 2008-2012 MonetDB B.V. > -All Rights Reserved. > -@ > - > -@f opt_derivepath > - > -@c > -/* > - * @- Group derive paths > - * The routine @sc{optimizer.derivepaths()} > - * walks through the program looking for grouping operations > - * and cascades them into a single multiple group paths. > - * To illustrate, consider > - * @verbatim > - * (ext1,grp1) := group.new(b); > - * (ext2,grp2) := group.derive(ext1,grp1, c); > - * (ext3,grp3) := group.done(ext2,grp2, d); > - * @end verbatim > - * The result becomes. > - * @verbatim > - * (ext3,grp3) := group.derivepath(b,c,d); > - * @end verbatim > - * > - * The implementation of this operator can freely re-order the BATs > - * for reduced intermediate results or as a basis for parallel scanning > - * all BATs involved to derive their group id. > - * > - * The collection can be extended to immediately aim for group counting > - * or summation, avoiding the materialisation of the group id table. > - */ > -@mal > -pattern optimizer.derivePath():str > -address OPTderivePath; > -pattern optimizer.derivePath(mod:str, fcn:str):str > -address OPTderivePath > -comment "Join path constructor"; > - > -pattern group.derivePath(l:bat[:oid,:any]...)(grp:bat[:oid,:any],ext:bat[:oid,:any]) > -address ALGderivePath > -comment "Derive a group index."; > - > -pattern group.deriveCount(l:bat[:oid,:any]...):bat[:oid,:wrd] > -address ALGderiveCount > -comment "Derive a group count."; > - > -pattern group.deriveSum(s:bat[:oid,:int],l:bat[:oid,:any]...):bat[:oid,:int] > -address ALGderiveSum > -comment "Derive a group sum."; > -pattern group.deriveSum(s:bat[:oid,:lng],l:bat[:oid,:any]...):bat[:oid,:lng] > -address ALGderiveSum > -comment "Derive a group sum."; > -pattern group.deriveSum(s:bat[:oid,:flt],l:bat[:oid,:any]...):bat[:oid,:flt] > -address ALGderiveSum > -comment "Derive a group sum."; > -pattern group.deriveSum(s:bat[:oid,:dbl],l:bat[:oid,:any]...):bat[:oid,:dbl] > -address ALGderiveSum > -comment "Derive a group sum."; > -@h > -#ifndef _OPT_DERIVEPATH_ > -#define _OPT_DERIVEPATH_ > -#include "opt_prelude.h" > -#include "opt_support.h" > -#include "mal_interpreter.h" > - > -opt_export str ALGderivePath(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci); > -opt_export str ALGderiveCount(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci); > -opt_export str ALGderiveSum(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci); > - > -#define OPTDEBUGderivePath if ( optDebug & ((lng)1 <<DEBUG_OPT_DERIVEPATH) ) > - > -@c > -#include "monetdb_config.h" > -#include "opt_derivepath.h" > -#include "group.h" > - > -static int > -OPTderivePathImplementation(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr p) > -{ > - int i, actions=0; > - int *pc; > - InstrPtr q; > - InstrPtr *old; > - int limit,slimit; > - Lifespan span; > - > - > - > - (void) cntxt; > - (void) stk; > - span= setLifespan(mb); > - if( span == NULL) > - return 0; > - if (varGetProp(mb, getArg(mb->stmt[0], 0), inlineProp) != NULL) > - return 0; > - > - /* beware, new variables and instructions are introduced */ > - pc= (int*) GDKzalloc(sizeof(int)* mb->vtop * 2); /* to find last assignment */ > - if ( pc == NULL) > - return 0; > - > - old= mb->stmt; > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list -- Sjoerd Mullender

1 0

Re: [Monetdb-developers] MonetDB: sciql - Be more correct with the "fixed" property of th...
by Stefan Manegold 07 Mar '12

07 Mar '12

Jennie, this checkin appear to trigger different output for the following tests: sql/test/BugDay_2005-11-09_2.8/Tests/ORDER_BY_evaluation_error.SF-1023658 sql/test/BugTracker-2009/Tests/join_topn.SF-2654133 sql/test/BugTracker-2010/Tests/offset_limited_32bit.SF-2950579 sql/test/BugTracker/Tests/like_exp.SF-1613949 sql/test/bugs/Tests/select_orderby_alias-bug-sf-1024615 Could you please check, whether the new output is the desired and correct one, and if so, approve it, or otherwise check whether you can fix the code? No hurry. I just happend to notice this and hence do report it ;-) Stefan On Tue, Mar 06, 2012 at 05:42:18PM +0100, Jennie Zhang wrote: > Changeset: a27b334ae151 for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=a27b334ae151 > Modified Files: > sql/backends/monet5/sql.mx > sql/server/rel_schema.c > sql/server/sql_mvc.c > sql/storage/sql_storage.h > sql/storage/store.c > sql/test/sciql/Tests/01_create_01.sql > sql/test/sciql/Tests/01_create_01.stable.out > Branch: sciql > Log Message: > > Be more correct with the "fixed" property of the SQL catalog > > renamed "fixed" into "fixed_array" in the SQL catalog and set it value to FALSE > (i.s.o. TRUE) for all tables. > > added tests to check if "fixed_array" and "nr_dimensions" in the SQL catalog > are computed correctly. apporved new stable.out > > > diffs (251 lines): > > diff --git a/sql/backends/monet5/sql.mx b/sql/backends/monet5/sql.mx > --- a/sql/backends/monet5/sql.mx > +++ b/sql/backends/monet5/sql.mx > @@ -1881,7 +1881,7 @@ create_table_or_view( mvc *sql, char *sn > } > } > > - nt = sql_trans_create_table(sql->session->tr, s, t->base.name, t->query, t->type, t->system, temp, t->commit_action, t->sz, &t->fixed, &t->ndims); > + nt = sql_trans_create_table(sql->session->tr, s, t->base.name, t->query, t->type, t->system, temp, t->commit_action, t->sz, t->fixed, t->ndims); > > for (n = t->columns.set->h; n; n = n->next) { > sql_column *c = n->data; > diff --git a/sql/server/rel_schema.c b/sql/server/rel_schema.c > --- a/sql/server/rel_schema.c > +++ b/sql/server/rel_schema.c > @@ -729,7 +729,9 @@ create_column(mvc *sql, symbol *s, sql_s > cs->dim->step = GDKstrdup(""); > cs->dim->stop = GDKstrdup(""); > } > - t->fixed = isFixedDim(cs->dim); > + if (!(isFixedDim(cs->dim))) > + t->fixed = 0; > + > /* TODO: the case "ARRAY dim_range_list" is not dealt with */ > } > if (column_options(sql, opt_list, ss, t, cs) == SQL_ERR) > @@ -992,6 +994,8 @@ rel_create_table(mvc *sql, sql_schema *s > int i = 0, j = 0, cnt = 0, *N = NULL, *M = NULL; > lng cntall = 1; > > + if (isArray(t)) > + t->fixed = 1; > for (n = columns->h; n; n = n->next) { > symbol *sym = n->data.sym; > int res = table_element(sql, sym, s, t, 0); > diff --git a/sql/server/sql_mvc.c b/sql/server/sql_mvc.c > --- a/sql/server/sql_mvc.c > +++ b/sql/server/sql_mvc.c > @@ -87,7 +87,7 @@ mvc_init(char *dbname, int debug, store_ > mvc_create_column_(m, t, "system", "boolean", 1); > mvc_create_column_(m, t, "commit_action", "smallint", 16); > mvc_create_column_(m, t, "readonly", "boolean", 1); > - mvc_create_column_(m, t, "fixed", "boolean", 1); > + mvc_create_column_(m, t, "fixed_array", "boolean", 1); > mvc_create_column_(m, t, "nr_dimensions", "int", 32); > mvc_create_column_(m, t, "temporary", "smallint", 16); > > @@ -124,7 +124,7 @@ mvc_init(char *dbname, int debug, store_ > mvc_create_column_(m, t, "system", "boolean", 1); > mvc_create_column_(m, t, "commit_action", "smallint", 16); > mvc_create_column_(m, t, "readonly", "boolean", 1); > - mvc_create_column_(m, t, "fixed", "boolean", 1); > + mvc_create_column_(m, t, "fixed_array", "boolean", 1); > mvc_create_column_(m, t, "nr_dimensions", "int", 32); > mvc_create_column_(m, t, "temporary", "smallint", 16); > if (catalog_version) { > @@ -1029,13 +1029,13 @@ mvc_create_table(mvc *m, sql_schema *s, > tt == tt_table? "TABLE":(tt == tt_array? "ARRAY":"OTHER_TT"), > s->base.name, name, tt, system, persistence, commit_action); > > - /* FIXME: are the NULLs correct values for 'fixed' and 'ndims'? */ > if (persistence == SQL_DECLARED_TABLE && (!s || strcmp(s->base.name, dt_schema))) { > /* declared tables should not end up in the catalog */ > - t = create_sql_table(m->sa, name, tt, system, persistence, commit_action, NULL, NULL); > + /* actual values of 'fixed' and 'ndims' are computed later */ > + t = create_sql_table(m->sa, name, tt, system, persistence, commit_action, 0, 0); > t->s = s; > } else { > - t = sql_trans_create_table(m->session->tr, s, name, NULL, tt, system, persistence, commit_action, sz, NULL, NULL); > + t = sql_trans_create_table(m->session->tr, s, name, NULL, tt, system, persistence, commit_action, sz, 0, 0); > } > return t; > } > @@ -1049,11 +1049,11 @@ mvc_create_view(mvc *m, sql_schema *s, c > fprintf(stderr, "#mvc_create_view %s %s %s\n", s->base.name, name, sql); > > if (persistence == SQL_DECLARED_TABLE) { > - t = create_sql_table(m->sa, name, tt_view, system, persistence, 0, NULL, NULL); > + t = create_sql_table(m->sa, name, tt_view, system, persistence, 0, 0, 0); > t->s = s; > t->query = sa_strdup(m->sa, sql); > } else { > - t = sql_trans_create_table(m->session->tr, s, name, sql, tt_view, system, SQL_PERSIST, 0, 0, NULL, NULL); > + t = sql_trans_create_table(m->session->tr, s, name, sql, tt_view, system, SQL_PERSIST, 0, 0, 0, 0); > } > return t; > } > @@ -1067,11 +1067,11 @@ mvc_create_remote(mvc *m, sql_schema *s, > fprintf(stderr, "#mvc_create_remote %s %s %s\n", s->base.name, name, loc); > > if (persistence == SQL_DECLARED_TABLE) { > - t = create_sql_table(m->sa, name, tt_remote, 0, persistence, 0, NULL, NULL); > + t = create_sql_table(m->sa, name, tt_remote, 0, persistence, 0, 0, 0); > t->s = s; > t->query = sa_strdup(m->sa, loc); > } else { > - t = sql_trans_create_table(m->session->tr, s, name, loc, tt_remote, 0, SQL_REMOTE, 0, 0, NULL, NULL); > + t = sql_trans_create_table(m->session->tr, s, name, loc, tt_remote, 0, SQL_REMOTE, 0, 0, 0, 0); > } > return t; > } > @@ -1084,7 +1084,7 @@ mvc_create_generated(mvc *m, sql_schema > if (mvc_debug) > fprintf(stderr, "#mvc_create_generated %s %s %s\n", s->base.name, name, sql); > > - t = sql_trans_create_table(m->session->tr, s, name, sql, tt_generated, system, SQL_PERSIST, 0, 0, NULL, NULL); > + t = sql_trans_create_table(m->session->tr, s, name, sql, tt_generated, system, SQL_PERSIST, 0, 0, 0, 0); > return t; > } > > diff --git a/sql/storage/sql_storage.h b/sql/storage/sql_storage.h > --- a/sql/storage/sql_storage.h > +++ b/sql/storage/sql_storage.h > @@ -314,7 +314,7 @@ extern void reset_functions(sql_trans *t > extern sql_schema *sql_trans_create_schema(sql_trans *tr, char *name, int auth_id, int owner); > extern void sql_trans_drop_schema(sql_trans *tr, int id, int drop_action); > > -extern sql_table *sql_trans_create_table(sql_trans *tr, sql_schema *s, char *name, char *sql, int tt, bit system, int persistence, int commit_action, int sz, bit *fixed, int *ndims); > +extern sql_table *sql_trans_create_table(sql_trans *tr, sql_schema *s, char *name, char *sql, int tt, bit system, int persistence, int commit_action, int sz, bit fixed, int ndims); > extern sql_table *sql_trans_add_table(sql_trans *tr, sql_table *mt, sql_table *pt); > extern sql_table *sql_trans_del_table(sql_trans *tr, sql_table *mt, sql_table *pt, int drop_action); > > @@ -368,7 +368,7 @@ extern int sql_trans_connect_catalog(sql > extern int sql_trans_disconnect_catalog(sql_trans *tr, char *db_alias); > extern int sql_trans_disconnect_catalog_ALL(sql_trans *tr); > > -extern sql_table *create_sql_table(sql_allocator *sa, char *name, sht type, bit system, int persistence, int commit_action, bit *fixed, int *ndims); > +extern sql_table *create_sql_table(sql_allocator *sa, char *name, sht type, bit system, int persistence, int commit_action, bit fixed, int ndims); > extern sql_column *create_sql_column(sql_allocator *sa, sql_table *t, char *name, sql_subtype *tpe); > extern sql_ukey *create_sql_ukey(sql_allocator *sa, sql_table *t, char *nme, key_type kt); > extern sql_fkey *create_sql_fkey(sql_allocator *sa, sql_table *t, char *nme, key_type kt, sql_key *rkey, int on_delete, int on_update ); > diff --git a/sql/storage/store.c b/sql/storage/store.c > --- a/sql/storage/store.c > +++ b/sql/storage/store.c > @@ -578,7 +578,7 @@ load_table(sql_trans *tr, sql_schema *s, > t->cleared = 0; > v = table_funcs.column_find_value(tr, find_sql_column(tables, "readonly"),rid); > t->readonly = *(bit *)v; _DELETE(v); > - v = table_funcs.column_find_value(tr, find_sql_column(tables, "fixed"),rid); > + v = table_funcs.column_find_value(tr, find_sql_column(tables, "fixed_array"),rid); > t->fixed = *(bit *)v; _DELETE(v); > v = table_funcs.column_find_value(tr, find_sql_column(tables, "nr_dimensions"),rid); > t->ndims = *(int *)v; _DELETE(v); > @@ -1127,7 +1127,7 @@ bootstrap_create_column(sql_trans *tr, s > } > > sql_table * > -create_sql_table(sql_allocator *sa, char *name, sht type, bit system, int persistence, int commit_action, bit *fixed, int *ndims) > +create_sql_table(sql_allocator *sa, char *name, sht type, bit system, int persistence, int commit_action, bit fixed, int ndims) > { > sql_table *t = SA_ZNEW(sa, sql_table); > > @@ -1149,9 +1149,9 @@ create_sql_table(sql_allocator *sa, char > t->pkey = NULL; > t->sz = COLSIZE; > t->cleared = 0; > - /* 'fixed' and 'ndims' are ONLY used for arrays. Pass NULLs to get their defaults. */ > - t->fixed = fixed ? *fixed : 1; /* should be set to 0 if an unbounded dimension is found. */ > - t->ndims = ndims ? *ndims : 0; > + /* 'fixed' and 'ndims' are ONLY used for arrays. For tables, their values arre always 0. */ > + t->fixed = isArray(t) ? fixed : 0; /* should be set to 1 for fixed arrays. */ > + t->ndims = isArray(t) ? ndims : 0; > t->s = NULL; > return t; > } > @@ -1188,7 +1188,7 @@ sql_table * > dup_sql_table(sql_allocator *sa, sql_table *t) > { > node *n; > - sql_table *nt = create_sql_table(sa, t->base.name, t->type, t->system, SQL_DECLARED_TABLE, t->commit_action, &t->fixed, &t->ndims); > + sql_table *nt = create_sql_table(sa, t->base.name, t->type, t->system, SQL_DECLARED_TABLE, t->commit_action, t->fixed, t->ndims); > > for (n = t->columns.set->h; n; n = n->next) > dup_sql_column(sa, nt, n->data); > @@ -1223,7 +1223,7 @@ bootstrap_create_table(sql_trans *tr, sq > int istmp = isTempSchema(s); > int persistence = istmp?SQL_GLOBAL_TEMP:SQL_PERSIST; > sht commit_action = istmp?CA_PRESERVE:CA_COMMIT; > - sql_table *t = create_sql_table(tr->sa, name, tt_table, 1, persistence, commit_action, NULL, NULL /* we never have arrays here */); > + sql_table *t = create_sql_table(tr->sa, name, tt_table, 1, persistence, commit_action, 0, 0 /* we never have arrays here */); > > if (bs_debug) > fprintf(stderr, "#bootstrap_create_table %s\n", name ); > @@ -1411,7 +1411,7 @@ store_init(int debug, store_type store, > bootstrap_create_column(tr, t, "system", "boolean", 1); > bootstrap_create_column(tr, t, "commit_action", "smallint", 16); > bootstrap_create_column(tr, t, "readonly", "boolean", 1); > - bootstrap_create_column(tr, t, "fixed", "boolean", 1); > + bootstrap_create_column(tr, t, "fixed_array", "boolean", 1); > bootstrap_create_column(tr, t, "nr_dimensions", "int", 32); > > t = bootstrap_create_table(tr, s, "_columns"); > @@ -3863,7 +3863,7 @@ sql_trans_del_table(sql_trans *tr, sql_t > } > > sql_table * > -sql_trans_create_table(sql_trans *tr, sql_schema *s, char *name, char *sql, int tt, bit system, int persistence, int commit_action, int sz, bit *fixed, int *ndims) > +sql_trans_create_table(sql_trans *tr, sql_schema *s, char *name, char *sql, int tt, bit system, int persistence, int commit_action, int sz, bit fixed, int ndims) > { > sql_table *t = create_sql_table(tr->sa, name, tt, system, persistence, commit_action, fixed, ndims); > sql_schema *syss = find_sql_schema(tr, isGlobal(t)?"sys":"tmp"); > diff --git a/sql/test/sciql/Tests/01_create_01.sql b/sql/test/sciql/Tests/01_create_01.sql > --- a/sql/test/sciql/Tests/01_create_01.sql > +++ b/sql/test/sciql/Tests/01_create_01.sql > @@ -1,5 +1,16 @@ > -- use the [size] shortcut for integer type dimensions > CREATE ARRAY ary(x TINYINT DIMENSION[4], y BIGINT DIMENSION[-5], v FLOAT DEFAULT 3.7); > SELECT * FROM ary; > + > +CREATE ARRAY ary1(x TINYINT DIMENSION, y BIGINT DIMENSION, v FLOAT DEFAULT 3.7); > +SELECT * FROM ary1; > + > +CREATE ARRAY ary2(x TINYINT DIMENSION[4], y BIGINT DIMENSION, z BIGINT DIMENSION[-5], v FLOAT DEFAULT 3.7); > +SELECT * FROM ary2; > + > +SELECT * FROM _tables WHERE type = 7 OR fixed_array = TRUE; > + > DROP ARRAY ary; > +DROP ARRAY ary1; > +DROP ARRAY ary2; > > diff --git a/sql/test/sciql/Tests/01_create_01.stable.out b/sql/test/sciql/Tests/01_create_01.stable.out > --- a/sql/test/sciql/Tests/01_create_01.stable.out > +++ b/sql/test/sciql/Tests/01_create_01.stable.out > @@ -49,6 +49,26 @@ Ready. > [ 3, -2, 3.7 ] > [ 3, -3, 3.7 ] > [ 3, -4, 3.7 ] > +#CREATE ARRAY ary1(x TINYINT DIMENSION, y BIGINT DIMENSION, v FLOAT DEFAULT 3.7); > +#SELECT * FROM ary1; > +% sys.ary1, sys.ary1, sys.ary1 # table_name > +% x, y, v # name > +% tinyint, bigint, double # type > +% 1, 1, 24 # length > +#CREATE ARRAY ary2(x TINYINT DIMENSION[4], y BIGINT DIMENSION, z BIGINT DIMENSION[-5], v FLOAT DEFAULT 3.7); > +#SELECT * FROM ary2; > +% sys.ary2, sys.ary2, sys.ary2, sys.ary2 # table_name > +% x, y, z, v # name > +% tinyint, bigint, bigint, double # type > +% 1, 1, 1, 24 # length > +#SELECT * FROM _tables WHERE type = 7 OR fixed_array = TRUE; > +% sys._tables, sys._tables, sys._tables, sys._tables, sys._tables, sys._tables, sys._tables, sys._tables, sys._tables, sys._tables # table_name > +% id, name, schema_id, query, type, system, commit_action, readonly, fixed_array, nr_dimensions # name > +% int, varchar, int, varchar, smallint, boolean, smallint, boolean, boolean, int # type > +% 4, 4, 4, 0, 1, 5, 1, 5, 5, 1 # length > +[ 6461, "ary", 2000, NULL, 7, false, 0, false, true, 2 ] > +[ 6466, "ary1", 2000, NULL, 7, false, 0, false, false, 2 ] > +[ 6472, "ary2", 2000, NULL, 7, false, 0, false, false, 3 ] > #DROP ARRAY ary; > > # 13:50:46 > > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list -- | Stefan.Manegold @ CWI.nl | DB Architectures (INS1) | | http://CWI.nl/~manegold/ | Science Park 123 (L321) | | Tel.: +31 (0)20 592-4212 | 1098 XG Amsterdam (NL) |

2 1

[Monetdb-developers] New Apr2012 stable branch created
by Sjoerd Mullender 29 Feb '12

29 Feb '12

I have created a new stable branch for the next feature release. This branch was created in order to stabilize the code before the feature release. From now on *only* bug fixes may go to this new stable branch. I reserve the right to undo any changes that do not comply with this rule. I also reserve the right to admit changes that are not strictly bug fixes. The name for the branch is Apr2012. So in each of your stable checkout directories you can do hg pull hg update -rApr2012 to update to this new branch. -- Sjoerd Mullender

1 0

[Monetdb-developers] Announcement: New Dec2011-SP1 Bugfix release of MonetDB suite
by Fabian Groffen 29 Feb '12

29 Feb '12

The MonetDB team at CWI/MonetDB BV is pleased to announce the Dec2011-SP1 bugfix release of the MonetDB suite of programs. More information about MonetDB can be found on our website at http://www.monetdb.org/. For details on this release, please see the release notes at <http://www.monetdb.org/Downloads/ReleaseNotes>. As usual, the download location is <http://dev.monetdb.org/downloads/>. Dec 2011-SP1 bugfix release Build Environment * Fixed some of the package names for Debian/Ubuntu. Packages for libraries should contain the major number of the library version number. This was not always the case. * On Debian and Ubuntu, install Python modules in dist-packages instead of site-packages. This fixed bug 2997. SQL * Fixed a crash that happened at the end of a database upgrade to the Dec2011 database scheme. The crash happened during cleanup after the database was upgraded, so it was merely inconvenient. * Stripped off implementation-specific parts from error messages before they get presented to the user. Java Module * Fixed bug in DatabaseMetaData.getSchemas() method that caused an SQL error when called with catalog and schema argument. * Resolved a bug where JDBC and Control connections could terminate abruptly with 'Connection closed' messages MonetDB5 Server * Fixed potential crash by dealing better with non-standard types. Merovingian * Fixed a bug in the multiplex-funnel where certain clients would abort on responses for update queries. * Fixed problem where version and mserver properties for monetdbd were not always successfully retrieved. Bug #2982. * Fixed problem where shutdown of monetdbd would lead to shutting down database 'control' which does not exist. Bug #2983. * Fixed issue causing (harmless) 'error reading from control channel' messages. Bug #2984. * Resolved problem where remote start/stop/etc. commands with monetdb would report error 'OK'. Bug #2984. Bug Fixes * 2862: foreign key self references cause violation upon alter table add constraint... * 2933: "TypeException: algebra.join undefined" when evaluating EXISTS (SELECT ...) predicate * 2946: Invalid BAT if left join condition has only columns from right table * 2964: LEFT OUTER JOIN with constants returns errors * 2969: Result precision issue with Decimal data type * 2973: Date coercion functionality tests * 2979: misc merovingian control problems * 2982: monetdbd status and mserver properties have random values * 2983: monetdbd attempts to stop non-existing database 'control' * 2984: monetdb create/release/start/stop returns error "OK" for remote connections * 2995: Test geom/sql/Tests/example.sql crashes since changeset 6399077ff8a4 * 2997: monetdb-python packages installed in wrong dir on Ubuntu 10.04 LTS (lucid) * 3004: Incorrect evaluation of conditions in WHERE part of SQL statement * 3009: Segmentation fault on simple query * 3013: calc.and is not yet defined for dbl * 3014: dayofweek comment is wrong in mtime.mx:700 * 3017: rel_bin.c:611: exp_bin: Assertion `0' failed. with between on multicolumns * 3020: Assertion error in debugging mode * 3034: INNER JOIN with Subquery produces mal errors * 3041: WHERE condition ignored after 2 LEFT JOINs with subqueries

1 0

Re: [Monetdb-developers] MonetDB: default - make sure we reset the point_query flag
by Sjoerd Mullender 23 Feb '12

23 Feb '12

Would this also be appropriate for the Dec2011 branch? On 2012-02-23 14:22, Niels Nes wrote: > Changeset: 656d66d54802 for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=656d66d54802 > Modified Files: > sql/backends/monet5/sql.mx > Branch: default > Log Message: > > make sure we reset the point_query flag > > > diffs (11 lines): > > diff --git a/sql/backends/monet5/sql.mx b/sql/backends/monet5/sql.mx > --- a/sql/backends/monet5/sql.mx > +++ b/sql/backends/monet5/sql.mx > @@ -1694,6 +1694,7 @@ sqlcleanup(mvc *c, int err) > if (err < 0) > c->session->status = err; > c->label = 0; > + c->point_query = 0; > scanner_query_processed(&(c->scanner)); > return err; > } > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list -- Sjoerd Mullender

2 2

Re: [Monetdb-developers] MonetDB: sciql - rel_select.c, rel_arraytiling(): we do not (yet...
by Ying Zhang 23 Feb '12

23 Feb '12

On Thu, Feb 23, 2012 at 11:06:55AM +0100, Stefan Manegold wrote: > Changeset: 869144f7d945 for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=869144f7d945 > Modified Files: > sql/server/rel_select.c > Branch: sciql > Log Message: > > rel_select.c, rel_arraytiling(): we do not (yet?) support tiling on subset of dimensions No, it's not yet supported. > > > diffs (12 lines): > > diff --git a/sql/server/rel_select.c b/sql/server/rel_select.c > --- a/sql/server/rel_select.c > +++ b/sql/server/rel_select.c > @@ -1910,6 +1910,8 @@ rel_arraytiling(mvc *sql, sql_rel **rel, > idx_exps = tile_def->data.lval->h->next->data.lval; > if (dlist_length(idx_exps) > a->ndims) > return sql_error(sql, 02, "SELECT: #dimensions (%d) in array tiling larger than #dimensions (%d) in the array", dlist_length(idx_exps), a->ndims); > + if (dlist_length(idx_exps) < a->ndims) > + return sql_error(sql, 02, "SELECT: #dimensions (%d) in array tiling fewer than #dimensions (%d) in the array --- not supported (yet?)", dlist_length(idx_exps), a->ndims); > if (dlist_length(idx_exps) > ARRAY_TILING_MAX_DIMS) > return sql_error(sql, 02, "SELECT: TODO: array tiling over >%d dimensions", ARRAY_TILING_MAX_DIMS); > for (n = idx_exps->h; n; n = n->next) { > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list

1 0

Re: [Monetdb-developers] MonetDB: default - test opt_sql_append: trying to upgrade to new...
by Martin Kersten 18 Feb '12

18 Feb '12

The new optimizer infrastructure returns the name of the pipe, not its content. The definitions can be obtained from the system view: select * from optimizers(); can be used to get the expanded form. On 2/18/12 6:11 PM, Stefan Manegold wrote: > Changeset: 62a52aaf4241 for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=62a52aaf4241 > Modified Files: > monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.sql > monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.stable.out > Branch: default > Log Message: > > test opt_sql_append: trying to upgrade to new optimizer framework > > However, setting SQL variable "optimizer" to a MAL snippert > rather than an optimizer pipeline name does not seem to work (yet?) ... > > > diffs (39 lines): > > diff --git a/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.sql b/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.sql > --- a/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.sql > +++ b/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.sql > @@ -1,7 +1,9 @@ > create table ttt (a int, b int, c int); > select optimizer; > explain copy into ttt from '/tmp/xyz'; > -set optimizer = substring(optimizer,0,length(optimizer)-length('garbageCollector')) || 'sql_append,garbageCollector'; > +declare opt_pipe_name string; set opt_pipe_name = ( select optimizer ); > +declare opt_pipe_def string; set opt_pipe_def = ( select def from optimizers() where name = opt_pipe_name ); > +set optimizer = substring(opt_pipe_def,0,length(opt_pipe_def)-length('optimizer.garbageCollector();')) || 'optimizer.sql_append();optimizer.garbageCollector();'; > select optimizer; > explain copy into ttt from '/tmp/xyz'; > drop table ttt; > diff --git a/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.stable.out b/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.stable.out > --- a/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.stable.out > +++ b/monetdb5/extras/mal_optimizer_template/Tests/opt_sql_append.stable.out > @@ -49,8 +49,8 @@ Ready. > % . # table_name > % single_value # name > % varchar # type > -% 188 # length > -[ "inline,remap,evaluate,costModel,coercions,emptySet,aliases,mitosis,mergetable,deadcode,commonTerms,joinPath,reorder,deadcode,reduce,dataflow,history,multiplex,accumulators,garbageCollector" ] > +% 12 # length > +[ "default_pipe" ] > #explain copy into ttt from '/tmp/xyz'; > % .explain # table_name > % mal # name > @@ -69,8 +69,8 @@ end s2_1; > % . # table_name > % single_value # name > % varchar # type > -% 199 # length > -[ "inline,remap,evaluate,costModel,coercions,emptySet,aliases,mitosis,mergetable,deadcode,commonTerms,joinPath,reorder,deadcode,reduce,dataflow,history,multiplex,accumulators,sql_append,garbageCollector" ] > +% 452 # length > +[ "optimizer.inline();optimizer.remap();optimizer.evaluate();optimizer.costModel();optimizer.coercions();optimizer.emptySet();optimizer.aliases();optimizer.mitosis();optimizer.mergetable();optimizer.deadcode();optimizer.commonTerms();optimizer.joinPath();optimizer.reorder();optimizer.deadcode();optimizer.reduce();optimizer.dataflow();optimizer.history();optimizer.multiplex();optimizer.accumulators();optimizer.sql_append();optimizer.garbageCollector();" ] > #explain copy into ttt from '/tmp/xyz'; > % .explain # table_name > % mal # name > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list

2 1

[Monetdb-developers] How to embed MonetDB
by Florin Ciodaru 17 Feb '12

17 Feb '12

Hi all, First I want to congratulate all of you for this work. Now, we are trying to build a "real-time" like application that on one side periodically receives sets of matrices and on the other side receives query to apply on this matrices - Each set of matrices can have thousands of elements o each of them belongs to a certain class, hence groups of them will need to be inserted in the same monetdb table o each matrix has ~20 columns and the number of rows can grow to 128k - The queries can be o One-time o or , continuous (to be applied on each new set of matrices) Looking for stream processing engine, we reached DataCell and MonetDB. We downloaded the Dec2011 source code from Mercurial depot. Unfortunately, we could not yet figure out how to bring DataCell up and running, although we successfully built it. Maybe you can gives us more pointers than what already exists on the site. In parallel we are trying to experiment with MonetDB functionality as a library to be embedded in our own host (e.g. windows application). The basic functions we want from this library are - Fast low level API's to create tables and populate them with values - High level API's to execute SQL queries For the insertions we figure out the API's in sql_storage.h are close to what we want. However we could not yet find API's that allow us to execute SQL queries (we did find SQLstatementIntern but cannot yet figure out how to retrieve the results of query execution). Your help will be really appreciated, Florin

1 0

Re: [Monetdb-developers] MonetDB: gdk-calc - gdk_calc.c, mod_typeswitchloop(): initialize...
by Stefan Manegold 16 Feb '12

16 Feb '12

Standard gcc on Fedora 16; MonetDB configured with --disable-debug --enable-optimize --disable-assert -- | Stefan.Manegold @ CWI.nl | DB Architectures (INS1) | | http://CWI.nl/~manegold/ | Science Park 123 (L321) | | Tel.: +31 (0)20 592-4212 | 1098 XG Amsterdam (NL) | ----- Reply message ----- From: "Sjoerd Mullender" <sjoerd(a)acm.org> To: <monetdb-developers(a)lists.sourceforge.net> Subject: [Monetdb-developers] MonetDB: gdk-calc - gdk_calc.c, mod_typeswitchloop(): initialize... Date: Thu, Feb 16, 2012 09:18 On 2012-02-15 20:12, Stefan Manegold wrote: > Changeset: fc0d3fad41c2 for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=fc0d3fad41c2 > Modified Files: > gdk/gdk_calc.c > Branch: gdk-calc > Log Message: > > gdk_calc.c, mod_typeswitchloop(): initialize "nils" (hopefully correctly) Which sucky compiler was this? There is no code path where nils was not initialized. (This also means that the value you choose here doesn't matter.) > > diffs (12 lines): > > diff --git a/gdk/gdk_calc.c b/gdk/gdk_calc.c > --- a/gdk/gdk_calc.c > +++ b/gdk/gdk_calc.c > @@ -6157,7 +6157,7 @@ mod_typeswitchloop(const void *lft, int > void *dst, int tp, BUN cnt, > int abort_on_error, const char *func) > { > - BUN nils; > + BUN nils = BUN_NONE; > > switch (ATOMstorage(tp1)) { > case TYPE_bte: > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list -- Sjoerd Mullender

1 0

Re: [Monetdb-developers] MonetDB: gdk-calc - gdk_calc.c, mod_typeswitchloop(): initialize...
by Sjoerd Mullender 16 Feb '12

16 Feb '12

On 2012-02-15 20:12, Stefan Manegold wrote: > Changeset: fc0d3fad41c2 for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=fc0d3fad41c2 > Modified Files: > gdk/gdk_calc.c > Branch: gdk-calc > Log Message: > > gdk_calc.c, mod_typeswitchloop(): initialize "nils" (hopefully correctly) Which sucky compiler was this? There is no code path where nils was not initialized. (This also means that the value you choose here doesn't matter.) > > diffs (12 lines): > > diff --git a/gdk/gdk_calc.c b/gdk/gdk_calc.c > --- a/gdk/gdk_calc.c > +++ b/gdk/gdk_calc.c > @@ -6157,7 +6157,7 @@ mod_typeswitchloop(const void *lft, int > void *dst, int tp, BUN cnt, > int abort_on_error, const char *func) > { > - BUN nils; > + BUN nils = BUN_NONE; > > switch (ATOMstorage(tp1)) { > case TYPE_bte: > _______________________________________________ > Checkin-list mailing list > Checkin-list(a)monetdb.org > http://mail.monetdb.org/mailman/listinfo/checkin-list -- Sjoerd Mullender

1 1