- developers-list - monetdb.org

Re: [Monetdb-developers] [Monetdb-checkins] buildtools/conf MonetDB.m4, May2009, 1.118, 1.118.2.1
by Jan Rittinger 19 May '09

19 May '09

That's no solution in my eyes... Now I get the following configure output for the clients module... checking for OpenSSL >= 0x0090800f... configure: error: not sufficient > ... and cannot build the clients code anymore. Jan On May 18, 2009, at 20:40, Fabian wrote: > Update of /cvsroot/monetdb/buildtools/conf > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv29422 > > Modified Files: > Tag: May2009 > MonetDB.m4 > Log Message: > check for >openssl-0.9.8, sha-2 is only implemented there, thanks > Jan Rittinger > > U MonetDB.m4 > Index: MonetDB.m4 > =================================================================== > RCS file: /cvsroot/monetdb/buildtools/conf/MonetDB.m4,v > retrieving revision 1.118 > retrieving revision 1.118.2.1 > diff -u -d -r1.118 -r1.118.2.1 > --- MonetDB.m4 6 May 2009 16:08:00 -0000 1.118 > +++ MonetDB.m4 18 May 2009 18:39:58 -0000 1.118.2.1 > @@ -2402,6 +2402,19 @@ > fi > if test "x$have_openssl" != xno; then > AC_DEFINE(HAVE_OPENSSL, 1, [Define if you have the OpenSSL library]) > + dnl SHA-2 is implemented starting from version 0.9.8 > + req_openssl_ver=0x0090800f > + AC_MSG_CHECKING([for OpenSSL >= $req_openssl_ver]) > + AC_TRY_COMPILE([#include <openssl/opensslv.h>],[ > +#if !defined(OPENSSL_VERSION_NUMBER) > +#error "Hmmm no OpenSSL version?" > +#endif > +#if (OPENSSL_VERSION_NUMBER < ${req_openssl_ver}L) > +#error "Need more recent version than " OPENSSL_VERSION_TEXT > +#endif], > + [AC_MSG_RESULT(OK)], > + [AC_MSG_ERROR([not sufficient])] > + ) > else > OPENSSL_LIBS="" > OPENSSL_INCS="" > > > ------------------------------------------------------------------------------ > Crystal Reports - New Free Runtime and 30 Day Trial > Check out the new simplified licensing option that enables > unlimited royalty-free distribution of the report engine > for externally facing server and web deployment. > http://p.sf.net/sfu/businessobjects > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins -- Jan Rittinger Lehrstuhl Datenbanken und Informationssysteme Wilhelm-Schickard-Institut für Informatik Eberhard-Karls-Universität Tübingen http://www-db.informatik.uni-tuebingen.de/team/rittinger

4 7

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal mkey.mx, May2009, 1.15, 1.15.2.1
by Stefan Manegold 19 May '09

19 May '09

Martin, maybe the compiler reminded us that you originally intended the following, i.e., propagation the actual error message of CMDbulk_rotate_xor_hash() upwards instead of just saying OPERATION_FAILED: ======== $ cvs diff MonetDB5/src/modules/mal/mkey.mx Index: MonetDB5/src/modules/mal/mkey.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mkey.mx,v retrieving revision 1.15.2.1 diff -u -r1.15.2.1 mkey.mx --- MonetDB5/src/modules/mal/mkey.mx 19 May 2009 05:52:49 -0000 1.15.2.1 +++ MonetDB5/src/modules/mal/mkey.mx 19 May 2009 07:39:01 -0000 @@ -584,6 +584,7 @@ str MKEYbulk_rotate_xor_hash(int *ret, int *hid, int *nbits, int *bid){ BAT *hn, *b, *bn=0; + str msg= MAL_SUCCEED; if ((hn = BATdescriptor(*hid)) == NULL) { throw(MAL, "mkey.bulk_rotate_xor_hash", RUNTIME_OBJECT_MISSING); @@ -593,15 +594,15 @@ throw(MAL, "mkey.bulk_rotate_xor_hash", RUNTIME_OBJECT_MISSING); } - if( CMDbulk_rotate_xor_hash(&bn,hn,nbits,b) != MAL_SUCCEED){ + if( (msg= CMDbulk_rotate_xor_hash(&bn,hn,nbits,b)) != MAL_SUCCEED){ BBPreleaseref(hn->batCacheid); BBPreleaseref(b->batCacheid); - throw(MAL, "mkey.bulk_rotate_xor_hash", OPERATION_FAILED); + throw(MAL, "mkey.bulk_rotate_xor_hash", msg); } BBPreleaseref(hn->batCacheid); BBPreleaseref(b->batCacheid); *ret= bn->batCacheid; BBPkeepref(bn->batCacheid); - return MAL_SUCCEED; + return msg; } @} ======== ? Stefan On Tue, May 19, 2009 at 05:52:51AM +0000, Martin Kersten wrote: > Update of /cvsroot/monetdb/MonetDB5/src/modules/mal > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv30928 > > Modified Files: > Tag: May2009 > mkey.mx > Log Message: > Silence compiler > > > U mkey.mx > Index: mkey.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mkey.mx,v > retrieving revision 1.15 > retrieving revision 1.15.2.1 > diff -u -d -r1.15 -r1.15.2.1 > --- mkey.mx 17 May 2009 21:14:54 -0000 1.15 > +++ mkey.mx 19 May 2009 05:52:49 -0000 1.15.2.1 > @@ -584,7 +584,6 @@ > str > MKEYbulk_rotate_xor_hash(int *ret, int *hid, int *nbits, int *bid){ > BAT *hn, *b, *bn=0; > - str msg= MAL_SUCCEED; > > if ((hn = BATdescriptor(*hid)) == NULL) { > throw(MAL, "mkey.bulk_rotate_xor_hash", RUNTIME_OBJECT_MISSING); > @@ -594,7 +593,7 @@ > throw(MAL, "mkey.bulk_rotate_xor_hash", RUNTIME_OBJECT_MISSING); > } > > - if( (msg= CMDbulk_rotate_xor_hash(&bn,hn,nbits,b)) != MAL_SUCCEED){ > + if( CMDbulk_rotate_xor_hash(&bn,hn,nbits,b) != MAL_SUCCEED){ > BBPreleaseref(hn->batCacheid); > BBPreleaseref(b->batCacheid); > throw(MAL, "mkey.bulk_rotate_xor_hash", OPERATION_FAILED); > > > ------------------------------------------------------------------------------ > Crystal Reports - New Free Runtime and 30 Day Trial > Check out the new simplified licensing option that enables > unlimited royalty-free distribution of the report engine > for externally facing server and web deployment. > http://p.sf.net/sfu/businessobjects > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins > > > -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

1 0

[Monetdb-developers] New stable branch created
by Sjoerd Mullender 18 May '09

18 May '09

I have created new stable branches for the upcoming release. From now on *all* bug fixes and *only* bug fixes *must* go to this new stable branch. I reserve the right to undo any changes that do not comply with this rule. All packages use the same name for the branch: May2009. So in each of your stable checkout directories you can do cvs update -rMay2009 to update to the new branch. I have created branches for the following packages: MonetDB MonetDB4 MonetDB5 TestTools buildtools clients geom java pathfinder sql template testing. Note that datacell is missing from this list. It is not yet released and will not be released in this round. -- Sjoerd Mullender

2 1

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/optimizer opt_datacyclotron.mx, , 1.6, 1.7 opt_derivepath.mx, , 1.4, 1.5 opt_joinpath.mx, , 1.46, 1.47 opt_macro.mx, , 1.46, 1.47 opt_prejoin.mx, , 1.7, 1.8 opt_remap.mx, , 1.47, 1.48 opt_statistics.mx, , 1.18, 1.19 opt_support.mx, , 1.100, 1.101 opt_trace.mx, , 1.12, 1.13 optimizer.mx, , 1.83, 1.84 optimizerWrapper.mx, , 1.29, 1.30
by Sjoerd Mullender 17 May '09

17 May '09

Where are the definitions of ILLARG_CONSTANTS, PROGRAM_NYI and OPTIMIZER_CYCLE? On 2009-05-16 23:02, Martin Kersten wrote: > Update of /cvsroot/monetdb/MonetDB5/src/optimizer > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv2012 > > Modified Files: > opt_datacyclotron.mx opt_derivepath.mx opt_joinpath.mx > opt_macro.mx opt_prejoin.mx opt_remap.mx opt_statistics.mx > opt_support.mx opt_trace.mx optimizer.mx optimizerWrapper.mx > Log Message: > The next batch of straightforward error clean up and condensation. > > > U opt_derivepath.mx > Index: opt_derivepath.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_derivepath.mx,v > retrieving revision 1.4 > retrieving revision 1.5 > diff -u -d -r1.4 -r1.5 > --- opt_derivepath.mx 3 Apr 2009 16:48:41 -0000 1.4 > +++ opt_derivepath.mx 16 May 2009 21:02:04 -0000 1.5 > @@ -141,6 +141,6 @@ > (void) mb; > (void) stk; > (void) pci; > - throw(MAL,"group.derivePath","nyi"); > + throw(MAL,"group.derivePath",PROGRAM_NYI); > } > @} > > U opt_support.mx > Index: opt_support.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_support.mx,v > retrieving revision 1.100 > retrieving revision 1.101 > diff -u -d -r1.100 -r1.101 > --- opt_support.mx 6 May 2009 16:54:13 -0000 1.100 > +++ opt_support.mx 16 May 2009 21:02:04 -0000 1.101 > @@ -628,7 +628,7 @@ > sprintf(buf,"%-20s actions=%2d time=" LLFMT " usec",name,actions,usec); > newComment(mb,buf); > if (mb->errors) > - throw(MAL,name,"failed\n"); > + throw(MAL, name, PROGRAM_GENERAL); > } > /* code to collect all last versions to study code coverage in SQL > {stream *fd; > @@ -677,7 +677,7 @@ > } > } while (qot && cnt++ < mb->stop); > if (cnt >= mb->stop) > - throw(MAL, "optimizer.MALoptimizer", "too many optimization cycles\n"); > + throw(MAL, "optimizer.MALoptimizer", OPTIMIZER_CYCLE); > return 0; > } > > > U optimizerWrapper.mx > Index: optimizerWrapper.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/optimizerWrapper.mx,v > retrieving revision 1.29 > retrieving revision 1.30 > diff -u -d -r1.29 -r1.30 > --- optimizerWrapper.mx 16 May 2009 08:54:40 -0000 1.29 > +++ optimizerWrapper.mx 16 May 2009 21:02:04 -0000 1.30 > @@ -57,9 +57,7 @@ > !isVarConstant(mb,getArg(p,1)) || > !isVarConstant(mb,getArg(p,2)) > ) { > - char buf[1024]; > - snprintf(buf,1024, "Optimizer requires constant string arguments\n"); > - throw(MAL, "optimizer.@1",buf); > + throw(MAL, "optimizer.@1", ILLARG_CONSTANTS); > } > if( stk != 0){ > modnme= *(str*)getArgReference(stk,p,1); > @@ -72,8 +70,8 @@ > > if( s == NULL) { > char buf[1024]; > - snprintf(buf,1024, "Could not find %s.%s\n",modnme,fcnnme); > - throw(MAL, "optimizer.@1",buf); > + snprintf(buf,1024, "%s.%s",modnme,fcnnme); > + throw(MAL, "optimizer.@1", RUNTIME_OBJECT_UNDEFINED, buf); > } > #ifdef _DEBUG_OPTIMIZER_ > stream_printf(cntxt->fdout,"@1 %s %s\n",modnme,fcnnme); > > U opt_remap.mx > Index: opt_remap.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_remap.mx,v > retrieving revision 1.47 > retrieving revision 1.48 > diff -u -d -r1.47 -r1.48 > --- opt_remap.mx 16 May 2009 08:54:40 -0000 1.47 > +++ opt_remap.mx 16 May 2009 21:02:04 -0000 1.48 > @@ -529,7 +529,7 @@ > #else > (void) cntxt; > #endif > - throw(MAL,"opt.remap","no implementation present"); > + throw(MAL, "opt.remap", PROGRAM_NYI); > } > @include optimizerWrapper.mx > @h > > U opt_prejoin.mx > Index: opt_prejoin.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_prejoin.mx,v > retrieving revision 1.7 > retrieving revision 1.8 > diff -u -d -r1.7 -r1.8 > --- opt_prejoin.mx 12 Apr 2009 20:22:29 -0000 1.7 > +++ opt_prejoin.mx 16 May 2009 21:02:04 -0000 1.8 > @@ -62,11 +62,11 @@ > > *rl = *rr = 0; > if( (bl= BATdescriptor(*l)) == NULL ){ > - throw(MAL, "algebra.prejoin", "Cannot access descriptor"); > + throw(MAL, "algebra.prejoin", INTERNAL_BAT_ACCESS); > } > if( (br= BATdescriptor(*r)) == NULL ){ > BBPreleaseref(bl->batCacheid); > - throw(MAL, "algebra.prejoin", "Cannot access descriptor"); > + throw(MAL, "algebra.prejoin", INTERNAL_BAT_ACCESS); > } > lpages= (BUN) ((bl->H->heap.size + bl->T->heap.size)/MT_pagesize()); > rpages= (BUN) ((br->H->heap.size + br->T->heap.size)/MT_pagesize()); > > U opt_macro.mx > Index: opt_macro.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_macro.mx,v > retrieving revision 1.46 > retrieving revision 1.47 > diff -u -d -r1.46 -r1.47 > --- opt_macro.mx 16 May 2009 08:54:40 -0000 1.46 > +++ opt_macro.mx 16 May 2009 21:02:04 -0000 1.47 > @@ -388,7 +388,7 @@ > retseen = p->token == RETURNsymbol || p->token == YIELDsymbol || p->barrier == RETURNsymbol || p->barrier == YIELDsymbol; > } > if (retseen && i != mb->stop - 1) > - throw(MAL, "optimizer.MACROvalidate", "RETURN statement is not the last one"); > + throw(MAL, "optimizer.MACROvalidate", MACRO_SYNTAX_ERROR); > return MAL_SUCCEED; > } > > @@ -417,13 +417,13 @@ > stream_printf(cntxt->fdout,"Hit, replace macro call %s\n", t->name); > #endif > if (i == last) > - throw(MAL, "optimizer.MACROoptimizer", "duplicate macro expansion"); > + throw(MAL, "optimizer.MACROoptimizer", MACRO_DUPLICATE); > > last = i; > i = inlineMALblock(mb, i, t->def); > cnt++; > if (cnt > MAXEXPANSION) > - throw(MAL, "optimizer.MACROoptimizer", "too many macro expansions"); > + throw(MAL, "optimizer.MACROoptimizer", MACRO_TOO_DEEP); > } > } > return msg; > > U opt_trace.mx > Index: opt_trace.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_trace.mx,v > retrieving revision 1.12 > retrieving revision 1.13 > diff -u -d -r1.12 -r1.13 > --- opt_trace.mx 7 Jan 2009 14:15:13 -0000 1.12 > +++ opt_trace.mx 16 May 2009 21:02:04 -0000 1.13 > @@ -90,7 +90,7 @@ > > trace= fopen(defaultLog,"a"); > if( trace == 0) > - throw(MAL,"mdb.collect","Could not create trace file"); > + throw(MAL, "mdb.collect", RUNTIME_FILE_NOT_FOUND); > fprintf(trace,"#-------- \n"); > fflush(trace); > } > > U optimizer.mx > Index: optimizer.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/optimizer.mx,v > retrieving revision 1.83 > retrieving revision 1.84 > diff -u -d -r1.83 -r1.84 > --- optimizer.mx 16 May 2009 08:54:40 -0000 1.83 > +++ optimizer.mx 16 May 2009 21:02:04 -0000 1.84 > @@ -151,7 +151,7 @@ > } > s = findSymbol(cntxt->nspace, putName(modnme,strlen(modnme)), fcnnme); > if (s == NULL) > - throw(MAL, "optimizer.optimize", "operation not found\n"); > + throw(MAL, "optimizer.optimize", SEMANTIC_OPERATION_MISSING); > removeInstruction(mb, pci); > return optimizeMALBlock(cntxt, s->def); > } > @@ -180,8 +180,8 @@ > > if (s == NULL) { > char buf[1024]; > - snprintf(buf,1024, "Could not find %s.%s\n", modnme, fcnnme); > - throw(MAL, "optimizer.showFlowGraph", buf); > + snprintf(buf,1024, "%s.%s", modnme, fcnnme); > + throw(MAL, "optimizer.showFlowGraph", RUNTIME_OBJECT_UNDEFINED, buf); > } > showFlowGraph(s->def, stk, fname); > return MAL_SUCCEED; > @@ -209,8 +209,8 @@ > > if (s == NULL) { > char buf[1024]; > - snprintf(buf,1024, "Could not find %s.%s\n", modnme, fcnnme); > - throw(MAL, "optimizer.showPlan", buf); > + snprintf(buf,1024, "%s.%s", modnme, fcnnme); > + throw(MAL, "optimizer.showPlan", RUNTIME_OBJECT_UNDEFINED, buf); > } > mb= s->def; > } > @@ -271,7 +271,7 @@ > #endif > if( s== 0) > return throwException(MALEXCEPTION,"optimizer.@1optimizer", > - "module '%s' not found\n",fcn); > + RUNTIME_OBJECT_UNDEFINED, fcn); > if( s->subscope){ > j = getSubScope(fcn); > for(t= s->subscope[j];t!=NULL;t=t->peer) > > U opt_joinpath.mx > Index: opt_joinpath.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_joinpath.mx,v > retrieving revision 1.46 > retrieving revision 1.47 > diff -u -d -r1.46 -r1.47 > --- opt_joinpath.mx 29 Apr 2009 07:41:50 -0000 1.46 > +++ opt_joinpath.mx 16 May 2009 21:02:04 -0000 1.47 > @@ -484,7 +484,7 @@ > for( --top; top>=0; top--) > BBPreleaseref(joins[top]->batCacheid); > GDKfree(joins); > - throw(MAL, "algebra.joinPath", "Cannot access descriptor"); > + throw(MAL, "algebra.joinPath", INTERNAL_BAT_ACCESS); > } > joins[top++] = b; > } > > U opt_datacyclotron.mx > Index: opt_datacyclotron.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_datacyclotron.mx,v > retrieving revision 1.6 > retrieving revision 1.7 > diff -u -d -r1.6 -r1.7 > --- opt_datacyclotron.mx 5 May 2009 14:20:06 -0000 1.6 > +++ opt_datacyclotron.mx 16 May 2009 21:02:04 -0000 1.7 > @@ -114,14 +114,14 @@ > (void) tab; > (void) col; > (void) kind; > - throw(MAL,"datacyclotron.request","nyi"); > + throw(MAL,"datacyclotron.request",PROGRAM_NYI); > } > > str > DCpin(int *ret, int *bid){ > (void) ret; > (void) bid; > - throw(MAL,"datacyclotron.pin","nyi"); > + throw(MAL,"datacyclotron.pin",PROGRAM_NYI); > } > > > @@ -129,6 +129,6 @@ > DCunpin(int *ret, int *bid){ > (void) ret; > (void) bid; > - throw(MAL,"datacyclotron.unpin","nyi"); > + throw(MAL,"datacyclotron.unpin",PROGRAM_NYI); > } > > > U opt_statistics.mx > Index: opt_statistics.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_statistics.mx,v > retrieving revision 1.18 > retrieving revision 1.19 > diff -u -d -r1.18 -r1.19 > --- opt_statistics.mx 7 Jan 2009 14:15:13 -0000 1.18 > +++ opt_statistics.mx 16 May 2009 21:02:04 -0000 1.19 > @@ -192,10 +192,8 @@ > int idx; > QOTstatisticsInit(); > idx= QOTindex(*nme); > - if( idx < 0) > - throw(MAL,"optimizer.getStatistics","Illegal property"); > - if( qotStat[idx] == 0) > - throw(MAL,"optimizer.getStatistics","Statistics table not valid"); > + if( idx < 0 || qotStat[idx] == 0 ) > + throw(ILLARG,"optimizer.getStatistics",RUNTIME_OBJECT_MISSING); > BBPincref(*ret= qotStat[idx]->batCacheid, TRUE); > return MAL_SUCCEED; > } > > > ------------------------------------------------------------------------------ > Crystal Reports - New Free Runtime and 30 Day Trial > Check out the new simplified licensing option that enables > unlimited royalty-free distribution of the report engine > for externally facing server and web deployment. > http://p.sf.net/sfu/businessobjects > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins -- Sjoerd Mullender

1 0

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/mal mal_authorize.mx, , 1.73, 1.74 mal_client.mx, , 1.195, 1.196 mal_debugger.mx, , 1.263, 1.264 mal_exception.mx, , 1.54, 1.55 mal_factory.mx, , 1.87, 1.88 mal_interpreter.mx, , 1.302, 1.303 mal_linker.mx, , 1.110, 1.111 mal_profiler.mx, , 1.128, 1.129 mal_sabaoth.mx, , 1.53, 1.54 mal_scenario.mx, , 1.123, 1.124 mal_session.mx, , 1.195, 1.196
by Martin Kersten 16 May '09

16 May '09

Fabian Groffen wrote: > On 16-05-2009 18:26:25 +0000, Martin Kersten wrote: >> Update of /cvsroot/monetdb/MonetDB5/src/mal >> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv27406 >> >> Modified Files: >> mal_authorize.mx mal_client.mx mal_debugger.mx >> mal_exception.mx mal_factory.mx mal_interpreter.mx >> mal_linker.mx mal_profiler.mx mal_sabaoth.mx mal_scenario.mx >> mal_session.mx >> Log Message: >> Collecting the exception/errors messages in one place leads to easier detection >> of duplicates and can be used later for internationalization efforts > > Why not do it the gettext way, in that case? Yes, i am fully aware of gettext. It is a multi-step process, first condense..... and gettext() performs translations based on strings e.g. the ones now identified. > >> U mal_linker.mx >> Index: mal_linker.mx >> =================================================================== >> RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_linker.mx,v >> retrieving revision 1.110 >> retrieving revision 1.111 >> diff -u -d -r1.110 -r1.111 >> --- mal_linker.mx 7 Jan 2009 14:15:12 -0000 1.110 >> +++ mal_linker.mx 16 May 2009 18:26:23 -0000 1.111 >> @@ -251,7 +251,7 @@ >> >> if (fullname == NULL) { >> if( flag) >> - throw(LOADER, "loadLibrary", "%s: file not found", filename); >> + throw(LOADER, "loadLibrary", RUNTIME_FILE_NOT_FOUND, filename); > > I think this is prone to errors and mistakes, since you no longer know > how many %X are in the constant, of what type, etc. true... see how many are really needed after condensation > > I do think consistency is good, I doubt about translations, but I think > this approach is a good solution. Please look into gettext, see > applications like mutt for an example how to use it. > > ------------------------------------------------------------------------------ > Crystal Reports - New Free Runtime and 30 Day Trial > Check out the new simplified licensing option that enables > unlimited royalty-free distribution of the report engine > for externally facing server and web deployment. > http://p.sf.net/sfu/businessobjects > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

2 5

[Monetdb-developers] new release branch
by Sjoerd Mullender 15 May '09

15 May '09

I am planning to create a new "stable" branch today or tomorrow for the upcoming May feature release. -- Sjoerd Mullender

1 0

Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/modules/pftijah pftijah.mx, , 1.228, 1.229
by Sjoerd Mullender 14 May '09

14 May '09

It's slightly more complex than this. At the MIL level you're right, you need to use wrd instead of int for bat counts. On the C level however, you should use the BUN type and also check for overflow when converting a wrd parameter to BUN (if sizeof(wrd) > sizeof(BUN) which is entirely possible). And then the real bug in your checkin: you use OIDFMT to print some value of type wrd. This is incorrect. You must use LLFMT together with a cast to lng for that. (Better would be to use BUN and BUNFMT.) I guess we could introduce a WRDFMT for printing wrd values, but we don't have that currently. On 2009-05-14 19:42, Roberto Cornacchia wrote: > Update of /cvsroot/monetdb/pathfinder/modules/pftijah > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv25786 > > Modified Files: > pftijah.mx > Log Message: > This commit is a temporary fix for the incorrect definition of count() mil proc: > count(BAT b) : int > > This should be instead: > > count(BAT b) : wrd > > !! Note that the problem should be solved properly in algebra.mx, changing the definition of count() and fixing all related code. > > In addition, this commit fixes some more incorrect usage of the int type, for example all bat offsets should be wrd and not int. > > > > U pftijah.mx > Index: pftijah.mx > =================================================================== > RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/pftijah.mx,v > retrieving revision 1.228 > retrieving revision 1.229 > diff -u -d -r1.228 -r1.229 > --- pftijah.mx 13 May 2009 07:35:03 -0000 1.228 > +++ pftijah.mx 14 May 2009 17:42:09 -0000 1.229 > @@ -117,7 +117,7 @@ > : BAT[oid,oid] = CMDpf2tijah_node; > "Translate Pathfinder node sequence to tijah node sequence" > > -.COMMAND offsetindex( BAT[void,oid] offset_tid, int res_size) > +.COMMAND offsetindex( BAT[void,oid] offset_tid, wrd res_size) > : BAT[void,oid] = CMDoffsetindex; > > "PARAMETERS: > @@ -127,7 +127,7 @@ > creates an offset index. > [...972 lines suppressed...] > BATiter tidprei, tidsizei, oldindexi, oldprei, oldsizei; > oid *s_newindex, *lst_newindex, *s_newpre, *lst_newpre; > @@ -5238,7 +5249,7 @@ > newsize = BATnew(TYPE_void, TYPE_int, ressize); > if (newsize == NULL) > { > - GDKerror("%s: could not allocate a result BAT[void,int] of size %d.\n", name, ressize); > + GDKerror("%s: could not allocate a result BAT[void,int] of size "OIDFMT".\n", name, ressize); > BATfree(res); > BATfree(newpre); > return(GDK_FAIL); > @@ -5248,7 +5259,7 @@ > newindex = BATnew(TYPE_void, TYPE_oid, ressize); > if (newindex == NULL) > { > - GDKerror("%s: could not allocate a result BAT[void,oid] of size %d.\n", name, ressize); > + GDKerror("%s: could not allocate a result BAT[void,oid] of size "OIDFMT".\n", name, ressize); > BATfree(res); > BATfree(newpre); > BATfree(newsize); > > > ------------------------------------------------------------------------------ > The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your > production scanning environment may not be a perfect world - but thanks to > Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 > Series Scanner you'll get full speed at 300 dpi even with all image > processing features enabled. http://p.sf.net/sfu/kodak-com > _______________________________________________ > Monetdb-pf-checkins mailing list > Monetdb-pf-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins -- Sjoerd Mullender

2 1

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal mal_mapi.mx, , 1.27, 1.28
by Stefan Manegold 12 May '09

12 May '09

On Sun, May 10, 2009 at 06:59:05PM +0000, Fabian wrote: > Update of /cvsroot/monetdb/MonetDB5/src/modules/mal > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv28294/src/modules/mal > > Modified Files: > mal_mapi.mx > Log Message: > refine protocol v9 to use the hash the server told the client > > The hash algorithm can be chosen at configure time, defaulting to > SHA512, mainly because conversion between hashes is impossible, and this > way we are forward compatible for a long time, by allowing the DBA to > keep on using an older/weaker hash algorithm in favour of dumping and > restoring the database. > > !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! > !!! TRUNK USERS, BEWARE: !!! > !!! !!! > !!! If you want to keep on using an existing trunk database, you !!! > !!! have to configure MonetDB5 with --with-password-backend=SHA1 !!! > !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! > > > U mal_mapi.mx > Index: mal_mapi.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mal_mapi.mx,v > retrieving revision 1.27 > retrieving revision 1.28 > diff -u -d -r1.27 -r1.28 > --- mal_mapi.mx 6 May 2009 19:59:51 -0000 1.27 > +++ mal_mapi.mx 10 May 2009 18:59:03 -0000 1.28 > @@ -440,16 +440,17 @@ > /* generate the challenge string */ > challenge = alloca(sizeof(char) * (12 + 1)); > generateChallenge(challenge, 8, 12); > - if (AUTHgetHashAlgorithms(&algos) != MAL_SUCCEED) assert (0); > - /* note that we claim to speak proto 9 here for SHA-1 passwords */ > - stream_printf(fdout, "%s:mserver:9:%s:%s", > + assert(AUTHgetHashAlgorithms(&algos) == MAL_SUCCEED); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This call will only be executed (and hence variable algos initialized, in case assertions are enabled. Maybe, this is not was you intended... (Assertions are (by default) disabled in released binary distributions and source tarballs.) Stefan > + /* note that we claim to speak proto 9 here for hashed passwords */ > + stream_printf(fdout, "%s:mserver:9:%s:%s:%s:", > challenge, > algos, > #ifdef WORDS_BIGENDIAN > - "BIG" > + "BIG", > #else > - "LIT" > + "LIT", > #endif > + MONETDB5_PASSWDHASH > ); > GDKfree(algos); > stream_flush(fdout); > > > ------------------------------------------------------------------------------ > The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your > production scanning environment may not be a perfect world - but thanks to > Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 > Series Scanner you'll get full speed at 300 dpi even with all image > processing features enabled. http://p.sf.net/sfu/kodak-com > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

2 1

[Monetdb-developers] Mapi wire protocol level 9
by Fabian.Groffen＠cwi.nl 11 May '09

11 May '09

Hi, As I'm working on changing the password backend of M5 to use hashes instead of cypher3d clear text passwords[1], I have to bump the wire protocol level from 8 to 9, since the client will have to construct the challenge response differently. Since this is a bump, this is a good time to also incorporate (or prepara) any other changes that we would like to see in the wire protocol for the next feature release. [1] to allow sql to dump users and passwords in a safe manner, the dump needs to be able restore passwords from a hash, which are then stored in the backend. Hence the backend needs to work with those hashes instead of clear text passwords, as it currently does.

2 1

Re: [Monetdb-developers] [Monetdb-sql-checkins] sql/src/backends/monet5 sql_user.mx, , 1.42, 1.43
by Stefan de Konink 11 May '09

11 May '09

Fabian wrote: > int len = strlen(passwd); > - if ((ret = AUTHSHA1Sum(&pwd, &passwd, &len)) != MAL_SUCCEED) { > + if ((ret = AUTHBackendSum(&pwd, &passwd, &len)) != MAL_SUCCEED) { A sum of 0 will not work. Stefan

2 1