Removal of exit-on-error did not break the M5 tests. The SQL tests show some differences related to rendering of dump_table and a few that require a little more study. The situation in M4, AMDB, and XQuery is yet unknown. Fabian Groffen wrote:
On 15-08-2007 15:23:56 +0200, Stefan Manegold wrote:
Martin didn't implement anything, he only threw away the exit_on_error thing, which is fine with me too. I was refering to =================================================================== 2007/08/13 - mlkersten: clients/src/mapiclient/MapiClient.mx,1.24 With a better SQL rendering, we might as well use it as the default for stdin. All other use remains the same, so it does not affect the SQL testing output. =================================================================== which sounds like Martin implemented something.
I considered Martin's "According to Stefan this does not affect the test web." as refering to the lunch discussion we had about above checkin.
Ahh... I didn't play back those tapes yet.
(3) The actual results of running testing (Mtest.py) is the *only* indication whether and how any code changes affect testing. Hence, simply run Mtest.py, and you'll know. That's *excatly* what testing and Mtest.py have been designed and implemented for, and what the are supposed to be used for. Sometimes asking someone is much faster than implementing the code, and running Mtest. Right. And I answered also though I was not asked ;-)
Uhm... right.
Conclusions: 1) "it" probably breaks 2) changes to Mtest are necessary 3) exit_on_error should not have been thrown away from the code 4) "commit at once" of Mtest and MapiClient code is preferred 5) as always: improve communication.
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers