On Wed, Jul 30, 2008 at 11:26:27PM +0200, Martin Kersten wrote:
Stefan Manegold wrote:
On Wed, Jul 30, 2008 at 08:02:16AM +0000, Martin Kersten wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/atoms In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22933/atoms
Modified Files: blob.mx str.mx xml.mx Log Message: Silenceing the compiler on windows. Strings and BATcount are always less then 4GB
Even if so, int (signed) allows only 2^31 - 1, i.e., "2GB".
sure
Moreover, in the 64-bit case (in particular with 64-bit OIDs), neither the length of strings nor the tuple (BUN) count of BATs is formally restricted to 2^31 - 1 (or 2^32 - 1) --- in fact, breaking through this limit is one of the reasons for / features of the 64-bit port of MonetDB --- how efficiently such larger strings and BATs are handled is a different question ...
and that would be my target
That's why I used to guard all down-cast that I added with an assertion to detect overflows ...
[forgot] ... and used the proper types (e.g., size_t instead of int or lng) where ever necessary and/or possible ... Stefan
The places of the asserts should be limited to the periphery and where larger structures are created.
Stefan
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |