Please revert. The reason why there is a loop that sleeps 50 ms per iteration is to get a responsive exit. With your change you have to wait up to half a second before the server exits. That is too long. If you want to reduce the frequency with which the vmtrim thread does actual work, you need to change the number of times the loop is run, not the duration of the sleep. On 2013-01-08 01:21, Martin Kersten wrote:
Changeset: 4ca22f5177b6 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=4ca22f5177b6 Modified Files: gdk/gdk_utils.c Branch: Feb2013 Log Message:
Reduce CATNAP in vmtrim The overload on memory is already protected in the dataflow scheduler and optimizer pipeline, which means we probably can relax the time to issue the BBPtrim().
diffs (22 lines):
diff --git a/gdk/gdk_utils.c b/gdk/gdk_utils.c --- a/gdk/gdk_utils.c +++ b/gdk/gdk_utils.c @@ -1034,6 +1034,7 @@ GDKmunmap(void *addr, size_t size) * Their value is turned into a blanc space. */
+#define CATNAP 500 int GDKrecovery = 0;
static MT_Id GDKvmtrim_id; @@ -1053,8 +1054,8 @@ GDKvmtrim(void *limit) size_t cursize;
/* sleep using catnaps so we can exit in a timely fashion */ - for (t = highload ? 500 : 5000; t > 0; t -= 50) { - MT_sleep_ms(50); + for (t = highload ? CATNAP : 10 * CATNAP; t > 0; t -= CATNAP) { + MT_sleep_ms(CATNAP); if (GDKexiting()) return; } _______________________________________________ checkin-list mailing list checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list
-- Sjoerd Mullender _______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list