Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal mal_io.mx, Nov2009, 1.48.6.2, 1.48.6.3 mal_mapi.mx, Nov2009, 1.37.2.6, 1.37.2.7 recycle.mx, Nov2009, 1.66.2.1, 1.66.2.2

6 Nov 2009

Martin Kersten wrote:
...
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal
In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv8920
Modified Files:
      Tag: Nov2009
  mal_io.mx mal_mapi.mx recycle.mx 
Log Message:
A few Coverity changes.
Index: mal_mapi.mx
===================================================================
RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mal_mapi.mx,v
retrieving revision 1.37.2.6
retrieving revision 1.37.2.7
diff -u -d -r1.37.2.6 -r1.37.2.7

--- mal_mapi.mx	3 Nov 2009 20:15:01 -0000	1.37.2.6
+++ mal_mapi.mx	6 Nov 2009 15:17:13 -0000	1.37.2.7
@@ -402,8 +402,8 @@
      char *buf = (char *) GDKmalloc(BLOCK + 1);
      char *challenge;
      char *algos;
-		stream *fdin = block_stream(in);
-		stream *fdout = block_stream(out);
+		stream *fdin;
+		stream *fdout;
      bstream *bs;
      int len = 0;
@@ -411,10 +411,12 @@
      	GDKsyserror("SERVERlisten:"MAL_MALLOC_FAIL);
      	return;
      }
+		fdin = block_stream(in);
      if (!fdin || !fdout) {
      	GDKsyserror("SERVERlisten:fdin or fdout problems");
      	return;
      }
+		fdout = block_stream(out);
assert(buf);
You're assigning to fdout *after* checking whether it is NULL.

-- 
Sjoerd Mullender

    