On Mon, Mar 01, 2010 at 10:20:01AM +0100, Sjoerd Mullender wrote:
Note that this particular initialization doesn't do anything. Static variables are automatically initialized to 0.
Thanks! --- I overlooked that one --- then the rather high value of hottop (600037897) I encountered was indeed only cause by incrementing it "unboundedly" rather than an "unexpected" initialization ...
Also note that in the HEAD branch, hottop is initialized to MAXHOT (causing a propagation conflict).
I indeed did not check the HEAD branch --- I cannot tell which is supposed to be the "correct" initial value, 0 or MAXHOT --- maybe Martin can help ... Stefan
On 2010-03-01 09:27, Stefan Manegold wrote:
Update of /cvsroot/monetdb/MonetDB5/src/mal In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv17757/MonetDB5/src/mal
Modified Files: Tag: Feb2010 mal_interpreter.mx Log Message:
make sure we initialize the static global variable hottop at least once; I hope, 0 is the correct initial value.
Index: mal_interpreter.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_interpreter.mx,v retrieving revision 1.337.2.33 retrieving revision 1.337.2.34 diff -u -d -r1.337.2.33 -r1.337.2.34 --- mal_interpreter.mx 28 Feb 2010 18:49:24 -0000 1.337.2.33 +++ mal_interpreter.mx 1 Mar 2010 08:27:04 -0000 1.337.2.34 @@ -89,7 +89,7 @@ lng claim; /* actual claim on memory*/ int bid; } hotpotatoes[MAXHOT]; -static int hottop; +static int hottop = 0; @- The struct alignment leads to 40% gain in simple instructions when set. @c
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
_______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4199 |