On Tue, Dec 11, 2007 at 06:28:30PM +0100, Fabian Groffen wrote:
On 11-12-2007 18:23:06 +0100, Ying Zhang wrote:
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
then, how about just start mclient without any options? it will complain that no language option is given. would that be a sufficient indication that mclient can be started at all?
You missed a very vital "j". But look at the script and you will know like me that what is actually tested is already tested elsewhere, and that the test perceives to test something that is actually not tested (e.g. the mjclient script can still be tad broken, even though testing things it works).
On 11-12-2007 18:25:43 +0100, Fabian Groffen wrote: thinks
MonetDB Java is all your's. Hence, feel free to tailor it to your satisfaction. (To keep things clean, you might want to consider properly removing "pointless" tests instead of merely deactivating them --- just a *suggestion*.) Stefan -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |