Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/mil milprint_summer.c, 1.298.2.4, 1.298.2.5
Peter, the changes below seem to make 3 of the 6 Music/limit tests fail with " !ERROR: interpret: no matching MIL operator to 'seqbase(int, oid)'. !MAYBE YOU MEAN: ! seqbase(BAT[void,any::1], oid) : BAT[void,any::1] ! seqbase(BAT[void,any::1]) : oid ! seqbase(BAT[oid,any::1]) : oid " What kind of solution/fix do you recommend? (1) set the seqbase only if the type is BAT, or (2) add a "fake" constant-seqbase variant to the constant module ? Thanks! Stefan On Tue, Nov 28, 2006 at 02:18:09PM +0000, Peter Boncz wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/mil In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv14236
Modified Files: Tag: XQuery_0-14 milprint_summer.c Log Message: - [ 1600704 ] XQuery: subsequence > 1 fails
we require the seqbase of our iter|pos|item relations to be 0@0
Index: milprint_summer.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint_summer.c,v retrieving revision 1.298.2.4 retrieving revision 1.298.2.5 diff -u -d -r1.298.2.4 -r1.298.2.5 --- milprint_summer.c 16 Nov 2006 17:52:56 -0000 1.298.2.4 +++ milprint_summer.c 28 Nov 2006 14:18:06 -0000 1.298.2.5 @@ -7641,10 +7641,10 @@
milprintf(f, "\n" " # select a slice\n" - " ipik := ipik.slice(int(lo),hi);\n" - " iter := iter.slice(int(lo),hi);\n" - " kind := kind.slice(int(lo),hi);\n" - " item%s := item%s.slice(int(lo), hi);\n" + " ipik := ipik.slice(int(lo),hi).seqbase(0@0);\n" + " iter := iter.slice(int(lo),hi).seqbase(0@0);\n" + " kind := kind.slice(int(lo),hi).seqbase(0@0);\n" + " item%s := item%s.slice(int(lo), hi).seqbase(0@0);\n" " pos := ipik.mark(1@0);\n" "} else {\n" " # evaluate selection tuple by tuple (note: fully constant-resistant code)\n"
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Hi Stefan, Replace seqbase(0@0) by tmark(0@0). That one works with constants as well. -----Original Message----- From: Stefan Manegold [mailto:Stefan.Manegold@cwi.nl] Sent: Thursday, December 07, 2006 4:33 PM To: monetdb-developers@lists.sourceforge.net; Peter Boncz Subject: Re: [Monetdb-pf-checkins] pathfinder/compiler/mil milprint_summer.c, 1.298.2.4, 1.298.2.5 Peter, the changes below seem to make 3 of the 6 Music/limit tests fail with " !ERROR: interpret: no matching MIL operator to 'seqbase(int, oid)'. !MAYBE YOU MEAN: ! seqbase(BAT[void,any::1], oid) : BAT[void,any::1] ! seqbase(BAT[void,any::1]) : oid ! seqbase(BAT[oid,any::1]) : oid " What kind of solution/fix do you recommend? (1) set the seqbase only if the type is BAT, or (2) add a "fake" constant-seqbase variant to the constant module ? Thanks! Stefan On Tue, Nov 28, 2006 at 02:18:09PM +0000, Peter Boncz wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/mil In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv14236
Modified Files: Tag: XQuery_0-14 milprint_summer.c Log Message: - [ 1600704 ] XQuery: subsequence > 1 fails
we require the seqbase of our iter|pos|item relations to be 0@0
Index: milprint_summer.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint_summer.c,v retrieving revision 1.298.2.4 retrieving revision 1.298.2.5 diff -u -d -r1.298.2.4 -r1.298.2.5 --- milprint_summer.c 16 Nov 2006 17:52:56 -0000 1.298.2.4 +++ milprint_summer.c 28 Nov 2006 14:18:06 -0000 1.298.2.5 @@ -7641,10 +7641,10 @@
milprintf(f, "\n" " # select a slice\n" - " ipik := ipik.slice(int(lo),hi);\n" - " iter := iter.slice(int(lo),hi);\n" - " kind := kind.slice(int(lo),hi);\n" - " item%s := item%s.slice(int(lo), hi);\n" + " ipik := ipik.slice(int(lo),hi).seqbase(0@0);\n" + " iter := iter.slice(int(lo),hi).seqbase(0@0);\n" + " kind := kind.slice(int(lo),hi).seqbase(0@0);\n" + " item%s := item%s.slice(int(lo), hi).seqbase(0@0);\n" " pos := ipik.mark(1@0);\n" "} else {\n" " # evaluate selection tuple by tuple (note: fully constant-resistant code)\n"
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (2)
-
Peter Boncz
-
Stefan Manegold