On Thu, Jul 22, 2010 at 11:53:22AM +0200, Romulo Goncalves wrote:

Changeset: 7a88e64c34b1 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=7a88e64c34b1 Modified Files: sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.err sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.out Branch: Jun2010 Log Message:

It seems the err output for the test was not complete. In the approval of the test two sql statements were missing, therefore, the err output was created without the errors related to that two statements.

Thanks for taking care of this. My reason for not approving the error messages in the first place was that I was not sure about the intention of the test, and hence, whether and which error messages are to be expected. I now understand from your approval that the error messages indeed match the intention of the test. I wonder, though, whether the error message is indeed what it should be. Saying "failed: Success" (see below) seems at least "odd" to me ... Stefan

diffs (32 lines):

diff -r 6908fb1d95e4 -r 7a88e64c34b1 sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.err --- a/sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.err Thu Jul 22 11:02:07 2010 +0200 +++ b/sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.err Thu Jul 22 11:53:14 2010 +0200 @@ -71,9 +71,15 @@ # 13:12:55 > mclient -lsql -ftest -i -e --host=rig --port=39884 # 13:12:55 >

-MAPI = monetdb@rig:39884 +MAPI = monetdb@alviss:36310 QUERY = connect to default; ERROR = !CONNECT TO: DEFAULT is not supported! +MAPI = monetdb@alviss:36310 +QUERY = connect to 'whatever' port 50001 database 'nonexisting' USER 'monetdb' PASSWORD 'monetdb' LANGUAGE 'mal'; +ERROR = !IOException:mapi.connect:Could not connect: gethostbyname failed: Success

^^^^^^ ^^^^^^^ !!!!!! ???????

+MAPI = monetdb@alviss:36310 +QUERY = disconnect 'whatever'; +ERROR = !DISCONNECT CATALOG: no such db_alias 'whatever'

# 13:12:55 > # 13:12:55 > Done. diff -r 6908fb1d95e4 -r 7a88e64c34b1 sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.out --- a/sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.out Thu Jul 22 11:02:07 2010 +0200 +++ b/sql/src/test/BugTracker-2010/Tests/connectto.Bug-2548.stable.out Thu Jul 22 11:53:14 2010 +0200 @@ -23,8 +23,6 @@ # 13:12:55 > mclient -lsql -ftest -i -e --host=rig --port=39884 # 13:12:55 >

-! to be provided / approved ! - # 13:12:55 > # 13:12:55 > Done. # 13:12:55 > _______________________________________________ Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list

-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4199 |