Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/runtime serialize.mx, , 1.119, 1.120 xrpc_server.mx, , 1.85, 1.86
On Thu, Jan 22, 2009 at 03:06:44PM +0100, Ying Zhang wrote:
On Thu, Jan 22, 2009 at 12:30:21PM +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/runtime In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv16608
Modified Files: serialize.mx xrpc_server.mx Log Message: Added a new env. var. to make the root directory, from which the XRPC HTTP server serves files, configurable.
This was (mainly) needed to get the xrpc admin tests run with RunMtest, since RunMtest doesn't have monet installed yet (i.e., there is no $prefix/share/ MonetDB/xrpc/ yet), so we need a way to tell the xrpc server to serve file from a different directory, in this case, from $srcdir/runtime/xrpc.
Sorry, I forgot to mention that this checkin requires an update and a rebuild of MonetDB4, because changes in MonetDB4/conf/MonetDB.conf.in are needed.
question is why are they needed? or differently, why is the default (only) set in MonetDB.conf, rather then where it is (first) used in Pathfinder/XRPC? I would have expected that the newly added code in Pathfinder/XRPC, just checks, whether the new environment variable is set; if so, it uses that value; otherwise, it uses a default (defined there). In case your code does already exactly this, the changes in MonetDB.conf, should not be required for the new PF/XRPC code to work, rather, they mainly document the new variable and its default value. Stefan
Jennie
------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On Thu, Jan 22, 2009 at 03:14:05PM +0100, Stefan Manegold wrote:
On Thu, Jan 22, 2009 at 03:06:44PM +0100, Ying Zhang wrote:
On Thu, Jan 22, 2009 at 12:30:21PM +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/runtime In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv16608
Modified Files: serialize.mx xrpc_server.mx Log Message: Added a new env. var. to make the root directory, from which the XRPC HTTP server serves files, configurable.
This was (mainly) needed to get the xrpc admin tests run with RunMtest, since RunMtest doesn't have monet installed yet (i.e., there is no $prefix/share/ MonetDB/xrpc/ yet), so we need a way to tell the xrpc server to serve file from a different directory, in this case, from $srcdir/runtime/xrpc.
Sorry, I forgot to mention that this checkin requires an update and a rebuild of MonetDB4, because changes in MonetDB4/conf/MonetDB.conf.in are needed.
question is why are they needed?
or differently, why is the default (only) set in MonetDB.conf, rather then where it is (first) used in Pathfinder/XRPC?
I would have expected that the newly added code in Pathfinder/XRPC, just checks, whether the new environment variable is set; if so, it uses that value; otherwise, it uses a default (defined there).
No. The code expects/requires that this env. var. is set, otherwise it gives an error and does not start the xrpc server. There was no particular reason, except that the code is shorter this way. Well, I have thought about it cleaner to have the default value set/defined in only one place. But this might be irritating for at least people who don't want to update MonetDB everytime... Jennie
In case your code does already exactly this, the changes in MonetDB.conf, should not be required for the new PF/XRPC code to work, rather, they mainly document the new variable and its default value.
Stefan
Jennie
------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (2)
-
Stefan Manegold -
Ying Zhang