[Monetdb-developers] Mtest: remove M5 warning about modules
Currently Mtest.py spits out the following warning when using M5: Mtest.py Warning: MonetDB/5: Check, whether required modules do exist, is not possible, yet! It's in there for years. I think the functionality of Mtest to be able to check whether required modules are available before running a test come at the price of administering which modules are necessary to run the test. Implementing the module check in M5 hence would also mean adding the required module information to each test. Hence, I would suggest to remove the warning from Mtest.py and just deal with the error messages that appear when modules don't exist. Opinions?
Dear all, as as further background info: The original idea of the modules check was to make the information shown in the testing "cross-check-matrices" more detailed, i.e., instead of running a test tha then fails due to a missing module and simply shown a "red X" requiring to click on that to find out what was the reason for the failure, Mtest.py would skip that test issuing the below warning AND generating a specific output file that contains the information that the test was skipped due to a missing module. The scripts around Mtest.py that create the TestWeb (i.e., the TestTools) do than exploit this extra info and indicate directly in the "cross-check-matrix" that the test was skipped due to a missing module, rather than just showing that the test failed "arbitrarily". Cf., http://monetdb.cwi.nl/testing/projects/monetdb/Stable/MonetDB4/.mTests103/in... Obviously, this getting this extra info does require to maintain the modules required for each (or at least selected) tests. Alternatively, Mtest.py and or the TestTools could parse and analyse the output of all (failed) tests to find known errors and eventually add the same detailed info to the "cross-check-matrices" as described above. When starting with Mtest.py more than 10 years ago, I found the above solution simple and more efficient/effective. Having said that, I'm open to any changes that do not limit, restrict or even remove any functionality that we have now. Removing a not yet working/implemented functionality (though it might be "desirable") obviously fulfills these requirements. Stefan On Tue, Nov 11, 2008 at 11:42:38AM +0100, Fabian Groffen wrote:
Currently Mtest.py spits out the following warning when using M5:
Mtest.py Warning: MonetDB/5: Check, whether required modules do exist, is not possible, yet!
It's in there for years.
I think the functionality of Mtest to be able to check whether required modules are available before running a test come at the price of administering which modules are necessary to run the test. Implementing the module check in M5 hence would also mean adding the required module information to each test.
Hence, I would suggest to remove the warning from Mtest.py and just deal with the error messages that appear when modules don't exist.
Opinions?
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (2)
-
Fabian Groffen
-
Stefan Manegold