Re: [Monetdb-developers] [Monetdb-checkins] clients/src/php/Cimpl Makefile.ag, Clients_1-20, 1.4.4.1, 1.4.4.2
On 06-11-2007 11:55:48 +0000, Stefan Manegold wrote:
since compilation with strict compiler settings have (once again) proved to be bery useful to locate bugs in the code, we nolonger simply disable all of the strict "X_CFLAGS" in directories that (also) contain swig-code, but rather selectively disable only those extra warnings/errors that do indeed occur in code that is beyond our control.
(This affects only compilation with --enable-strict.)
...
+CFLAGS = $(GCC_SWIG_CFLAGS) $(ICC_SWIG_CFLAGS) -DCOMPILE_DL_MONETDB=1 -D_GNU_SOURCE
Unless I misunderstood the code in the .m4, this looks like the user specified CFLAGS are overriden here, which is an undesirable effect.
On Tue, Nov 06, 2007 at 01:00:49PM +0100, Fabian Groffen wrote:
On 06-11-2007 11:55:48 +0000, Stefan Manegold wrote:
since compilation with strict compiler settings have (once again) proved to be bery useful to locate bugs in the code, we nolonger simply disable all of the strict "X_CFLAGS" in directories that (also) contain swig-code, but rather selectively disable only those extra warnings/errors that do indeed occur in code that is beyond our control.
(This affects only compilation with --enable-strict.)
...
+CFLAGS = $(GCC_SWIG_CFLAGS) $(ICC_SWIG_CFLAGS) -DCOMPILE_DL_MONETDB=1 -D_GNU_SOURCE
Unless I misunderstood the code in the .m4, this looks like the user specified CFLAGS are overriden here, which is an undesirable effect.
they are not overwritten but extended. Stefan
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (2)
-
Fabian Groffen -
Stefan Manegold