Re: [Monetdb-developers] [Monetdb-sql-checkins] sql/src/backends/monet5 sql_optimizer.mx, , 1.183, 1.184
Milena Ivanova wrote:
Update of /cvsroot/monetdb/sql/src/backends/monet5 In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv29777
Modified Files: sql_optimizer.mx Log Message: Switch off the recycler. Why?
We activated it to test it during night on other platforms. It helps to see if there is any problem from one day to another and it also helps to detect problems on the code. If you made a change and you broke tests, you should not commit until until you make sure that the existent tests (SQL or M5) are green. It is with these steps that we can get stable code and avoid bugs... Romulo
U sql_optimizer.mx Index: sql_optimizer.mx =================================================================== RCS file: /cvsroot/monetdb/sql/src/backends/monet5/sql_optimizer.mx,v retrieving revision 1.183 retrieving revision 1.184 diff -u -d -r1.183 -r1.184 --- sql_optimizer.mx 6 Jun 2008 20:25:15 -0000 1.183 +++ sql_optimizer.mx 12 Jun 2008 15:33:12 -0000 1.184 @@ -455,9 +455,10 @@ "joinPath," "mergetable," "commonTerms," +/* "replicator," */ "accumulators," "deadcode," - "recycle," +/* "recycle," */ "reduce," "garbageCollector," "multiplex";
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-sql-checkins mailing list Monetdb-sql-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
Romulo Goncalves wrote:
Milena Ivanova wrote:
Update of /cvsroot/monetdb/sql/src/backends/monet5 In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv29777
Modified Files: sql_optimizer.mx Log Message: Switch off the recycler.
Why?
We activated it to test it during night on other platforms. It helps to see if there is any problem from one day to another and it also helps to detect problems on the code.
If you made a change and you broke tests, you should not commit until until you make sure that the existent tests (SQL or M5) are green.
this rule is a guidline. I approved it, because the focus is on getting the recycler working and there were signals of a serious flaw, making the web unnecessary red and not time to check. The problem seems less severe and the patch is likely to be reversed when the tests are ran.
It is with these steps that we can get stable code and avoid bugs...
Romulo
U sql_optimizer.mx Index: sql_optimizer.mx =================================================================== RCS file: /cvsroot/monetdb/sql/src/backends/monet5/sql_optimizer.mx,v retrieving revision 1.183 retrieving revision 1.184 diff -u -d -r1.183 -r1.184 --- sql_optimizer.mx 6 Jun 2008 20:25:15 -0000 1.183 +++ sql_optimizer.mx 12 Jun 2008 15:33:12 -0000 1.184 @@ -455,9 +455,10 @@ "joinPath," "mergetable," "commonTerms," +/* "replicator," */ "accumulators," "deadcode," - "recycle," +/* "recycle," */ "reduce," "garbageCollector," "multiplex";
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-sql-checkins mailing list Monetdb-sql-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (2)
-
Martin Kersten -
Romulo Goncalves