Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/algebra/opt opt_join_pd.c, XQuery_0-24, 1.46.2.1, 1.46.2.2
Jan, Sjoerd, I'll take care of these. Sjoerd, please do not propagate until I'm done. Stefan On Mon, Jun 02, 2008 at 08:44:32AM +0000, Jan Rittinger wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/algebra/opt In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv1643/algebra/opt
Modified Files: Tag: XQuery_0-24 opt_join_pd.c Log Message: -- circumvent bugs #1981491 and #1908822 for the release.
This 'hack' does not fix the real problem (that we have to get rid of bit-encoded column names), but just disables some optimizations in case we might get into trouble. Thus we can apply less rewrites and get 'suboptimal' plans.
THIS IS A RELEASE ONLY CHECKIN --- PLEASE DO NOT PROPAGATE!
U opt_join_pd.c Index: opt_join_pd.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/algebra/opt/opt_join_pd.c,v retrieving revision 1.46.2.1 retrieving revision 1.46.2.2 diff -u -d -r1.46.2.1 -r1.46.2.2 --- opt_join_pd.c 28 May 2008 11:37:25 -0000 1.46.2.1 +++ opt_join_pd.c 2 Jun 2008 08:44:30 -0000 1.46.2.2 @@ -580,6 +580,11 @@ } break;
case la_project: + /* disable rewrite in case we might get wider relations + than we can map back to the bit-encoded (ori) column + names */ + if (PFarray_last (rproj) + L(lp)->schema.count < 30) + /* Arbitrary projections are pushed through the join operator by: 1.) merging the projection lists of the projection
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Propagation has been prevented. Sjoerd, you're free to propagate the other changes again (whenever you wnat or need to) Stefan On Mon, Jun 02, 2008 at 11:13:20AM +0200, Stefan Manegold wrote:
Jan, Sjoerd,
I'll take care of these.
Sjoerd, please do not propagate until I'm done.
Stefan
On Mon, Jun 02, 2008 at 08:44:32AM +0000, Jan Rittinger wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/algebra/opt In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv1643/algebra/opt
Modified Files: Tag: XQuery_0-24 opt_join_pd.c Log Message: -- circumvent bugs #1981491 and #1908822 for the release.
This 'hack' does not fix the real problem (that we have to get rid of bit-encoded column names), but just disables some optimizations in case we might get into trouble. Thus we can apply less rewrites and get 'suboptimal' plans.
THIS IS A RELEASE ONLY CHECKIN --- PLEASE DO NOT PROPAGATE!
U opt_join_pd.c Index: opt_join_pd.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/algebra/opt/opt_join_pd.c,v retrieving revision 1.46.2.1 retrieving revision 1.46.2.2 diff -u -d -r1.46.2.1 -r1.46.2.2 --- opt_join_pd.c 28 May 2008 11:37:25 -0000 1.46.2.1 +++ opt_join_pd.c 2 Jun 2008 08:44:30 -0000 1.46.2.2 @@ -580,6 +580,11 @@ } break;
case la_project: + /* disable rewrite in case we might get wider relations + than we can map back to the bit-encoded (ori) column + names */ + if (PFarray_last (rproj) + L(lp)->schema.count < 30) + /* Arbitrary projections are pushed through the join operator by: 1.) merging the projection lists of the projection
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (1)
-
Stefan Manegold