Re: [Monetdb-developers] [Monetdb-checkins] buildtools Makefile.in, 1.6, 1.7
On 12/27/2006 03:30 PM, Fabian wrote:
Update of /cvsroot/monetdb/buildtools In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv5580
Modified Files: Makefile.in Log Message: Force python to respect the build dir, as it pollutes the source dir otherwise. This is extra annoying because when using different platforms from the same source tree, python thinks its build cache is fine, and just installs files which plain won't work on the target machine.
This I don't quite understand. Autogen is python only. There are no platform-dependent files there at all. So, what is the problem that you're fixing? (This is not saying that I mind the solution, I question the reason.)
Index: Makefile.in =================================================================== RCS file: /cvsroot/monetdb/buildtools/Makefile.in,v retrieving revision 1.6 retrieving revision 1.7 diff -u -d -r1.6 -r1.7 --- Makefile.in 22 Dec 2006 15:42:21 -0000 1.6 +++ Makefile.in 27 Dec 2006 14:30:46 -0000 1.7 @@ -10,14 +10,17 @@ @-echo
all: - cd "$(SRC)/autogen" && python setup.py build + cd "$(SRC)"/autogen && python setup.py build \ + --build-base="$(BUILD)"/_autogen cd _MX && $(MAKE) MAKE=$(MAKE) $@ cd _MEL && $(MAKE) MAKE=$(MAKE) $@ cd _BURG && $(MAKE) MAKE=$(MAKE) $@
# ... run individual "make install"s ... install: - cd "$(SRC)/autogen" && python setup.py install --prefix="$(DESTDIR)$(PREFIX)" + cd "$(SRC)"/autogen && python setup.py install \ + --build-base="$(BUILD)"/_autogen \ + --prefix="$(DESTDIR)$(PREFIX)" cd _MX && $(MAKE) MAKE=$(MAKE) $@ cd _MEL && $(MAKE) MAKE=$(MAKE) $@ cd _BURG && $(MAKE) MAKE=$(MAKE) $@
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
On 27-12-2006 16:14:56 +0100, Sjoerd Mullender wrote:
On 12/27/2006 03:30 PM, Fabian wrote:
Update of /cvsroot/monetdb/buildtools In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv5580
Modified Files: Makefile.in Log Message: Force python to respect the build dir, as it pollutes the source dir otherwise. This is extra annoying because when using different platforms from the same source tree, python thinks its build cache is fine, and just installs files which plain won't work on the target machine.
This I don't quite understand. Autogen is python only. There are no platform-dependent files there at all. So, what is the problem that you're fixing?
autogen.py in an executable script with a substituted shebang (#!/path/to). On platform a, python is found in /path/to/my/first/python, however on my platform b python is to be found at /somewhere/else/in/my/filesystem/is/python. My shell (correctly IMO) thinks that an executable file with an invalid shebang cannot be executed. Note, this is not a problem as long as your python is always in the same place, e.g. /usr/bin/python. This is not the case for me, as there's either no python shipped with the OS, or it's so outdated that I want to replace it with my own version.
(This is not saying that I mind the solution, I question the reason.)
The solution is wrong, checkin to fix it follows shortly I hope. ... no, I cannot get the ***!*!@@#$(@!*@** thing right. So if you know how in the python world you are supposed to build into a build dir (such that the install target also uses the build dir) than I urge you to fix it properly. I will reverse my checkin, as it breaks installation right now. What a mess.
participants (2)
-
Fabian Groffen -
Sjoerd Mullender