Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/sql sql.c, 1.5, 1.6
Manuel, thanks for the quick fix --- unfootunately, icc is still not "happy": /ufs/manegold/_/scratch0/Monet/Testing/Current/pathfinder/compiler/sql/sql.c(176): error #188: enumerated type mixed with another type ret.type = aat_int; ^ I guess, ret.type = sql_type_integer; would make icc happy ... ;-) Stefan On Tue, Nov 07, 2006 at 09:32:57AM +0000, Manuel Mayr wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/sql In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv26876
Modified Files: sql.c Log Message: avoiding c++ comment style
Index: sql.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/sql/sql.c,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- sql.c 7 Nov 2006 09:13:43 -0000 1.5 +++ sql.c 7 Nov 2006 09:32:55 -0000 1.6 @@ -173,6 +173,7 @@ { PFsql_schema_item_t ret;
+ ret.type = aat_int; ret.name = PFsql_alg_att_conv(item.name);
return ret;
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Already done, some of you have very restrictive compilers ;) My compiler accepts this input so i didn't see it. Best regards, Manuel On Tue, 7 Nov 2006, Stefan Manegold wrote:
Manuel,
thanks for the quick fix --- unfootunately, icc is still not "happy":
/ufs/manegold/_/scratch0/Monet/Testing/Current/pathfinder/compiler/sql/sql.c(176): error #188: enumerated type mixed with another type ret.type = aat_int; ^
I guess, ret.type = sql_type_integer;
would make icc happy ... ;-)
Stefan
On Tue, Nov 07, 2006 at 09:32:57AM +0000, Manuel Mayr wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/sql In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv26876
Modified Files: sql.c Log Message: avoiding c++ comment style
Index: sql.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/sql/sql.c,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- sql.c 7 Nov 2006 09:13:43 -0000 1.5 +++ sql.c 7 Nov 2006 09:32:55 -0000 1.6 @@ -173,6 +173,7 @@ { PFsql_schema_item_t ret;
+ ret.type = aat_int; ret.name = PFsql_alg_att_conv(item.name);
return ret;
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
On 2006-11-07 10:59, Manuel Mayr wrote:
Already done, some of you have very restrictive compilers ;) My compiler accepts this input so i didn't see it.
That's why we test. ;-) It's not a problem if you check something in that breaks on some other system than yours. However, it is a problem if you don't check the test web to see what you broke the previous day. This is not a complaint about how you behaved. You fixed things as soon as you became aware of them, so we're happy about that. -- Sjoerd Mullender
On Tue, Nov 07, 2006 at 10:59:42AM +0100, Manuel Mayr wrote:
Already done, some of you have very restrictive compilers ;) My compiler accepts this input so i didn't see it.
that's just fine. before checking in, you should ("must";-)) only ensure, that your code compiles with your favorite compiler (and configure settings) on your favorite system. Automatic nightly testing (cf. http://monetdb.cwi.nl/Development/TestWeb/) will take care of testing other platforms, compilers, configure settings, etc. and tell you (via email; guess you got ther first one this morning), in case things come out "unexpectedly"; then, you should try to analyse/fix the problems, or ask someone else to do so, in case you're not sure how to fix it yourself. We use strict compilers and compiler setting because these often help us to find bugs in the code. Stefan ps: Willkommen im Team! ;-)
Best regards, Manuel
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (3)
-
Manuel Mayr -
Sjoerd Mullender -
Stefan Manegold