Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/src/tools/java build.properties, XQuery_0-20, 1.1.2.3, 1.1.2.4
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
On Thu, Nov 01, 2007 at 12:30:31PM +0100, Fabian Groffen wrote:
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
Just because I haven't read your previous mail before commit the change. Hence, thanks for the suggestion, and I will change it again. Jennie
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
Jennie, just out of "pure curiosity": had you been able to compile your original version (that failed to compile with testing on all platforms) prior to checking it in? Stefan On Thu, Nov 01, 2007 at 01:27:40PM +0100, Ying Zhang wrote:
On Thu, Nov 01, 2007 at 12:30:31PM +0100, Fabian Groffen wrote:
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
Just because I haven't read your previous mail before commit the change. Hence, thanks for the suggestion, and I will change it again.
Jennie
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On Thu, Nov 01, 2007 at 01:33:06PM +0100, Stefan Manegold wrote:
Jennie,
just out of "pure curiosity":
had you been able to compile your original version (that failed to compile with testing on all platforms) prior to checking it in?
I did compile the java source code. My mistake was that I did not check the build.property before checkin: I set build_compiler to 'gcj' to check if the code compiles with gcj, after that I changed build_compiler to 'javac' since it should be used as default, but then, I didn't recompile... Jennie
Stefan
On Thu, Nov 01, 2007 at 01:27:40PM +0100, Ying Zhang wrote:
On Thu, Nov 01, 2007 at 12:30:31PM +0100, Fabian Groffen wrote:
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
Just because I haven't read your previous mail before commit the change. Hence, thanks for the suggestion, and I will change it again.
Jennie
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
Fabian Groffen wrote:
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
I don't know all the implications, but it seems to me that you should *not* specify the compiler in the build.{xml,properties} files. Just use whatever the system provides. On at least both Fedora and Cygwin it is possible to switch Java using the alternatives program (as superuser). And you should be able to change your $PATH to switch compilers. -- Sjoerd Mullender
On 01-11-2007 13:28:22 +0100, Sjoerd Mullender wrote:
Fabian Groffen wrote:
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
I don't know all the implications, but it seems to me that you should *not* specify the compiler in the build.{xml,properties} files. Just use whatever the system provides. On at least both Fedora and Cygwin it is possible to switch Java using the alternatives program (as superuser). And you should be able to change your $PATH to switch compilers.
Absolutely true. That's why Jennie should remove her build_compiler variable and all its trails from her entire Java project. Repeating myself again, if you want ant to use another compiler, set build.compiler in build.local.properties, or give it as argument to ant during it's invocation.
On Thu, Nov 01, 2007 at 05:24:31PM +0100, Fabian Groffen wrote:
On 01-11-2007 13:28:22 +0100, Sjoerd Mullender wrote:
Fabian Groffen wrote:
On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
Update of /cvsroot/monetdb/pathfinder/src/tools/java In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
Modified Files: Tag: XQuery_0-20 build.properties Log Message: Corrected value of the "compiler" attribute of <javac> [snip] # which Java compiler to use, default: javac -build_compiler=javac +build_compiler=javac1.5
While the comment doesn't reflect a valid state here, this isn't too flexible. Why don't you just drop the whole build_compiler variable you introduced, and use the completely transparent and well supported and usually expected build.compiler variable only once you really want to control what compiler is being used, as I suggested to you earlier?
I don't know all the implications, but it seems to me that you should *not* specify the compiler in the build.{xml,properties} files.
Just use whatever the system provides. On at least both Fedora and ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
you are right. will be removed.
Cygwin it is possible to switch Java using the alternatives program (as superuser). And you should be able to change your $PATH to switch compilers.
Absolutely true. That's why Jennie should remove her build_compiler variable and all its trails from her entire Java project.
Repeating myself again, if you want ant to use another compiler, set build.compiler in build.local.properties, or give it as argument to ant during it's invocation.
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (4)
-
Fabian Groffen -
Sjoerd Mullender -
Stefan Manegold -
Ying Zhang