Re: [Monetdb-developers] MonetDB: default - Add test to prevent warning
Arjen, is this a fix that should also be include in the upcoming Jun2010 release? If so, it would need to be back-ported to the Jun2010 branch ... Stefan On Tue, Jun 01, 2010 at 11:40:20AM +0200, Arjen de Rijke wrote:
Changeset: 74ee41649425 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=74ee41649425 Modified Files: clients/src/php/native/lib/php_mapi.inc Branch: default Log Message:
Add test to prevent warning
diffs (15 lines):
diff -r 80afe14ca780 -r 74ee41649425 clients/src/php/native/lib/php_mapi.inc --- a/clients/src/php/native/lib/php_mapi.inc Tue Jun 01 10:02:37 2010 +0200 +++ b/clients/src/php/native/lib/php_mapi.inc Tue Jun 01 11:37:25 2010 +0200 @@ -768,8 +768,10 @@ global $connection_pool;
$connections = array(); - foreach($connection_pool as $conn) { + if ($connection_pool !== null) { + foreach($connection_pool as $conn) { $connections[] = $conn["id"]; + } }
$id = hash("sha1", time()); _______________________________________________ Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4199 |
Stefan Manegold
Arjen,
is this a fix that should also be include in the upcoming Jun2010 release?
If so, it would need to be back-ported to the Jun2010 branch ...
Yes, i will back-port it. Arjen
Stefan
On Tue, Jun 01, 2010 at 11:40:20AM +0200, Arjen de Rijke wrote:
Changeset: 74ee41649425 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=74ee41649425 Modified Files: clients/src/php/native/lib/php_mapi.inc Branch: default Log Message:
Add test to prevent warning
diffs (15 lines):
diff -r 80afe14ca780 -r 74ee41649425 clients/src/php/native/lib/php_mapi.inc --- a/clients/src/php/native/lib/php_mapi.inc Tue Jun 01 10:02:37 2010 +0200 +++ b/clients/src/php/native/lib/php_mapi.inc Tue Jun 01 11:37:25 2010 +0200 @@ -768,8 +768,10 @@ global $connection_pool;
$connections = array(); - foreach($connection_pool as $conn) { + if ($connection_pool !== null) { + foreach($connection_pool as $conn) { $connections[] = $conn["id"]; + } }
$id = hash("sha1", time()); _______________________________________________ Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list
-- ==================================================================== CWI, Kamer L330 Centrum voor Wiskunde en Informatica Science Park 123 Email: arjen.de.rijke@cwi.nl 1098 XG Amsterdam tel: +31-(0)20-5924305 Nederland +31-(0)6-51899284 fax: +31-(0)20-5924312 ===================== http://www.cwi.nl/~rijke/ ====================
participants (2)
-
Arjen de Rijke -
Stefan Manegold