Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/kernel algebra.mx, , 1.231, 1.232
I guess this has been since the dawn of time there:) The thing is that
I am implementing standard deviation support on the aggregation
functions and this new functionality goes in the dev head, thats why
this commit went there too. I am trying to stay clear from stable
branches for now
On Sun, Jan 17, 2010 at 11:48 AM, Sjoerd Mullender
Wouldn't this have been appropriate on one of the branches? I'd even go so far as suggesting the Nov2009 branch.
On 2010-01-17 11:40, Lefteris Sidirourgos wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/kernel In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv5751
Modified Files: algebra.mx Log Message: We export the algebra avg functions twice. there is no need for that, so delete one of the two export statements
Index: algebra.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/modules/kernel/algebra.mx,v retrieving revision 1.231 retrieving revision 1.232 diff -u -d -r1.231 -r1.232 --- algebra.mx 12 Jan 2010 09:13:49 -0000 1.231 +++ algebra.mx 17 Jan 2010 10:40:06 -0000 1.232 @@ -1081,17 +1081,6 @@ algebra_export str ALGidentity(int *ret, int *bid); algebra_export str ALGmaterialize(int *ret, int *bid); algebra_export str ALGreuse(int *ret, int *bid); - -@= avg_export -algebra_export str ALGavg_@1(dbl *res, int *bid) { -@h -@:avg_export(bte)@ -@:avg_export(sht)@ -@:avg_export(int)@ -@:avg_export(wrd)@ -@:avg_export(lng)@ -@:avg_export(flt)@ -@:avg_export(dbl)@ #endif @c #include "mal_config.h"
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
On 2010-01-17 12:12, Lefteris wrote:
I guess this has been since the dawn of time there:) The thing is that I am implementing standard deviation support on the aggregation functions and this new functionality goes in the dev head, thats why this commit went there too. I am trying to stay clear from stable branches for now
When you encounter a bug while doing development (which indeed should go to the head), then you should fix the bug in the branch. This is indeed not a serious bug, but still, it's a bug.
On Sun, Jan 17, 2010 at 11:48 AM, Sjoerd Mullender
wrote: Wouldn't this have been appropriate on one of the branches? I'd even go so far as suggesting the Nov2009 branch.
On 2010-01-17 11:40, Lefteris Sidirourgos wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/kernel In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv5751
Modified Files: algebra.mx Log Message: We export the algebra avg functions twice. there is no need for that, so delete one of the two export statements
Index: algebra.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/modules/kernel/algebra.mx,v retrieving revision 1.231 retrieving revision 1.232 diff -u -d -r1.231 -r1.232 --- algebra.mx 12 Jan 2010 09:13:49 -0000 1.231 +++ algebra.mx 17 Jan 2010 10:40:06 -0000 1.232 @@ -1081,17 +1081,6 @@ algebra_export str ALGidentity(int *ret, int *bid); algebra_export str ALGmaterialize(int *ret, int *bid); algebra_export str ALGreuse(int *ret, int *bid); - -@= avg_export -algebra_export str ALGavg_@1(dbl *res, int *bid) { -@h -@:avg_export(bte)@ -@:avg_export(sht)@ -@:avg_export(int)@ -@:avg_export(wrd)@ -@:avg_export(lng)@ -@:avg_export(flt)@ -@:avg_export(dbl)@ #endif @c #include "mal_config.h"
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- Sjoerd Mullender
participants (2)
-
Lefteris
-
Sjoerd Mullender