Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal tablet.mx, , 1.93, 1.94
Martin Kersten wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv14370
Modified Files: tablet.mx Log Message: There is no guarantee that the table descriptor has a BAT assigned to the first field. So you may not perform a BATcount. After this checkin (I still have to check if I did not change the code). The crash in the mserver with the skyserver data is gone. I will run more experiments to check it.
Regards, Romulo
Index: tablet.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/tablet.mx,v retrieving revision 1.93 retrieving revision 1.94 diff -u -d -r1.93 -r1.94 --- tablet.mx 16 Jun 2007 07:54:02 -0000 1.93 +++ tablet.mx 19 Jun 2007 05:54:56 -0000 1.94 @@ -1495,7 +1495,7 @@ TABLETload_file(Tablet * as, bstream *b, stream *out) { int res = 0, done = 0; - size_t i = 0; + size_t i = 0, tuples=0; char *sep = as->format[as->nr_attrs - 1].sep; int seplen = as->format[as->nr_attrs - 1].seplen;
@@ -1551,9 +1551,10 @@ as->error=0; GDKerror("TABLETload_file: read error " "(after loading %d records)\n", - BATcount(as->format[0].c)); + tuples); res = -1; } + tuples++; break; } end = b->buf + b->len;
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
Romulo Goncalves wrote:
Martin Kersten wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv14370
Modified Files: tablet.mx Log Message: There is no guarantee that the table descriptor has a BAT assigned to the first field. So you may not perform a BATcount. After this checkin (I still have to check if I did not change the code). The crash in the mserver with the skyserver data is gone. I will run more experiments to check it. Well, I was wrong. But with new experiments I could see that if I have 2 clients one to load and another one just connected the load works. It seems the when I use only one client the way that it exits is breaking something and the load is not done correctly.
I ran with M4 stable (optimized and strict compilation) and there is not fkey violations. Could this problem related with the changes that Niels applied to the client exit? Because now ti also happens in the cvs branch. Regards, Romulo
participants (1)
-
Romulo Goncalves