Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal tablet.mx, , 1.207, 1.208
Was this a current-only bug or should this be backported? On 2009-08-07 16:10, Niels Nes wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv6865/src/modules/mal
Modified Files: tablet.mx Log Message: output correct line numbers
U tablet.mx Index: tablet.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/tablet.mx,v retrieving revision 1.207 retrieving revision 1.208 diff -u -d -r1.207 -r1.208 --- tablet.mx 7 Aug 2009 06:25:15 -0000 1.207 +++ tablet.mx 7 Aug 2009 14:10:01 -0000 1.208 @@ -2140,7 +2140,7 @@ mal_set_lock(mal_contextLock,"tablet insert value"); if ( *err == NULL){ snprintf(buf,BUFSIZ, "value '%s' while parsing '%s' from line " BUNFMT - " field %d not inserted, expecting type %s\n", val, s, BATcount(fmt->c), c, fmt->type); + " field %d not inserted, expecting type %s\n", val, s, BATcount(fmt->c)+1, c, fmt->type); *err= GDKstrdup(buf); } mal_unset_lock(mal_contextLock,"tablet insert value"); @@ -2155,7 +2155,7 @@ } return 0; bunins_failed: - snprintf(buf,BUFSIZ, "while parsing '%s' from line " BUNFMT " field %d not inserted\n", s, BATcount(fmt->c), c); + snprintf(buf,BUFSIZ, "while parsing '%s' from line " BUNFMT " field %d not inserted\n", s, BATcount(fmt->c)+1, c); *err= GDKstrdup(buf); return -1; }
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
On Mon, Aug 10, 2009 at 10:01:24AM +0200, Sjoerd Mullender wrote:
Was this a current-only bug or should this be backported?
IMHO, this was a current-only bug, since this is new code in the CVS HEAD, which is not in the Aug2009 release branch. Stefan
On 2009-08-07 16:10, Niels Nes wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv6865/src/modules/mal
Modified Files: tablet.mx Log Message: output correct line numbers
U tablet.mx Index: tablet.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/tablet.mx,v retrieving revision 1.207 retrieving revision 1.208 diff -u -d -r1.207 -r1.208 --- tablet.mx 7 Aug 2009 06:25:15 -0000 1.207 +++ tablet.mx 7 Aug 2009 14:10:01 -0000 1.208 @@ -2140,7 +2140,7 @@ mal_set_lock(mal_contextLock,"tablet insert value"); if ( *err == NULL){ snprintf(buf,BUFSIZ, "value '%s' while parsing '%s' from line " BUNFMT - " field %d not inserted, expecting type %s\n", val, s, BATcount(fmt->c), c, fmt->type); + " field %d not inserted, expecting type %s\n", val, s, BATcount(fmt->c)+1, c, fmt->type); *err= GDKstrdup(buf); } mal_unset_lock(mal_contextLock,"tablet insert value"); @@ -2155,7 +2155,7 @@ } return 0; bunins_failed: - snprintf(buf,BUFSIZ, "while parsing '%s' from line " BUNFMT " field %d not inserted\n", s, BATcount(fmt->c), c); + snprintf(buf,BUFSIZ, "while parsing '%s' from line " BUNFMT " field %d not inserted\n", s, BATcount(fmt->c)+1, c); *err= GDKstrdup(buf); return -1; }
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (2)
-
Sjoerd Mullender
-
Stefan Manegold