Re: [Monetdb-developers] [Monetdb-checkins] MonetDB/src/mapi/clients/php/Cimpl php_monetdb.c, 1.54, 1.55 php_monetdb.h, 1.20, 1.21
Fabian, thanks for the fixes! unfortunately, there are (at least I get) still quite some warnings with both gcc & icc (see attachments); hence, it's still too early to re-enable strict flags for php ... Stefan On Thu, Nov 02, 2006 at 02:15:00PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/MonetDB/src/mapi/clients/php/Cimpl In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv4902
Modified Files: php_monetdb.c php_monetdb.h Log Message: Resolve two warnings in our php module. It now compiles without any warnings. I'm not quite sure how to enable strict flags for php again.
Index: php_monetdb.h =================================================================== RCS file: /cvsroot/monetdb/MonetDB/src/mapi/clients/php/Cimpl/php_monetdb.h,v retrieving revision 1.20 retrieving revision 1.21 diff -u -d -r1.20 -r1.21 --- php_monetdb.h 26 May 2006 08:45:35 -0000 1.20 +++ php_monetdb.h 2 Nov 2006 14:14:58 -0000 1.21 @@ -124,6 +124,10 @@ #define MONETDB_DML_ASYNC (1<<10) /* Do async query */ #define MONETDB_DML_STRING (1<<11) /* Return query string */
+/* avoid redeclaration */ +#ifdef _POSIX_C_SOURCE +# undef _POSIX_C_SOURCE +#endif
#include "Mapi.h" /* typedefs for convenience; not using Mapi's as those already are a
Index: php_monetdb.c =================================================================== RCS file: /cvsroot/monetdb/MonetDB/src/mapi/clients/php/Cimpl/php_monetdb.c,v retrieving revision 1.54 retrieving revision 1.55 diff -u -d -r1.54 -r1.55 --- php_monetdb.c 24 Oct 2006 14:26:18 -0000 1.54 +++ php_monetdb.c 2 Nov 2006 14:14:58 -0000 1.55 @@ -616,13 +616,13 @@ */ if (!(connect_type & MONETDB_CONNECT_FORCE_NEW) && zend_hash_find(&EG(regular_list),str.c,str.len+1,(void **) &index_ptr)==SUCCESS) { - int type,link; + int type, link; void *ptr;
if (Z_TYPE_P(index_ptr) != le_index_ptr) { RETURN_FALSE; } - link = (int) index_ptr->ptr; + link = (int)(size_t) index_ptr->ptr; ptr = zend_list_find(link,&type); /* check if the link is still there */ if (ptr && (type==le_link || type==le_plink)) { Z_LVAL_P(return_value) = link;
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On 02-11-2006 15:46:13 +0100, Stefan Manegold wrote:
Fabian,
thanks for the fixes!
unfortunately, there are (at least I get) still quite some warnings with both gcc & icc (see attachments); hence, it's still too early to re-enable strict flags for php ...
You're right. Due to the recent CFLAG mangling I lost my -W -Wall flags which hide most of the warnings. I'll revisit it later.
participants (2)
-
Fabian Groffen
-
Stefan Manegold