Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/mal mal_interpreter.mx, , 1.286, 1.287
Milena, do you consider this a bug fix or a new feature? if the former, it will not be in the upcoming release, since it has not (yet) been checked in to the Feb2009 release branch... in case you consider an exceptional back-port of this checkin to the Feb2009 release branch, please make sure you od this using the approriate CVS commands to ensure that the identical changes are applied --- see, e.g., page 14 of http://homepages.cwi.nl/~manegold/Presentations/MonetDBdevTTT.pdf for details --- don't hesitate to ask inc ase you need help ... Stefan On Mon, Feb 16, 2009 at 01:56:58PM +0000, Milena Ivanova wrote:
Update of /cvsroot/monetdb/MonetDB5/src/mal In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv13891
Modified Files: mal_interpreter.mx Log Message: Call recycler only for instructions with positive value of the recycle field.
U mal_interpreter.mx Index: mal_interpreter.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_interpreter.mx,v retrieving revision 1.286 retrieving revision 1.287 diff -u -d -r1.286 -r1.287 --- mal_interpreter.mx 15 Feb 2009 23:15:30 -0000 1.286 +++ mal_interpreter.mx 16 Feb 2009 13:56:55 -0000 1.287 @@ -1993,14 +1993,14 @@ The recycler works for any variable and relies on policy functions registered. @= MALrecycleStart - if ( pci->recycle >= 0) + if ( pci->recycle > 0) @1->clk = GDKusec(); if( !RECYCLEentry(cntxt, mb,stk,pci) ) @= MALrecycleExit - if ( pci->recycle >= 0) + if( pci->recycle > 0 ){ tcs = GDKusec() - @1->clk; - if( pci->recycle > 0 ) RECYCLEexit(cntxt, mb,stk,pci,tcs); + } @} @- @node Garbage Collection, Stack Management, Exception Handling, The MAL Interpreter
------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
I already backported this at the request of Martin. Stefan Manegold wrote:
Milena,
do you consider this a bug fix or a new feature?
if the former, it will not be in the upcoming release, since it has not (yet) been checked in to the Feb2009 release branch...
in case you consider an exceptional back-port of this checkin to the Feb2009 release branch, please make sure you od this using the approriate CVS commands to ensure that the identical changes are applied --- see, e.g., page 14 of http://homepages.cwi.nl/~manegold/Presentations/MonetDBdevTTT.pdf for details --- don't hesitate to ask inc ase you need help ...
Stefan
On Mon, Feb 16, 2009 at 01:56:58PM +0000, Milena Ivanova wrote:
Update of /cvsroot/monetdb/MonetDB5/src/mal In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv13891
Modified Files: mal_interpreter.mx Log Message: Call recycler only for instructions with positive value of the recycle field.
U mal_interpreter.mx Index: mal_interpreter.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_interpreter.mx,v retrieving revision 1.286 retrieving revision 1.287 diff -u -d -r1.286 -r1.287 --- mal_interpreter.mx 15 Feb 2009 23:15:30 -0000 1.286 +++ mal_interpreter.mx 16 Feb 2009 13:56:55 -0000 1.287 @@ -1993,14 +1993,14 @@ The recycler works for any variable and relies on policy functions registered. @= MALrecycleStart - if ( pci->recycle >= 0) + if ( pci->recycle > 0) @1->clk = GDKusec(); if( !RECYCLEentry(cntxt, mb,stk,pci) ) @= MALrecycleExit - if ( pci->recycle >= 0) + if( pci->recycle > 0 ){ tcs = GDKusec() - @1->clk; - if( pci->recycle > 0 ) RECYCLEexit(cntxt, mb,stk,pci,tcs); + } @} @- @node Garbage Collection, Stack Management, Exception Handling, The MAL Interpreter
------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- Sjoerd Mullender
participants (2)
-
Sjoerd Mullender
-
Stefan Manegold