On Sun, Apr 11, 2010 at 11:47:41AM +0200, Sjoerd Mullender wrote:

Should this have been changed on the Feb2010 branch?

not sure, the problem of performance problems and leaking hash files was reported on the Head. I'll check the code in stable. Niels

On 2010-04-11 11:30, Niels Nes wrote:

...

Update of /cvsroot/monetdb/MonetDB/src/gdk In directory sfp-cvsdas-4.v30.ch3.sourceforge.com:/tmp/cvs-serv4560

Modified Files: gdk_bat.mx Log Message: make sure we use the correct hash file (use views bat id for hhash/thash)

Index: gdk_bat.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB/src/gdk/gdk_bat.mx,v retrieving revision 1.241 retrieving revision 1.242 diff -u -d -r1.241 -r1.242 --- gdk_bat.mx 22 Feb 2010 10:10:48 -0000 1.241 +++ gdk_bat.mx 11 Apr 2010 09:30:13 -0000 1.242 @@ -3355,7 +3355,7 @@

hp->filename = GDKmalloc(strlen(nme) + 12); if (hp->filename != NULL) - sprintf(hp->filename, "%s.%chash", nme, b->batCacheid > 0 ? 'h' : 't'); + sprintf(hp->filename, "%s.%chash", nme, bv->batCacheid > 0 ? 'h' : 't'); if (hp->filename == NULL || (bv->H->hash = HASHnew(hp, tpe, yy + lim, HASHmask(lim))) == NULL) { GDKfree(hp->filename);

------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

-- Sjoerd Mullender

------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

-- Niels Nes, Centrum Wiskunde & Informatica (CWI) Science Park 123, 1098 XG Amsterdam, The Netherlands room L3.14, phone ++31 20 592-4098 sip:4098@sip.cwi.nl url: http://www.cwi.nl/~niels e-mail: Niels.Nes@cwi.nl