Dear all, I was wondering whether MonetDB/Java's "mjclient" wrapper script for jdbcclient.jar is still "maintained", "supported" and/or used? We do only distribute it via MonetDB/Java's CVS sources, source tarball and the SuperSourceBall, but not in any binary package or as individual file like the *.jar's. However, we (still) use it in some tests (see below). I see the follwoing options: 1) Leave everything as it is. 2) Leave and distribute mjclient in/with the MonetDB/Java source, but make the tests independed of it by "inlining" its functionality 3) Abandon mjclient completely and make the tests independed of it by "inlining" its functionality Any preferences and/or other suggestions? Stefan ======== ./sql/src/test/BugDay_2005-10-06_2.9.3/Tests/alter_table_describe.SF-1146092.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\alter_table_describe.SF-1146092-src.sql" ./sql/src/test/BugDay_2005-10-06_2.9.3/Tests/alter_table_describe.SF-1146092.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d $TSTDB -f \"$RELSRCDIR/alter_table_describe.SF-1146092-src.sql\"" ./sql/src/test/BugDay_2005-10-06_2.9.3/Tests/not_null.SF-933194.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\not_null.SF-933194-src.sql" ./sql/src/test/BugDay_2005-10-06_2.9.3/Tests/not_null.SF-933194.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d $TSTDB -f \"$RELSRCDIR/not_null.SF-933194-src.sql\"" ./sql/src/test/BugDay_2005-10-06_2.9.3/Tests/type_dump_test.SF-989257.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\type_dump_test.SF-989257-src.sql" ./sql/src/test/BugDay_2005-10-06_2.9.3/Tests/type_dump_test.SF-989257.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d $TSTDB -f \"$RELSRCDIR/type_dump_test.SF-989257-src.sql\"" ./sql/src/test/bugs/Tests/except-union-intersect-bug-sf-1146079.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\except-union-intersect-bug-sf-1146079.sql" ./sql/src/test/bugs/Tests/except-union-intersect-bug-sf-1146079.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../except-union-intersect-bug-sf-1146079.sql\"" ./sql/src/test/bugs/Tests/unicode_varchar-bug-sf-1041324_JdbcClient.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\..\unicode_varchar-bug-sf-1041324.sql" ./sql/src/test/bugs/Tests/unicode_varchar-bug-sf-1041324_JdbcClient.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -f \"$RELSRCDIR/../unicode_varchar-bug-sf-1041324.sql\"" ./sql/src/test/BugTracker/Tests/authorization.SF-1430616.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\authorization.SF-1430616-data.sql" ./sql/src/test/BugTracker/Tests/authorization.SF-1430616.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -q ./sql/src/test/BugTracker/Tests/authorization.SF-1430616.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\authorization.SF-1430616-drop_user.sql" ./sql/src/test/BugTracker/Tests/authorization.SF-1430616.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -f \"$RELSRCDIR/authorization.SF-1430616-data.sql\"" ./sql/src/test/BugTracker/Tests/authorization.SF-1430616.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -q" ./sql/src/test/BugTracker/Tests/authorization.SF-1430616.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -f \"$RELSRCDIR/authorization.SF-1430616-drop_user.sql\"" ./sql/src/test/BugTracker/Tests/drop_schema_crash.SF-1504794.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\drop_schema_crash.SF-1504794-data.sql" ./sql/src/test/BugTracker/Tests/drop_schema_crash.SF-1504794.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -f \"$RELSRCDIR/drop_schema_crash.SF-1504794-data.sql\"" ./sql/src/test/BugTracker/Tests/explain.SF-1739353.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\explain.SF-1739353-data.sql" ./sql/src/test/BugTracker/Tests/explain.SF-1739353.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -f \"$RELSRCDIR/explain.SF-1739353-data.sql\"" ./sql/src/test/BugTracker/Tests/jdbc_no_debug.SF-1739356.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -f "%RELSRCDIR%\jdbc_no_debug.SF-1739356-data.sql" ./sql/src/test/BugTracker/Tests/jdbc_no_debug.SF-1739356.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -f \"$RELSRCDIR/jdbc_no_debug.SF-1739356-data.sql\"" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCcreate_user.sql" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCschema.sql" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCinsert.sql" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCquery.sql" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCmanual_examples.sql" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCdrop.sql" ./sql/src/test/VOC/Tests/VOC.SQL.bat:call mjclient -h %HOST% -p %MAPIPORT% -d %TSTDB% -e -f "%RELSRCDIR%\..\VOCdrop_user.sql" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCcreate_user.sql\" 2>&1" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCschema.sql\" 2>&1" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCinsert.sql\" 2>&1" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCquery.sql\" 2>&1" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCmanual_examples.sql\" 2>&1" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCdrop.sql\" 2>&1" ./sql/src/test/VOC/Tests/VOC.SQL.sh:Mlog -x "$MTIMEOUT mjclient -h $HOST -p $MAPIPORT -d ${TSTDB} -e -f \"$RELSRCDIR/../VOCdrop_user.sql\" 2>&1" ======== -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On 21-06-2008 16:02:08 +0200, Stefan Manegold wrote:
Dear all,
I was wondering whether MonetDB/Java's "mjclient" wrapper script for jdbcclient.jar is still "maintained", "supported" and/or used?
We do only distribute it via MonetDB/Java's CVS sources, source tarball and the SuperSourceBall, but not in any binary package or as individual file like the *.jar's.
However, we (still) use it in some tests (see below).
I see the follwoing options:
1) Leave everything as it is. 2) Leave and distribute mjclient in/with the MonetDB/Java source, but make the tests independed of it by "inlining" its functionality 3) Abandon mjclient completely and make the tests independed of it by "inlining" its functionality
3: since mclient does some rendering of the mapi results, jdbcclient has been obsoleted. However, it still is pretty useful for testing JDBC, hence it still exists, but isn't built/distributed by default.
On Sat, Jun 21, 2008 at 06:29:31PM +0200, Fabian Groffen wrote:
On 21-06-2008 16:02:08 +0200, Stefan Manegold wrote:
Dear all,
I was wondering whether MonetDB/Java's "mjclient" wrapper script for jdbcclient.jar is still "maintained", "supported" and/or used?
We do only distribute it via MonetDB/Java's CVS sources, source tarball and the SuperSourceBall, but not in any binary package or as individual file like the *.jar's.
However, we (still) use it in some tests (see below).
I see the follwoing options:
1) Leave everything as it is. 2) Leave and distribute mjclient in/with the MonetDB/Java source, but make the tests independed of it by "inlining" its functionality 3) Abandon mjclient completely and make the tests independed of it by "inlining" its functionality
3: since mclient does some rendering of the mapi results, jdbcclient has been obsoleted. However, it still is pretty useful for testing JDBC, hence it still exists, but isn't built/distributed by default.
Thanks! Isn't there also a version of jdbcclient in monetdb-X.Y-jdbc.jar? If so, shouldn't we consider modifying the respective tests to use that one, and hence completely remove both jdbcclient.jar & mjclient? ("Officially", neither is distributed/released ...) Otherwise, would it be an option to replace mjclient/jdbcclient.jar by mclient in the respetive tests? Stefan -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On 21-06-2008 19:47:23 +0200, Stefan Manegold wrote:
3: since mclient does some rendering of the mapi results, jdbcclient has been obsoleted. However, it still is pretty useful for testing JDBC, hence it still exists, but isn't built/distributed by default.
Thanks!
Isn't there also a version of jdbcclient in monetdb-X.Y-jdbc.jar? If so, shouldn't we consider modifying the respective tests to use that one, and hence completely remove both jdbcclient.jar & mjclient? ("Officially", neither is distributed/released ...)
No. The way it is built is as follows: - mcl (the classes that deal with the wire protocol) - jdbc (the classes that implement the JDBC interfaces and their logic) - jdbcclient (the client class that emulates an interactive console) monetdb-X.Y-jdbc.jar: mcl + jdbc jdbcclient.jar: mcl + jdbc + jdbcclient Hence, you can *always* use jdbcclient.jar for everything, since it just contains everything (except xrpc stuff, which I leave out of consideration here).
Otherwise, would it be an option to replace mjclient/jdbcclient.jar by mclient in the respetive tests?
No, because that wouldn't test the jdbc + mcl components. Some tests, however, are a mix of testing jdbcclient and jdbc features, like the dump/restore test, e.g. reconstructing indexes and constraints with multi-columns. Tests that only address jdbcclient (like the encoding tests, even though one could argue that tests jdbc as well) could be disabled.
On Sat, Jun 21, 2008 at 04:02:08PM +0200, Stefan Manegold wrote:
Dear all,
I was wondering whether MonetDB/Java's "mjclient" wrapper script for jdbcclient.jar is still "maintained", "supported" and/or used?
We do only distribute it via MonetDB/Java's CVS sources, source tarball and the SuperSourceBall, but not in any binary package or as individual file like the *.jar's.
However, we (still) use it in some tests (see below).
I see the follwoing options:
1) Leave everything as it is. 2) Leave and distribute mjclient in/with the MonetDB/Java source, but make the tests independed of it by "inlining" its functionality 3) Abandon mjclient completely and make the tests independed of it by "inlining" its functionality
Solved by implementing option (3). Stefan
Any preferences and/or other suggestions?
Stefan
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
participants (2)
-
Fabian Groffen -
Stefan Manegold