Re: MonetDB: Jul2017 - Daemon was sending wrong answer for authoriza...
Thanks! This was one of the longest awaited fixes. Funny that it was just about a newline. Perhaps the bugfix can go to Dec2016? Best, Roberto On 31 May 2017 at 13:55, Panagiotis Koutsourakis < commits+kutsurak=monetdbsolutions.com@monetdb.org> wrote:
Changeset: e00fb765660d for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=e00fb765660d Modified Files: tools/merovingian/daemon/controlrunner.c Branch: Jul2017 Log Message:
Daemon was sending wrong answer for authorization request
When the password was correct, the server would send one extra new line that confused the client. This commit fixes bug 3545
diffs (12 lines):
diff --git a/tools/merovingian/daemon/controlrunner.c b/tools/merovingian/daemon/controlrunner.c --- a/tools/merovingian/daemon/controlrunner.c +++ b/tools/merovingian/daemon/controlrunner.c @@ -169,7 +169,7 @@ control_authorise( } free(pwd);
- mnstr_printf(fout, "=OK\n"); + mnstr_printf(fout, "=OK"); mnstr_flush(fout);
return 1; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
Hi Roberto, I just figured out a better implementation that would be backward compatible with any old server. I will revert this one and push the new one in the December branch, but It will probably not make it to the Dec2016-SP5 release. Best regards, Panos. Roberto Cornacchia @ 2017-05-31 15:16 GMT:
Thanks! This was one of the longest awaited fixes. Funny that it was just about a newline. Perhaps the bugfix can go to Dec2016?
Best, Roberto
On 31 May 2017 at 13:55, Panagiotis Koutsourakis < commits+kutsurak=monetdbsolutions.com@monetdb.org> wrote:
Changeset: e00fb765660d for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=e00fb765660d Modified Files: tools/merovingian/daemon/controlrunner.c Branch: Jul2017 Log Message:
Daemon was sending wrong answer for authorization request
When the password was correct, the server would send one extra new line that confused the client. This commit fixes bug 3545
diffs (12 lines):
diff --git a/tools/merovingian/daemon/controlrunner.c b/tools/merovingian/daemon/controlrunner.c --- a/tools/merovingian/daemon/controlrunner.c +++ b/tools/merovingian/daemon/controlrunner.c @@ -169,7 +169,7 @@ control_authorise( } free(pwd);
- mnstr_printf(fout, "=OK\n"); + mnstr_printf(fout, "=OK"); mnstr_flush(fout);
return 1; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
_______________________________________________ developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list
Thanks! On 1 June 2017 at 10:24, Panagiotis Koutsourakis < kutsurak@monetdbsolutions.com> wrote:
Hi Roberto,
I just figured out a better implementation that would be backward compatible with any old server. I will revert this one and push the new one in the December branch, but It will probably not make it to the Dec2016-SP5 release.
Best regards, Panos.
Roberto Cornacchia @ 2017-05-31 15:16 GMT:
Thanks! This was one of the longest awaited fixes. Funny that it was just about a newline. Perhaps the bugfix can go to Dec2016?
Best, Roberto
On 31 May 2017 at 13:55, Panagiotis Koutsourakis < commits+kutsurak=monetdbsolutions.com@monetdb.org> wrote:
Changeset: e00fb765660d for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=e00fb765660d Modified Files: tools/merovingian/daemon/controlrunner.c Branch: Jul2017 Log Message:
Daemon was sending wrong answer for authorization request
When the password was correct, the server would send one extra new line that confused the client. This commit fixes bug 3545
diffs (12 lines):
diff --git a/tools/merovingian/daemon/controlrunner.c b/tools/merovingian/daemon/controlrunner.c --- a/tools/merovingian/daemon/controlrunner.c +++ b/tools/merovingian/daemon/controlrunner.c @@ -169,7 +169,7 @@ control_authorise( } free(pwd);
- mnstr_printf(fout, "=OK\n"); + mnstr_printf(fout, "=OK"); mnstr_flush(fout);
return 1; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
_______________________________________________ developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list
_______________________________________________ developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list
participants (2)
-
Panagiotis Koutsourakis -
Roberto Cornacchia