Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/sql sql.c, 1.3, 1.4
On Mon, Nov 06, 2006 at 05:57:20PM +0000, Manuel Mayr wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/sql In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv29779
Modified Files: sql.c Log Message: sql fixed (bugreport id 1591467)
Index: sql.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/sql/sql.c,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- sql.c 6 Nov 2006 17:29:37 -0000 1.3 +++ sql.c 6 Nov 2006 17:57:17 -0000 1.4 @@ -195,8 +195,9 @@ sizeof( PFsql_schema_item_t ) ) };
+ for( i = 0; i < schema.count; i++ ) { - test = PFsql_alg_schmitm_conv(schema.items[i]); + // test = PFsql_alg_schmitm_conv(schema.items[i]);
Dear Manuel, I think it's better not te use the C++ style comments, since some C compiler doesn't like it. Regards, Jennie
} return ret; }
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
On 11/06/2006 09:25 PM, Ying Zhang wrote:
On Mon, Nov 06, 2006 at 05:57:20PM +0000, Manuel Mayr wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/sql In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv29779
Modified Files: sql.c Log Message: sql fixed (bugreport id 1591467)
Index: sql.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/sql/sql.c,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- sql.c 6 Nov 2006 17:29:37 -0000 1.3 +++ sql.c 6 Nov 2006 17:57:17 -0000 1.4 @@ -195,8 +195,9 @@ sizeof( PFsql_schema_item_t ) ) };
+ for( i = 0; i < schema.count; i++ ) { - test = PFsql_alg_schmitm_conv(schema.items[i]); + // test = PFsql_alg_schmitm_conv(schema.items[i]);
Dear Manuel,
I think it's better not te use the C++ style comments, since some C compiler doesn't like it.
Regards,
Jennie
Jennie, this is actually not so much of an issue with Pathfinder. It can compile only with C99 compliant compilers anyway which accept this comment syntax. -- Sjoerd Mullender
Hi all, Jennie's remark perfectly matches PF's coding conventions, though: // is to be avoided. If it currently isn't in all places, these are (some of many) spots where style should be improved. --Teggy On Nov 6, 2006, 10:06 PM, Sjoerd Mullender wrote with possible deletions: [...]
Jennie, this is actually not so much of an issue with Pathfinder. It can compile only with C99 compliant compilers anyway which accept this comment syntax.
-- Sjoerd Mullender
---------------------------------------------------------------------- --- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel? cmd=lnk&kid=120709&bid=263057&dat=121642______________________________ _________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Torsten Grust | torsten.grust@gmail.com
Hi all, i checked in sql.c again avoiding the C++ comment style. Sry about this, I still try to get into the code, and the whole code is still under construction. I'm working on a backend to translate the logical algebra to SQL. The files I checked in should only provide a small (still incomplete) set of functions to build the sql-tree. Best regards, Manuel On Mon, 6 Nov 2006, Torsten Grust wrote:
Hi all,
Jennie's remark perfectly matches PF's coding conventions, though: // is to be avoided. If it currently isn't in all places, these are (some of many) spots where style should be improved.
--Teggy
On Nov 6, 2006, 10:06 PM, Sjoerd Mullender wrote with possible deletions: [...]
Jennie, this is actually not so much of an issue with Pathfinder. It can compile only with C99 compliant compilers anyway which accept this comment syntax.
-- Sjoerd Mullender
---------------------------------------------------------------------- --- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel? cmd=lnk&kid=120709&bid=263057&dat=121642______________________________ _________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Torsten Grust | torsten.grust@gmail.com
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (4)
-
Manuel Mayr -
Sjoerd Mullender -
Torsten Grust -
Ying Zhang