Re: [Monetdb-developers] [Monetdb-checkins] java/scripts/Tests All, , 1.1.1.1, 1.2
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test
What is "pointless" in testing the minimal functionality of a tool that we build? Stefan
Index: All =================================================================== RCS file: /cvsroot/monetdb/java/scripts/Tests/All,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -u -d -r1.1.1.1 -r1.2 --- All 28 Nov 2007 14:54:05 -0000 1.1.1.1 +++ All 11 Dec 2007 13:36:48 -0000 1.2 @@ -1 +1 @@ -HAVE_JAVA?mjclient--help +#HAVE_JAVA?mjclient--help
------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On 11-12-2007 14:40:53 +0100, Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test
What is "pointless" in testing the minimal functionality of a tool that we build?
We test that functionality in other places, don't we?
On Tue, Dec 11, 2007 at 02:43:54PM +0100, Fabian Groffen wrote:
On 11-12-2007 14:40:53 +0100, Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test
What is "pointless" in testing the minimal functionality of a tool that we build?
We test that functionality in other places, don't we?
Nope. This is the first (and only) place where we test `mjclient --help`, the very purpose of this test --- and by the way about all of testing we can do here, i.e., without having any server(s), yet ... Stefan
------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Fabian Groffen wrote:
On 11-12-2007 14:40:53 +0100, Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test What is "pointless" in testing the minimal functionality of a tool that we build?
We test that functionality in other places, don't we? Only for mclient mclient.py msqldump Mbeddedsql
There is nothing to test the help of mjclient Regards, Romulo
------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
On 11-12-2007 14:51:02 +0100, Romulo Goncalves wrote:
Fabian Groffen wrote:
On 11-12-2007 14:40:53 +0100, Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test What is "pointless" in testing the minimal functionality of a tool that we build?
We test that functionality in other places, don't we? Only for mclient mclient.py msqldump Mbeddedsql
There is nothing to test the help of mjclient
That is the point, there is nothing to test in --help, as when it changes that is intended.
On Tue, Dec 11, 2007 at 02:53:35PM +0100, Fabian Groffen wrote:
On 11-12-2007 14:51:02 +0100, Romulo Goncalves wrote:
Fabian Groffen wrote:
On 11-12-2007 14:40:53 +0100, Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test What is "pointless" in testing the minimal functionality of a tool that we build?
We test that functionality in other places, don't we? Only for mclient mclient.py msqldump Mbeddedsql
There is nothing to test the help of mjclient
That is the point, there is nothing to test in --help, as when it changes that is intended.
Just to share my intentions of/for/with this test: The point of this test is (was) not (only) to test '--help', but actually to test (as early as possible, and without the need to have any server(s)) whether "mjclient" does work/start at all. Stefan -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 02:53:35PM +0100, Fabian Groffen wrote:
On 11-12-2007 14:51:02 +0100, Romulo Goncalves wrote:
Fabian Groffen wrote:
On 11-12-2007 14:40:53 +0100, Stefan Manegold wrote:
On Tue, Dec 11, 2007 at 01:36:50PM +0000, Fabian wrote:
Update of /cvsroot/monetdb/java/scripts/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22088
Modified Files: All Log Message: Don't run an absolutely pointless test What is "pointless" in testing the minimal functionality of a tool that we build? We test that functionality in other places, don't we? Only for mclient mclient.py msqldump Mbeddedsql
There is nothing to test the help of mjclient That is the point, there is nothing to test in --help, as when it changes that is intended. I think my English was not the proper one (nothing is always a word that I use directly from Portuguese and as usual it is creating some misunderstandings).
I wanted to say that there is no test to test the --help of mjclient which as Stefan says is the basic command to see if it is working. Regards, Romulo
Just to share my intentions of/for/with this test: The point of this test is (was) not (only) to test '--help', but actually to test (as early as possible, and without the need to have any server(s)) whether "mjclient" does work/start at all.
Stefan
On 11-12-2007 15:10:27 +0100, Romulo Goncalves wrote:
There is nothing to test the help of mjclient That is the point, there is nothing to test in --help, as when it changes that is intended. I think my English was not the proper one (nothing is always a word that I use directly from Portuguese and as usual it is creating some misunderstandings).
I wanted to say that there is no test to test the --help of mjclient which as Stefan says is the basic command to see if it is working.
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
On Dec 11, 2007, at 17:56 , Fabian Groffen wrote:
On 11-12-2007 15:10:27 +0100, Romulo Goncalves wrote:
There is nothing to test the help of mjclient That is the point, there is nothing to test in --help, as when it changes that is intended. I think my English was not the proper one (nothing is always a word that I use directly from Portuguese and as usual it is creating some misunderstandings).
I wanted to say that there is no test to test the --help of mjclient which as Stefan says is the basic command to see if it is working.
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
then, how about just start mclient without any options? it will complain that no language option is given. would that be a sufficient indication that mclient can be started at all?
------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
On 11-12-2007 18:23:06 +0100, Ying Zhang wrote:
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
then, how about just start mclient without any options? it will complain that no language option is given. would that be a sufficient indication that mclient can be started at all?
You missed a very vital "j". But look at the script and you will know like me that what is actually tested is already tested elsewhere, and that the test perceives to test something that is actually not tested (e.g. the mjclient script can still be tad broken, even though testing things it works).
On 11-12-2007 18:23:06 +0100, Ying Zhang wrote:
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
then, how about just start mclient without any options? it will complain that no language option is given. would that be a sufficient indication that mclient can be started at all?
You missed a very vital "j". But look at the script and you will know like me that what is actually tested is already tested elsewhere, and that the test perceives to test something that is actually not tested (e.g. the mjclient script can still be tad broken, even though testing things it works).
On 11-12-2007 18:25:43 +0100, Fabian Groffen wrote: thinks
On Tue, Dec 11, 2007 at 06:28:30PM +0100, Fabian Groffen wrote:
On 11-12-2007 18:23:06 +0100, Ying Zhang wrote:
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
then, how about just start mclient without any options? it will complain that no language option is given. would that be a sufficient indication that mclient can be started at all?
You missed a very vital "j". But look at the script and you will know like me that what is actually tested is already tested elsewhere, and that the test perceives to test something that is actually not tested (e.g. the mjclient script can still be tad broken, even though testing things it works).
On 11-12-2007 18:25:43 +0100, Fabian Groffen wrote: thinks
MonetDB Java is all your's. Hence, feel free to tailor it to your satisfaction. (To keep things clean, you might want to consider properly removing "pointless" tests instead of merely deactivating them --- just a *suggestion*.) Stefan -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On Dec 11, 2007, at 18:25 , Fabian Groffen wrote:
On 11-12-2007 18:23:06 +0100, Ying Zhang wrote:
Hmmm, while that is given how the mjclient script looks like a bit of a lost case, I understand the idea. I still don't like it being tested via --help or --version simply because that means the side effect of the test is what actually is to be tested here.
then, how about just start mclient without any options? it will complain that no language option is given. would that be a sufficient indication that mclient can be started at all?
You missed a very vital "j".
you are right :(
But look at the script and you will know like me that what is actually tested is already tested elsewhere, and that the test perceives to test something that is actually not tested (e.g. the mjclient script can still be tad broken, even though testing things it works). ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (4)
-
Fabian Groffen -
Romulo Goncalves -
Stefan Manegold -
Ying Zhang