Re: MonetDB: leftmart - trying to fix Windows compilation: do not "i...
Stefan, this needs to be inlined because it is used many times. I will deal with compilation issues later on. This is a dev branch and we are running different experiments every night. But with this change if measured times are different I would not know if it is because of other changes or because of the inline statement removal. I would appreciate if you did not make any changes in this branch at the moment. thank you, lefteris On Mon, Mar 7, 2016 at 8:34 PM, Stefan Manegold < commits+Stefan.Manegold=cwi.nl@monetdb.org> wrote:
Changeset: ea1aed8beff8 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=ea1aed8beff8 Modified Files: gdk/gdk_bloom.c Branch: leftmart Log Message:
trying to fix Windows compilation: do not "inline" BLOOMask()
On Windows, compilation fails with failed invocation: cl -GF -W3 -WX -MD -nologo -Ox -Zi -Oi -I. -I.\.. -I.\..\..\gdk -I..\common\options -I.\..\..\gdk\..\common\options -I..\common\stream -I.\..\..\gdk\..\common\stream -I..\common\utils -I.\..\..\gdk\..\common\utils -I.\..\..\buildtools\conf -DHAVE_ICONV -IC:\Libraries\iconv-1.11.1.win64-vs2010\include -DHAVE_LIBATOMIC_OPS -IC:\Libraries\atomic_ops-7.4.2 -DNDEBUG -LD -Felibbat.dll gdk_batop.obj gdk_select.obj gdk_search.obj gdk_hash.obj gdk_tm.obj gdk_orderidx.obj gdk_align.obj gdk_bbp.obj gdk_heap.obj gdk_utils.obj gdk_atoms.obj gdk_qsort.obj gdk_ssort.obj gdk_storage.obj gdk_bat.obj gdk_delta.obj gdk_cross.obj gdk_system.obj gdk_value.obj gdk_posix.obj gdk_logger.obj gdk_sample.obj gdk_calc.obj gdk_aggr.obj gdk_group.obj gdk_imprints.obj gdk_bloom.obj gdk_join.obj gdk_project.obj gdk_unique.obj gdk_firstn.obj libbat.res /link ..\common\options\monet_options.obj ..\common\stream\libstream.lib ..\common\utils\mutils.obj ..\common\utils\prompt.obj wsock32.lib Ws2_32.l ib C:\Libraries\zlib-1.2.8.win64-vs2010\lib\zdll.lib C:\Libraries\bzip2-1.0.6.win64-vs2010\lib\libbz2.lib psapi.lib Creating library libbat.lib and object libbat.exp gdk_join.obj : error LNK2019: unresolved external symbol BLOOMask referenced in function hashjoin libbat.dll : fatal error LNK1120: 1 unresolved externals
Maybe, the fact that BLOOMask() is "inline"d triggers this problem ...
diffs (11 lines):
diff --git a/gdk/gdk_bloom.c b/gdk/gdk_bloom.c --- a/gdk/gdk_bloom.c +++ b/gdk/gdk_bloom.c @@ -240,7 +240,6 @@ BATbloom(BAT *b) return GDK_SUCCEED; }
-inline int BLOOMask(BUN v, Bloomfilter *bloom) { BUN hv,mv,x,y,z; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
My mistake. Sorry! Stefan ----- On Mar 8, 2016, at 12:12 AM, Lefteris lsidir@gmail.com wrote:
Stefan,
this needs to be inlined because it is used many times. I will deal with compilation issues later on. This is a dev branch and we are running different experiments every night. But with this change if measured times are different I would not know if it is because of other changes or because of the inline statement removal.
I would appreciate if you did not make any changes in this branch at the moment.
thank you,
lefteris
On Mon, Mar 7, 2016 at 8:34 PM, Stefan Manegold < commits+Stefan.Manegold=cwi.nl@monetdb.org> wrote:
Changeset: ea1aed8beff8 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=ea1aed8beff8 Modified Files: gdk/gdk_bloom.c Branch: leftmart Log Message:
trying to fix Windows compilation: do not "inline" BLOOMask()
On Windows, compilation fails with failed invocation: cl -GF -W3 -WX -MD -nologo -Ox -Zi -Oi -I. -I.\.. -I.\..\..\gdk -I..\common\options -I.\..\..\gdk\..\common\options -I..\common\stream -I.\..\..\gdk\..\common\stream -I..\common\utils -I.\..\..\gdk\..\common\utils -I.\..\..\buildtools\conf -DHAVE_ICONV -IC:\Libraries\iconv-1.11.1.win64-vs2010\include -DHAVE_LIBATOMIC_OPS -IC:\Libraries\atomic_ops-7.4.2 -DNDEBUG -LD -Felibbat.dll gdk_batop.obj gdk_select.obj gdk_search.obj gdk_hash.obj gdk_tm.obj gdk_orderidx.obj gdk_align.obj gdk_bbp.obj gdk_heap.obj gdk_utils.obj gdk_atoms.obj gdk_qsort.obj gdk_ssort.obj gdk_storage.obj gdk_bat.obj gdk_delta.obj gdk_cross.obj gdk_system.obj gdk_value.obj gdk_posix.obj gdk_logger.obj gdk_sample.obj gdk_calc.obj gdk_aggr.obj gdk_group.obj gdk_imprints.obj gdk_bloom.obj gdk_join.obj gdk_project.obj gdk_unique.obj gdk_firstn.obj libbat.res /link ..\common\options\monet_options.obj ..\common\stream\libstream.lib ..\common\utils\mutils.obj ..\common\utils\prompt.obj wsock32.lib Ws2_32.l ib C:\Libraries\zlib-1.2.8.win64-vs2010\lib\zdll.lib C:\Libraries\bzip2-1.0.6.win64-vs2010\lib\libbz2.lib psapi.lib Creating library libbat.lib and object libbat.exp gdk_join.obj : error LNK2019: unresolved external symbol BLOOMask referenced in function hashjoin libbat.dll : fatal error LNK1120: 1 unresolved externals
Maybe, the fact that BLOOMask() is "inline"d triggers this problem ...
diffs (11 lines):
diff --git a/gdk/gdk_bloom.c b/gdk/gdk_bloom.c --- a/gdk/gdk_bloom.c +++ b/gdk/gdk_bloom.c @@ -240,7 +240,6 @@ BATbloom(BAT *b) return GDK_SUCCEED; }
-inline int BLOOMask(BUN v, Bloomfilter *bloom) { BUN hv,mv,x,y,z; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
-- | Stefan.Manegold@CWI.nl | DB Architectures (DA) | | www.CWI.nl/~manegold/ | Science Park 123 (L321) | | +31 (0)20 592-4212 | 1098 XG Amsterdam (NL) |
Hello monetdb team, A gentle reminder. We have a main table with 126 columns and approx. 94000 rows. We are trying to load approx 2500 records from temporary table into main table using query “insert into select” query. The database crashes upon query execution. No specific error is created in log file. When tried with 1500 records, it works. We also created another main table with same DDL, that table is empty & inserted all the records from temp successfully without any issue. What could be the reason? Is 126 cols an issue? Please help. We are stuck. (btw: We have machine about 200GB of hard disk & 16 GB RAM (14 GB free)) Thank you Souri Ratnaparkhi United Software Associates Pvt. Ltd. Pune, India Mob: 8975677255 Phone (India Lines): (91) 020-25445550 www.usain.com -----Original Message----- From: developers-list [mailto:developers-list-bounces+souri.ratnaparkhi=usain.com@monetdb.org] On Behalf Of Stefan Manegold Sent: Tuesday, March 08, 2016 5:05 AM To: Lefteris Cc: Communication channel for developers of the MonetDB Subject: Re: MonetDB: leftmart - trying to fix Windows compilation: do not "i... My mistake. Sorry! Stefan ----- On Mar 8, 2016, at 12:12 AM, Lefteris lsidir@gmail.com wrote:
Stefan,
this needs to be inlined because it is used many times. I will deal with compilation issues later on. This is a dev branch and we are running different experiments every night. But with this change if measured times are different I would not know if it is because of other changes or because of the inline statement removal.
I would appreciate if you did not make any changes in this branch at the moment.
thank you,
lefteris
On Mon, Mar 7, 2016 at 8:34 PM, Stefan Manegold < commits+Stefan.Manegold=cwi.nl@monetdb.org> wrote:
Changeset: ea1aed8beff8 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=ea1aed8beff8 Modified Files: gdk/gdk_bloom.c Branch: leftmart Log Message:
trying to fix Windows compilation: do not "inline" BLOOMask()
On Windows, compilation fails with failed invocation: cl -GF -W3 -WX -MD -nologo -Ox -Zi -Oi -I. -I.\.. -I.\..\..\gdk -I..\common\options -I.\..\..\gdk\..\common\options -I..\common\stream -I.\..\..\gdk\..\common\stream -I..\common\utils -I.\..\..\gdk\..\common\utils -I.\..\..\buildtools\conf -DHAVE_ICONV -IC:\Libraries\iconv-1.11.1.win64-vs2010\include -DHAVE_LIBATOMIC_OPS -IC:\Libraries\atomic_ops-7.4.2 -DNDEBUG -LD -Felibbat.dll gdk_batop.obj gdk_select.obj gdk_search.obj gdk_hash.obj gdk_tm.obj gdk_orderidx.obj gdk_align.obj gdk_bbp.obj gdk_heap.obj gdk_utils.obj gdk_atoms.obj gdk_qsort.obj gdk_ssort.obj gdk_storage.obj gdk_bat.obj gdk_delta.obj gdk_cross.obj gdk_system.obj gdk_value.obj gdk_posix.obj gdk_logger.obj gdk_sample.obj gdk_calc.obj gdk_aggr.obj gdk_group.obj gdk_imprints.obj gdk_bloom.obj gdk_join.obj gdk_project.obj gdk_unique.obj gdk_firstn.obj libbat.res /link ..\common\options\monet_options.obj ..\common\stream\libstream.lib ..\common\utils\mutils.obj ..\common\utils\prompt.obj wsock32.lib Ws2_32.l ib C:\Libraries\zlib-1.2.8.win64-vs2010\lib\zdll.lib C:\Libraries\bzip2-1.0.6.win64-vs2010\lib\libbz2.lib psapi.lib Creating library libbat.lib and object libbat.exp gdk_join.obj : error LNK2019: unresolved external symbol BLOOMask referenced in function hashjoin libbat.dll : fatal error LNK1120: 1 unresolved externals
Maybe, the fact that BLOOMask() is "inline"d triggers this problem ...
diffs (11 lines):
diff --git a/gdk/gdk_bloom.c b/gdk/gdk_bloom.c --- a/gdk/gdk_bloom.c +++ b/gdk/gdk_bloom.c @@ -240,7 +240,6 @@ BATbloom(BAT *b) return GDK_SUCCEED; }
-inline int BLOOMask(BUN v, Bloomfilter *bloom) { BUN hv,mv,x,y,z; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
-- | Stefan.Manegold@CWI.nl | DB Architectures (DA) | | www.CWI.nl/~manegold/ | Science Park 123 (L321) | | +31 (0)20 592-4212 | 1098 XG Amsterdam (NL) | _______________________________________________ developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list
participants (3)
-
Lefteris -
Souri Ratnaparkhi -
Stefan Manegold