Re: [Monetdb-developers] 'MapiClient remember history between sessions' patch
I have made a RFE for this, including the patch (-u). https://sourceforge.net/tracker/index.php?func=detail&aid=951859&group_id=56967&atid=482471 Sjoerd Mullender wrote:
Arjan Scherpenisse wrote:
Please use a context diff for patches (-c or -u option). I think this should go in the SourceForge RFE (Request For Enhancement) tracker (with the patch as attachment). It should be configurable (both whether, and where), and probably off by default. On Windows it is by no means certain that C: exists nor that C:\ is writable by Joe Random Luser. What about errors?
Having said all of this, I think a patch like this has potential and could be included.
regards,
------------------------------------------------------------------------
Index: MapiClient.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB/src/mapi/clients/C/MapiClient.mx,v retrieving revision 1.56 diff -r1.56 MapiClient.mx 854a855,857
#ifdef HAVE_LIBREADLINE char history_file[100]; #endif
1000a1004,1012
#ifdef HAVE_LIBREADLINE #ifndef NATIVE_WIN32 snprintf(history_file, 100, "%s/.mapiclient_history", getenv("HOME")); #else snprintf(history_file, 100, "C:\\_mapiclient_history"); #endif read_history(history_file); #endif
1016a1029,1033
#ifdef HAVE_LIBREADLINE write_history(history_file); #endif
-- Arjan Scherpenisse Centrum voor Wiskunde en Informatica, Amsterdam, the Netherlands
participants (1)
-
Arjan Scherpenisse