Re: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb - developers-list

newer
Announcement: New Feb2013-SP1...

Re: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

older
Announcement: New Feb2013 Feature...

Fabian Groffen

26 Feb 2013 26 Feb '13

1:57 p.m.

Any reason for undoing 0f30e64e9bb2? On 26-02-2013 14:52:15 +0100, Martin Kersten wrote:

...

Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker");

+ q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

-- Fabian Groffen fabian@monetdb.org column-store pioneer http://www.monetdb.org/Home

Show replies by date

Sjoerd Mullender

26 Feb 26 Feb

3:58 p.m.

New subject: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

On 2013-02-26 14:57, Fabian Groffen wrote:

...

Any reason for undoing 0f30e64e9bb2?

MALresourceFairness can delay the calling thread for a long time, so you want the enqueue (sema up) to happen first.

...

On 26-02-2013 14:52:15 +0100, Martin Kersten wrote:

...
Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker");

+ q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

-- Sjoerd Mullender

Chi-Young Ku

4 Mar 4 Mar

5:04 p.m.

New subject: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

Hi, I would like to include "$(top_builddir)/monetdb5/modules/kernel/algebra.h in $(top_srcdir)/sql/server/rel_optimizer.h. I modified $(top_srcdir)/sql/server/Makefile.in. But, this file is generated during configuration. Could you explain how I would modify the configuration script to include "$(top_builddir)/monetdb5/modules/kernel/" in the INCLUDES varialbe for sql/server? Thanks in advance. Chi ________________________________ From: Fabian Groffen To: developers-list@monetdb.org Sent: Tuesday, February 26, 2013 8:57 AM Subject: Re: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb Any reason for undoing 0f30e64e9bb2? On 26-02-2013 14:52:15 +0100, Martin Kersten wrote:

...

Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker"); + q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

Sjoerd Mullender

5:56 p.m.

New subject: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

What does this have to do with the message you're responding to? Please start a new email thread when you introduce a new subject. Just send mail to the mailing list with a proper subject. On 2013-03-04 18:04, Chi-Young Ku wrote:

...

Hi,

I would like to include "$(top_builddir)/monetdb5/modules/kernel/algebra.h in $(top_srcdir)/sql/server/rel_optimizer.h. I modified $(top_srcdir)/sql/server/Makefile.in. But, this file is generated during configuration.

Could you explain how I would modify the configuration script to include "$(top_builddir)/monetdb5/modules/kernel/" in the INCLUDES varialbe for sql/server?

Edit the file sql/server/Makefile.ag in the directory and add ../../monetdb5/modules/kernel to the list of INCLUDES. Then run ./bootstrap, and then the normal configure; make; make install.

...

Thanks in advance.

Chi

------------------------------------------------------------------------ *From:* Fabian Groffen *To:* developers-list@monetdb.org *Sent:* Tuesday, February 26, 2013 8:57 AM *Subject:* Re: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

Any reason for undoing 0f30e64e9bb2?

On 26-02-2013 14:52:15 +0100, Martin Kersten wrote:

...
Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker");

+ q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

-- Fabian Groffen fabian@monetdb.org mailto:fabian@monetdb.org column-store pioneer http://www.monetdb.org/Home _______________________________________________ developers-list mailing list developers-list@monetdb.org mailto:developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

_______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

-- Sjoerd Mullender

Chi-Young Ku

6:29 p.m.

New subject: Fw: How would I add a new include directory in Makefile.in

...

Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker"); + q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

-- Fabian Groffen fabian@monetdb.org column-store pioneer http://www.monetdb.org/Home _______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list _______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

Lefteris

6:35 p.m.

New subject: Fw: How would I add a new include directory in Makefile.in

Quoting Sjoerd: Edit the file sql/server/Makefile.ag in the directory and add ../../monetdb5/modules/kernel to the list of INCLUDES. Then run ./bootstrap, and then the normal configure; make; make install. On Mon, Mar 4, 2013 at 7:29 PM, Chi-Young Ku wrote:

...

Hi,

I would like to include "$(top_builddir)/monetdb5/modules/kernel/algebra.h in $(top_srcdir)/sql/server/rel_optimizer.h. I modified $(top_srcdir)/sql/server/Makefile.in. But, this file is generated during configuration.

Could you explain how I would modify the configuration script to include "$(top_builddir)/monetdb5/modules/kernel/" in the INCLUDES varialbe for sql/server?

Thanks in advance.

Chi

________________________________ From: Fabian Groffen To: developers-list@monetdb.org Sent: Tuesday, February 26, 2013 8:57 AM Subject: Re: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

Any reason for undoing 0f30e64e9bb2?

On 26-02-2013 14:52:15 +0100, Martin Kersten wrote:

...
Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker");

+ q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

-- Fabian Groffen fabian@monetdb.org column-store pioneer http://www.monetdb.org/Home _______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

_______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

_______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

Chi-Young Ku

6:44 p.m.

New subject: Fw: How would I add a new include directory in Makefile.in

Thanks a lot! Chi ________________________________ From: Lefteris To: Communication channel for developers of the MonetDB suite. Sent: Monday, March 4, 2013 1:35 PM Subject: Re: Fw: How would I add a new include directory in Makefile.in Quoting Sjoerd: Edit the file sql/server/Makefile.ag in the directory and add ../../monetdb5/modules/kernel to the list of INCLUDES. Then run ./bootstrap, and then the normal configure; make; make install. On Mon, Mar 4, 2013 at 7:29 PM, Chi-Young Ku wrote:

...

Hi,

I would like to include "$(top_builddir)/monetdb5/modules/kernel/algebra.h in $(top_srcdir)/sql/server/rel_optimizer.h. I modified $(top_srcdir)/sql/server/Makefile.in. But, this file is generated during configuration.

Could you explain how I would modify the configuration script to include "$(top_builddir)/monetdb5/modules/kernel/" in the INCLUDES varialbe for sql/server?

Thanks in advance.

Chi

________________________________ From: Fabian Groffen To: developers-list@monetdb.org Sent: Tuesday, February 26, 2013 8:57 AM Subject: Re: MonetDB: Feb2013 - Make MALresource independent of cntxt and mb

Any reason for undoing 0f30e64e9bb2?

On 26-02-2013 14:52:15 +0100, Martin Kersten wrote:

...
Changeset: 33a1b7bfcb28 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=33a1b7bfcb28 Modified Files: monetdb5/mal/mal_dataflow.c monetdb5/mal/mal_interpreter.c monetdb5/mal/mal_resource.c monetdb5/mal/mal_resource.h Branch: Feb2013 Log Message:

Make MALresource independent of cntxt and mb

diffs (87 lines):

diff --git a/monetdb5/mal/mal_dataflow.c b/monetdb5/mal/mal_dataflow.c --- a/monetdb5/mal/mal_dataflow.c +++ b/monetdb5/mal/mal_dataflow.c @@ -328,13 +328,13 @@ DFLOWworker(void *t) } MT_lock_unset(&flow->flowlock, "MALworker");

+ q_enqueue(flow->done, fe); if ( fnxt == 0) { if (todo->last == 0) profilerHeartbeatEvent("wait"); else - MALresourceFairness(flow->cntxt, flow->mb, usec); + MALresourceFairness(usec); } - q_enqueue(flow->done, fe); } GDKfree(GDKerrbuf); GDKsetbuf(0);

-- Fabian Groffen fabian@monetdb.org column-store pioneer http://www.monetdb.org/Home _______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

_______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

_______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

_______________________________________________ developers-list mailing list developers-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/developers-list

4316

Age (days ago)

4322

Last active (days ago)

List overview

Download

6 comments

4 participants

participants (4)

Chi-Young Ku
Fabian Groffen
Lefteris
Sjoerd Mullender