On Mon, Sep 01, 2008 at 11:22:10PM +0200, Ying Zhang wrote:

Hi,

I have just updated my monet source from souceforge and did a from scratch compilation on my leopard.

Fabian's fix gets rid of the error "implicit declaration of..." (thanks!) However, the other error "ISO C90 forbids.." is still there. With the following patch, I was able to compile the module MonetDB (a complete rebuild of monet modules is still ongoing).

I simply moved the definition of len to the begin of the function:

$ cvs diff src/gdk/gdk_system.mx Index: src/gdk/gdk_system.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB/src/gdk/gdk_system.mx,v retrieving revision 1.115 diff -r1.115 gdk_system.mx 570a571,574

...

#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__MACH__) size_t len = sizeof(int); #endif

578d581 < size_t len = sizeof(int);

Thanks. I just checked in (my version of ;-)) your patch. Stefan

Jennie

On Sep 01, 2008, at 22:35 , Hendrike Peetz wrote:

...

nope. still the same problem. I checked out from the svn right after I got your mail.

On Sep 1, 2008, at 10:13 PM, Fabian Groffen (Project Account) wrote:

...

I tried to fix the issue. Please report if it works.

On 01-09-2008 22:01:01 +0200, Fabian Groffen (Project Account) wrote:

...

On 01-09-2008 21:57:13 +0200, Fabian Groffen wrote:

...

...

> cc1: warnings being treated as errors > ../../../MonetDB/src/gdk/gdk_system.mx: In function > 'MT_check_nr_cores': > ../../../MonetDB/src/gdk/gdk_system.mx:575: warning: ISO C90 > forbids mixed declarations and code > ../../../MonetDB/src/gdk/gdk_system.mx:576: error: implicit > declaration of function 'sysctlbyname'

No. The MonetDB sources aren't tested on Leopard on a daily basis, and this change/code in particular isn't at all. I tried it on Tiger, but didn't care to check on Leopard.

Actually, the actual code was never tested, as it's just missing an include ;)

-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |