[MonetDB-users] possible bug in monetdb-install.sh
Hi, I was using moentdb-install.sh to install the May 2009 release with the following command, which ends in an error: ================================ $ monetdb-install.sh --prefix=[pathto]/mdb_may2009 --enable-optimize --enable-xquery --22:11:36-- http://www.ins.cwi.nl/~monet/tars/latest/release/MonetDB.tar.bz2 => `/private/var/tmp/MonetDB-1244491895/MonetDB/ MonetDB.tar.bz2' Resolving www.ins.cwi.nl... 192.16.196.21 Connecting to www.ins.cwi.nl|192.16.196.21|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 882,241 (862K) [application/x-bzip2] 0K ........ ..... 100% 780.55 KB/s 22:11:37 (780.55 KB/s) - `/private/var/tmp/MonetDB-1244491895/MonetDB/ MonetDB.tar.bz2' saved [882241/882241] fetching http://www.ins.cwi.nl/~monet/tars/latest/release/MonetDB.tar {,bz2:bzip2,gz:gzip} failed! Please refer to the full log at /private/var/tmp/MonetDB-1244491895/log If you believe this is an error in the script or the software, file a bug and attach the logfile. Terminated ================================ The following code in the 'fetch()' function seems incorrect to me: for c in $LZMA $BZIP2 $GZIP ; do wget --progress=dot:mega -t 5 --passive-ftp $1.${c%:*} -P "$BUILDROOT"/$f > $QUIET ... done [[ ! -f "$BUILDROOT"/$f/$f.tar ]] && \ die "fetching $1 {$LZMA,$BZIP2,$GZIP} failed!" First, in the for-loop, e.g., MonetDB.tar.bz2 is fetched. Then, the code following the for-loop checks if ".../MonetDB.tar" exists, if not, it complains that fetching ".../MonetDB.tar.bz2" has failed, returning the error I got. Kind regards, Jennie
On Jun 08, 2009, at 22:39 , Ying Zhang wrote:
Hi,
I was using moentdb-install.sh to install the May 2009 release with the following command, which ends in an error:
================================ $ monetdb-install.sh --prefix=[pathto]/mdb_may2009 --enable-optimize --enable-xquery --22:11:36-- http://www.ins.cwi.nl/~monet/tars/latest/release/MonetDB.tar.bz2 => `/private/var/tmp/MonetDB-1244491895/MonetDB/ MonetDB.tar.bz2' Resolving www.ins.cwi.nl... 192.16.196.21 Connecting to www.ins.cwi.nl|192.16.196.21|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 882,241 (862K) [application/x-bzip2]
0K ........ ..... 100% 780.55 KB/s
22:11:37 (780.55 KB/s) - `/private/var/tmp/MonetDB-1244491895/MonetDB/ MonetDB.tar.bz2' saved [882241/882241]
fetching http://www.ins.cwi.nl/~monet/tars/latest/release/MonetDB.tar {,bz2:bzip2,gz:gzip} failed! Please refer to the full log at /private/var/tmp/MonetDB-1244491895/ log If you believe this is an error in the script or the software, file a bug and attach the logfile. Terminated ================================
The following code in the 'fetch()' function seems incorrect to me:
for c in $LZMA $BZIP2 $GZIP ; do wget --progress=dot:mega -t 5 --passive-ftp $1.${c%:*} -P "$BUILDROOT"/$f > $QUIET ... done [[ ! -f "$BUILDROOT"/$f/$f.tar ]] && \ die "fetching $1 {$LZMA,$BZIP2,$GZIP} failed!"
First, in the for-loop, e.g., MonetDB.tar.bz2 is fetched. Then, the code following the for-loop checks if ".../MonetDB.tar" exists, if not, it complains that fetching ".../MonetDB.tar.bz2" has failed, returning the error I got.
I think I have found the cause of the error, which is not the check after the for-loop. Unpacking MonetDB.tar.bz2 should have been done in the for-loop, but in my case, it didn't, because I don't have md5sum. The code says: for c in $LZMA $BZIP2 $GZIP ; do wget --progress=dot:mega -t 5 --passive-ftp $1.${c%:*} -P "$BUILDROOT"/$f > $QUIET if [[ $? == 0 ]] ; then if [[ -n $MD5SUM ]] ; then wget --progress=dot:mega -t 5 --passive-ftp $1.${c %:*}.md5sum -P "$BUILDROOT"/$f > $QUIET ... else # don't have md5sum, assume it's correct break fi fi done It only assumes it's correct, but doesn't unpack the fetched file. I copy-pasted a line into the else statement: else # don't have md5sum, assume it's correct ${c#*:} -d "$BUILDROOT"/$f/$f.tar.${c%:*} break Now it works:) Regards, Jennie
On 08-06-2009 23:04:23 +0200, Ying Zhang wrote:
It only assumes it's correct, but doesn't unpack the fetched file. I copy-pasted a line into the else statement:
else # don't have md5sum, assume it's correct ${c#*:} -d "$BUILDROOT"/$f/$f.tar.${c%:*} break
Now it works:)
Feel free to commit. Looks good/correct indeed. I simply don't have systems which lack md5sum :)
Hi Jennie, On 08-06-2009 22:39:15 +0200, Ying Zhang wrote:
fetching http://www.ins.cwi.nl/~monet/tars/latest/release/MonetDB.tar {,bz2:bzip2,gz:gzip} failed! Please refer to the full log at /private/var/tmp/MonetDB-1244491895/log If you believe this is an error in the script or the software, file a bug and attach the logfile.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
First, in the for-loop, e.g., MonetDB.tar.bz2 is fetched. Then, the code following the for-loop checks if ".../MonetDB.tar" exists, if not, it complains that fetching ".../MonetDB.tar.bz2" has failed, returning the error I got.
Can you "attach the logfile"? :)
participants (2)
-
Fabian Groffen
-
Ying Zhang